Skip to content

Commit 21433f0

Browse files
committed
release: v0.4.3
Patch release fixing approve for non-creator PRs: * resolve_reviewer_id/3 simplified to use the authenticated user's identity GUID directly (via current_user_id/0). No more fallback to createdBy.id, which caused 'You cannot record a vote for someone else' errors. The Azure DevOps PUT /reviewers/{id} endpoint auto-adds the user as a reviewer with the vote, so this works for PRs the user created, was added to as a reviewer, or needs to be added to. Function reduced from 34 lines to 9. See CHANGELOG [0.4.3] for full details.
1 parent 39e5d4d commit 21433f0

4 files changed

Lines changed: 23 additions & 7 deletions

File tree

CHANGELOG.md

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,22 @@ All notable changes to `ado` will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [0.4.3] - 2026-06-17
9+
10+
### Fixed
11+
12+
- **`ado prs approve` for any PR**`resolve_reviewer_id/3` previously
13+
fell back to `createdBy.id` (the PR creator's identity) when the
14+
authenticated user was not in the PR's reviewer list. This caused
15+
`TF401186: You cannot record a vote for someone else` errors when
16+
voting on a PR the user did not create. Now uses the authenticated
17+
user's identity GUID directly (via `current_user_id/0`). The Azure
18+
DevOps `PUT /reviewers/{id}` endpoint auto-adds the user as a
19+
reviewer with the given vote if they aren't one already, so this
20+
works for PRs the user created, was added to as a reviewer, or
21+
needs to be added to. Function simplified from 34 lines to 9.
22+
23+
824
## [0.4.2] - 2026-06-16
925

1026
### Fixed
@@ -488,8 +504,8 @@ the embedded skills can be installed into any LLM agent's skill directory.
488504
are filtered by the `mix ci.dialyzer` task.
489505
- ExUnit test count: 234 (across 30+ test files). All pass.
490506

491-
[Unreleased]: https://github.com/gilbertwong96/ado_cli/compare/v0.4.2...HEAD
492-
[0.4.2]: https://github.com/gilbertwong96/ado_cli/compare/v0.4.1...v0.4.2
507+
[Unreleased]: https://github.com/gilbertwong96/ado_cli/compare/v0.4.3...HEAD
508+
[0.4.3]: https://github.com/gilbertwong96/ado_cli/compare/v0.4.2...v0.4.3
493509
[0.4.1]: https://github.com/gilbertwong96/ado_cli/compare/v0.4.0...v0.4.1
494510
[0.4.0]: https://github.com/gilbertwong96/ado_cli/compare/v0.3.0...v0.4.0
495511
[0.3.0]: https://github.com/gilbertwong96/ado_cli/compare/v0.2.4...v0.3.0

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ put it on your `$PATH`:
6666

6767
```bash
6868
# Example for Apple Silicon Mac (pick the right binary for your platform)
69-
curl -L -o ado https://github.com/gilbertwong96/ado_cli/releases/latest/download/ado-0.4.2-macos-aarch64
69+
curl -L -o ado https://github.com/gilbertwong96/ado_cli/releases/latest/download/ado-0.4.3-macos-aarch64
7070
chmod +x ado && sudo mv ado /usr/local/bin/
7171
```
7272

@@ -708,7 +708,7 @@ before they go public.
708708

709709
```bash
710710
# 1. Bump version in mix.exs, commit, tag
711-
$EDITOR mix.exs # bump version: "0.2.0" -> "0.4.2"
711+
$EDITOR mix.exs # bump version: "0.2.0" -> "0.4.3"
712712
git add -u && git commit -m "v0.2.0"
713713
git tag -a v0.2.0 -m "Release 0.2.0"
714714
git push github main v0.2.0

github-page/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,9 @@ <h2>Other install methods</h2>
228228
<div class="card">
229229
<h3>📥 Download binary</h3>
230230
<p>Grab the platform-specific binary and put it on your <code>$PATH</code>.</p>
231-
<pre><code>curl -L -o ado https://github.com/gilbertwong96/ado_cli/releases/latest/download/ado-0.4.2-macos-aarch64
231+
<pre><code>curl -L -o ado https://github.com/gilbertwong96/ado_cli/releases/latest/download/ado-0.4.3-macos-aarch64
232232
chmod +x ado &amp;&amp; sudo mv ado /usr/local/bin/</code></pre>
233-
<p class="hint">Replace <code>ado-0.4.2-macos-aarch64</code> with the binary for your platform (see the <a href="https://github.com/gilbertwong96/ado_cli/releases/latest">release page</a>).</p>
233+
<p class="hint">Replace <code>ado-0.4.3-macos-aarch64</code> with the binary for your platform (see the <a href="https://github.com/gilbertwong96/ado_cli/releases/latest">release page</a>).</p>
234234
</div>
235235
<div class="card">
236236
<h3>🔨 Build from source</h3>

mix.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ defmodule AdoCli.MixProject do
44
def project do
55
[
66
app: :ado_cli,
7-
version: "0.4.2",
7+
version: "0.4.3",
88
elixir: "~> 1.20",
99
start_permanent: Mix.env() == :prod,
1010
deps: deps(),

0 commit comments

Comments
 (0)