Commit 21433f0
committed
release: v0.4.3
Patch release fixing approve for non-creator PRs:
* resolve_reviewer_id/3 simplified to use the authenticated
user's identity GUID directly (via current_user_id/0).
No more fallback to createdBy.id, which caused
'You cannot record a vote for someone else' errors.
The Azure DevOps PUT /reviewers/{id} endpoint auto-adds the
user as a reviewer with the vote, so this works for PRs the
user created, was added to as a reviewer, or needs to be
added to. Function reduced from 34 lines to 9.
See CHANGELOG [0.4.3] for full details.1 parent 39e5d4d commit 21433f0
4 files changed
Lines changed: 23 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
8 | 24 | | |
9 | 25 | | |
10 | 26 | | |
| |||
488 | 504 | | |
489 | 505 | | |
490 | 506 | | |
491 | | - | |
492 | | - | |
| 507 | + | |
| 508 | + | |
493 | 509 | | |
494 | 510 | | |
495 | 511 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
708 | 708 | | |
709 | 709 | | |
710 | 710 | | |
711 | | - | |
| 711 | + | |
712 | 712 | | |
713 | 713 | | |
714 | 714 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
231 | | - | |
| 231 | + | |
232 | 232 | | |
233 | | - | |
| 233 | + | |
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
0 commit comments