style: resolve all credo issues from v0.3.0 additions

11 credo issues fixed across 5 files:

  * lib/ado_cli/cli/test_coverage.ex
    - Extracted print_coverage_stats/1 to reduce nesting (5->3)
      and cyclomatic complexity (10->5)
    - Collapsed two identical empty-coverage clauses into
      show_no_coverage/1

  * lib/ado_cli/cli/test_results.ex
    - Extracted print_run_row/1 from list_runs (cyclomatic 10->4,
      ABC 48->25)
    - Removed identity case in create_test_run (redirect passthrough)

  * lib/ado_cli/cli/pull_requests.ex
    - Extracted do_complete_patch/4 from complete_pr/1 (nesting 5->3,
      cyclomatic 10->5)
    - Replaced obvious comment in resolve_reviewer_id with inline docs

  * lib/ado_cli/cli/wikis.ex
    - Rephrased obvious comment (Fetch page -> Why ETag matters)

  * test/ado_cli/cli/test_results_test.exs
    - Reordered aliases alphabetically (TestCoverage before TestResults)

Verified: 819 mods/funs, 0 issues, 325 tests pass, compile clean.

Author: gilbertwong96

lib/ado_cli/cli/pull_requests.ex

@@ -443,22 +443,7 @@ defmodule AdoCli.CLI.PullRequests do
           last_commit_id ->
             body = build_complete_body(parsed, last_commit_id)
 
-            case Client.patch(path, body) do
-              {:ok, pr} ->
-                success("Pull request ##{pr["pullRequestId"]} completed (merged).\n")
-                halt_success("")
-
-              {:error, %{status: 404}} ->
-                halt_error("Pull request ##{pr_id} not found")
-
-              {:error, %{status: status, body: body}} ->
-                halt_error(
-                  "Cannot complete PR ##{pr_id}: #{inspect(body["message"] || "HTTP #{status}")}"
-                )
-
-              error ->
-                Helpers.handle_api_result(error, parsed, fn _ -> :ok end)
-            end
+            do_complete_patch(path, body, pr_id, parsed)
         end
 
       error ->
@@ -476,6 +461,26 @@ defmodule AdoCli.CLI.PullRequests do
     put_if_key(merge_strategy(Map.get(parsed.options, :merge_strategy)), body, "mergeStrategy")
   end
 
+  # Extracted from complete_pr/1 to reduce nesting depth.
+  defp do_complete_patch(path, body, pr_id, parsed) do
+    case Client.patch(path, body) do
+      {:ok, pr} ->
+        success("Pull request ##{pr["pullRequestId"]} completed (merged).\n")
+        halt_success("")
+
+      {:error, %{status: 404}} ->
+        halt_error("Pull request ##{pr_id} not found")
+
+      {:error, %{status: status, body: body}} ->
+        halt_error(
+          "Cannot complete PR ##{pr_id}: #{inspect(body["message"] || "HTTP #{status}")}"
+        )
+
+      error ->
+        Helpers.handle_api_result(error, parsed, fn _ -> :ok end)
+    end
+  end
+
   @doc """
   Approves a pull request (vote = +10).
   """
@@ -887,10 +892,6 @@ defmodule AdoCli.CLI.PullRequests do
   end
 
   defp resolve_reviewer_id(project, repo_id, pr_id) do
-    # Fetch the authenticated user's identity GUID from the
-    # Azure DevOps connection data (cached on first call).
-    # Then scan the PR reviewer list for a reviewer whose
-    # `identity.id` matches that GUID. Only the user's own
     # reviewer slot can be voted on — trying to PUT a vote
     # to a different reviewer's slot returns:
     #   "You cannot record a vote for someone else."

lib/ado_cli/cli/test_coverage.ex

@@ -57,47 +57,40 @@ defmodule AdoCli.CLI.TestCoverage do
           writeln("")
           writeln("Code Coverage for Build ##{build_id}")
           writeln(String.duplicate("─", 70))
-
-          Enum.each(covers, fn cov ->
-            config = cov["coverageStats"] || []
-
-            Enum.each(config, fn s ->
-              label = String.pad_trailing(s["label"] || "?", 20)
-              total = s["total"] || 0
-              covered = s["covered"] || 0
-
-              pct =
-                if total > 0,
-                  do: Float.round(covered / total * 100, 1),
-                  else: 0.0
-
-              bar = coverage_bar(pct)
-              writeln("  #{label} #{String.pad_leading("#{pct}%", 8)} #{bar}")
-            end)
-          end)
-
+          Enum.each(covers, &print_coverage_stats/1)
           writeln("")
         end)
 
         halt_success("Done.")
 
-      {:ok, %{"value" => []}} ->
-        writeln("")
-        writeln("No coverage data for build ##{build_id}.")
-        writeln("")
-        halt_success("Done.")
-
-      {:ok, _empty} ->
-        writeln("")
-        writeln("No coverage data for build ##{build_id}.")
-        writeln("")
-        halt_success("Done.")
+      {:ok, _empty_or_no_data} ->
+        show_no_coverage(build_id)
 
       error ->
         Helpers.handle_api_result(error, parsed, fn _ -> :ok end)
     end
   end
 
+  defp show_no_coverage(build_id) do
+    writeln("")
+    writeln("No coverage data for build ##{build_id}.")
+    writeln("")
+    halt_success("Done.")
+  end
+
+  defp print_coverage_stats(cov) do
+    config = cov["coverageStats"] || []
+
+    Enum.each(config, fn s ->
+      label = String.pad_trailing(s["label"] || "?", 20)
+      total = s["total"] || 0
+      covered = s["covered"] || 0
+      pct = if total > 0, do: Float.round(covered / total * 100, 1), else: 0.0
+      bar = coverage_bar(pct)
+      writeln("  #{label} #{String.pad_leading("#{pct}%", 8)} #{bar}")
+    end)
+  end
+
   defp coverage_bar(pct) do
     filled = round(pct / 5)
     empty = 20 - filled

lib/ado_cli/cli/test_results.ex

@@ -101,21 +101,7 @@ defmodule AdoCli.CLI.TestResults do
 
           writeln(String.duplicate("─", 90))
 
-          Enum.each(runs, fn run ->
-            id = to_string(run["id"] || "")
-            name = String.slice(run["name"] || "", 0, 39)
-            state = run["state"] || "?"
-
-            stats = run["runStatistics"] || []
-            total = find_stat(stats, "TotalTests") || "?"
-            passed = find_stat(stats, "Passed") || "0"
-            failed = find_stat(stats, "Failed") || "0"
-
-            writeln(
-              "#{String.pad_trailing(id, 8)} #{String.pad_trailing(name, 40)} " <>
-                "#{String.pad_trailing(state, 12)} #{total} / #{passed} / #{failed}"
-            )
-          end)
+          Enum.each(runs, &print_run_row/1)
 
           writeln("")
         end)
@@ -159,6 +145,22 @@ defmodule AdoCli.CLI.TestResults do
     stat && stat["count"]
   end
 
+  defp print_run_row(run) do
+    id = to_string(run["id"] || "")
+    name = String.slice(run["name"] || "", 0, 39)
+    state = run["state"] || "?"
+
+    stats = run["runStatistics"] || []
+    total = find_stat(stats, "TotalTests") || "?"
+    passed = find_stat(stats, "Passed") || "0"
+    failed = find_stat(stats, "Failed") || "0"
+
+    writeln(
+      "#{String.pad_trailing(id, 8)} #{String.pad_trailing(name, 40)} " <>
+        "#{String.pad_trailing(state, 12)} #{total} / #{passed} / #{failed}"
+    )
+  end
+
   # ── show ────────────────────────────────────────────────────────────
 
   def show_run(parsed) do
@@ -259,11 +261,7 @@ defmodule AdoCli.CLI.TestResults do
       end
 
     path = "/#{project}/_apis/test/runs"
-
-    case Client.post(path, body) do
-      {:ok, run} -> {:ok, run}
-      {:error, reason} -> {:error, reason}
-    end
+    Client.post(path, body)
   end
 
   defp attach_file(project, run_id, file_path, _content) do

lib/ado_cli/cli/wikis.ex

@@ -187,9 +187,8 @@ defmodule AdoCli.CLI.Wikis do
     path = Map.fetch!(parsed.options, :path)
     content = Map.fetch!(parsed.options, :content)
 
-    # Fetch the existing page to get its ETag for optimistic
-    # concurrency. The If-Match header prevents overwriting
-    # changes made by another user between our read and write.
+    # The If-Match header (ETag) prevents overwriting changes
+    # made by another user between our read and write.
     case Client.get("/#{URI.encode(project)}/_apis/wiki/wikis/#{URI.encode(wiki_id)}/pages", %{
            "path" => path,
            "includeContent" => "true"

test/ado_cli/cli/test_results_test.exs

@@ -1,7 +1,7 @@
 defmodule AdoCli.CLI.TestResultsTest do
   use AdoCli.CLI.TestHelper
-  alias AdoCli.CLI.TestResults
   alias AdoCli.CLI.TestCoverage
+  alias AdoCli.CLI.TestResults
 
   describe "test-results list" do
     test "halts 0 on success with runs", %{server: server} do