refactor: dedupe confirm_delete/2 + id/name/type table

mix ex_dna flagged two code clones in v0.2.1 (carried forward
from v0.2.0):

  1. confirm_delete/2 (projects.ex, repos.ex)
     An identical y/N prompt body. Extracted to
     AdoCli.CLI.Helpers.confirm_delete/2. The local
     defp wrappers were removed (reach flagged them as
     trivial forwarders); call sites now invoke the
     Helpers version directly.

  2. id/name/type table printer (connections.ex, wikis.ex)
     Identical Enum.each over a list of maps formatting
     id / name / type columns. Extracted to
     AdoCli.CLI.Helpers.print_id_name_type_table/1.

Both helpers were added to AdoCli.CLI.Helpers, which
gained 'import CliMate.CLI' so it can call write/1 and
halt_error/1.

Other changes:
  * mix.exs: add 'ex_dna' to the mix ci alias (8th quality
    step). mix ci now fails if ex_dna reports clones.
  * mix.lock: transitive dep bumps (json_codec 0.1.4 ->
    0.1.5, quackdb 0.5.12 -> 0.5.13).

Verified:
  * mix ex_dna -> 'No code duplication detected' (43 files)
  * mix ci -> 8/8 steps green (compile, format, credo,
    deps.unlock, deps.audit, xref, dialyzer, test --cover)
  * mix ex_dna added to mix ci
  * 313 tests pass (no regressions)
  * reach: trivial-forwarder warning gone

Author: gilbertwong96

lib/ado_cli/cli/connections.ex

@@ -81,11 +81,7 @@ defmodule AdoCli.CLI.Connections do
       writeln("#{String.pad_trailing("ID", 40)} #{String.pad_trailing("Name", 30)} Type")
       writeln(String.duplicate("─", 85))
 
-      Enum.each(conns, fn c ->
-        writeln(
-          "#{String.pad_trailing(c["id"] || "", 40)} #{String.pad_trailing(c["name"] || "", 30)} #{c["type"] || ""}"
-        )
-      end)
+      AdoCli.CLI.Helpers.print_id_name_type_table(conns)
 
       writeln("")
       writeln("#{length(conns)} connection(s)")

lib/ado_cli/cli/helpers.ex

@@ -10,6 +10,7 @@ defmodule AdoCli.CLI.Helpers do
   shape); otherwise it's human-readable formatted text.
   """
 
+  import CliMate.CLI
   alias AdoCli.CLI.Output
 
   @doc """
@@ -166,4 +167,63 @@ defmodule AdoCli.CLI.Helpers do
 
   defp network_error_classification(reason),
     do: {"network_error", "Request failed: #{inspect(reason, limit: 200)}"}
+
+  @doc """
+  Prompts the user to confirm a destructive action.
+
+  Prints `Delete {kind} '{id}'? This cannot be undone. [y/N] ` and
+  waits for input on stdin. Returns `:ok` if the user types `y` (or
+  `Y`); otherwise calls `halt_error/1` with "Aborted." and does not
+  return.
+
+  Used by the delete subcommands of `ado projects` and `ado repos`
+  (and any other command that needs a y/n confirmation before
+  destructive actions). Extracted from two near-identical copies
+  that ex_dna flagged as code clones.
+
+  Examples:
+
+      case confirm_delete("project", "MyProject") do
+        :ok -> Client.delete(...)
+      end
+  """
+  @spec confirm_delete(String.t(), String.t()) :: :ok | no_return()
+  def confirm_delete(kind, id) do
+    write("Delete #{kind} '#{id}'? This cannot be undone. [y/N] ")
+
+    if String.downcase(String.trim(IO.gets(""))) == "y" do
+      :ok
+    else
+      halt_error("Aborted.")
+    end
+  end
+
+  @doc """
+  Prints a 3-column table of `id / name / type` for a list of maps.
+
+  Each item in `rows` is expected to be a map (or struct) with
+  string fields `"id"`, `"name"`, and `"type"`. The column widths
+  (40 and 30) are fixed — chosen to match the existing
+  `ado connections list` and `ado wikis list` output styles. Missing
+  fields render as empty strings (not "nil").
+
+  Used by the `list` subcommands of `ado connections` and `ado wikis`
+  (extracted from two near-identical copies that ex_dna flagged as
+  code clones).
+
+  Example:
+
+      rows = [%{"id" => "abc", "name" => "My Connection", "type" => "github"}]
+      print_id_name_type_table(rows)
+  """
+  @spec print_id_name_type_table([map()]) :: :ok
+  def print_id_name_type_table(rows) do
+    Enum.each(rows, fn row ->
+      writeln(
+        "#{String.pad_trailing(row["id"] || "", 40)} " <>
+          "#{String.pad_trailing(row["name"] || "", 30)} " <>
+          "#{row["type"] || ""}"
+      )
+    end)
+  end
 end

lib/ado_cli/cli/projects.ex

@@ -196,7 +196,7 @@ defmodule AdoCli.CLI.Projects do
     project_id = parsed.arguments.project_id
 
     unless Map.get(parsed.options, :force) do
-      confirm_delete("project", project_id)
+      AdoCli.CLI.Helpers.confirm_delete("project", project_id)
     end
 
     case Client.delete("/_apis/projects/#{URI.encode(project_id)}") do
@@ -232,16 +232,6 @@ defmodule AdoCli.CLI.Projects do
   defp process_template_id("cmmi"), do: "27450541-8e31-4150-9947-dc59f998fc01"
   defp process_template_id(unknown), do: unknown
 
-  defp confirm_delete(kind, id) do
-    write("Delete #{kind} '#{id}'? This cannot be undone. [y/N] ")
-
-    if String.downcase(String.trim(IO.gets(""))) == "y" do
-      :ok
-    else
-      halt_error("Aborted.")
-    end
-  end
-
   # ── Formatting ────────────────────────────────────────────────────────
 
   defp print_projects_table(projects) do

lib/ado_cli/cli/repos.ex

@@ -199,7 +199,7 @@ defmodule AdoCli.CLI.Repos do
     repo_id = parsed.arguments.repo_id
 
     unless Map.get(parsed.options, :force) do
-      confirm_delete("repository", "#{project}/#{repo_id}")
+      AdoCli.CLI.Helpers.confirm_delete("repository", "#{project}/#{repo_id}")
     end
 
     case Client.delete("/#{URI.encode(project)}/_apis/git/repositories/#{URI.encode(repo_id)}") do
@@ -217,16 +217,6 @@ defmodule AdoCli.CLI.Repos do
 
   # ── Helpers ───────────────────────────────────────────────────────────
 
-  defp confirm_delete(kind, id) do
-    write("Delete #{kind} '#{id}'? This cannot be undone. [y/N] ")
-
-    if String.downcase(String.trim(IO.gets(""))) == "y" do
-      :ok
-    else
-      halt_error("Aborted.")
-    end
-  end
-
   # ── Formatting ────────────────────────────────────────────────────────
 
   defp print_repos_table(repos) do

lib/ado_cli/cli/wikis.ex

@@ -222,11 +222,7 @@ defmodule AdoCli.CLI.Wikis do
       writeln("#{String.pad_trailing("ID", 40)} #{String.pad_trailing("Name", 30)} Type")
       writeln(String.duplicate("─", 85))
 
-      Enum.each(wikis, fn w ->
-        writeln(
-          "#{String.pad_trailing(w["id"] || "", 40)} #{String.pad_trailing(w["name"] || "", 30)} #{w["type"] || ""}"
-        )
-      end)
+      AdoCli.CLI.Helpers.print_id_name_type_table(wikis)
 
       writeln("")
       writeln("#{length(wikis)} wiki(s)")

mix.exs

@@ -155,7 +155,8 @@ defmodule AdoCli.MixProject do
         "deps.audit",
         "xref graph --label compile-connected --fail-above 0",
         "ci.dialyzer",
-        "test --cover"
+        "test --cover",
+        "ex_dna"
       ],
       quality: [
         "compile --all-warnings --warnings-as-errors",

mix.lock

@@ -22,7 +22,7 @@
   "finch": {:hex, :finch, "0.22.0", "5c48fa6f9706a78eb9036cacb67b8b996b4e66d111c543f4c29bb0f879a6806b", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.8", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 1.1", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "b94e83c47780fc6813f746a1f1a34ee65cda42da4c5ea26a68f0acc4498e23dc"},
   "hpax": {:hex, :hpax, "1.0.3", "ed67ef51ad4df91e75cc6a1494f851850c0bd98ebc0be6e81b026e765ee535aa", [:mix], [], "hexpm", "8eab6e1cfa8d5918c2ce4ba43588e894af35dbd8e91e6e55c817bca5847df34a"},
   "jason": {:hex, :jason, "1.4.5", "2e3a008590b0b8d7388c20293e9dcc9cf3e5d642fd2a114e4cbbb52e595d940a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0 or ~> 3.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "b0c823996102bcd0239b3c2444eb00409b72f6a140c1950bc8b457d836b30684"},
-  "json_codec": {:hex, :json_codec, "0.1.4", "bb1d0b74dcd4c9daa8a3d5a3e12aeda5ea2db8659a261b1b291302f8a5d7d159", [:mix], [{:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "3bc1f8d44857a579de01f2bb7a625de43ffebad1534309ab419dab610fe3c876"},
+  "json_codec": {:hex, :json_codec, "0.1.5", "44532ea8604f3587d0e8b0b33002745ba068c9cb1663d73c1eee49a5e7cd7e78", [:mix], [{:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "6631dd3ce56a567e57ccb7a1129f57bb9206663fbb644c6ee47acdba36933f73"},
   "libgraph": {:hex, :libgraph, "0.16.0", "3936f3eca6ef826e08880230f806bfea13193e49bf153f93edcf0239d4fd1d07", [:mix], [], "hexpm", "41ca92240e8a4138c30a7e06466acc709b0cbb795c643e9e17174a178982d6bf"},
   "makeup": {:hex, :makeup, "1.2.1", "e90ac1c65589ef354378def3ba19d401e739ee7ee06fb47f94c687016e3713d1", [:mix], [{:nimble_parsec, "~> 1.4", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "d36484867b0bae0fea568d10131197a4c2e47056a6fbe84922bf6ba71c8d17ce"},
   "makeup_elixir": {:hex, :makeup_elixir, "1.0.1", "e928a4f984e795e41e3abd27bfc09f51db16ab8ba1aebdba2b3a575437efafc2", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "7284900d412a3e5cfd97fdaed4f5ed389b8f2b4cb49efc0eb3bd10e2febf9507"},
@@ -37,7 +37,7 @@
   "pi_bridge": {:hex, :pi_bridge, "0.6.21", "f1a63da5f49fef4f6b35e98edd5400cbd64a49fb8bda84be41b7e91f3deb0b89", [:mix], [{:bandit, "~> 1.8", [hex: :bandit, repo: "hexpm", optional: false]}, {:dune, "~> 0.3", [hex: :dune, repo: "hexpm", optional: true]}, {:ecto_sql, "~> 3.13", [hex: :ecto_sql, repo: "hexpm", optional: false]}, {:ex_ast, "~> 0.12", [hex: :ex_ast, repo: "hexpm", optional: false]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}, {:json_codec, "~> 0.1.3", [hex: :json_codec, repo: "hexpm", optional: false]}, {:plug, "~> 1.18", [hex: :plug, repo: "hexpm", optional: false]}, {:quackdb, "~> 0.5.4", [hex: :quackdb, repo: "hexpm", optional: false]}, {:reach, "~> 2.6", [hex: :reach, repo: "hexpm", optional: false]}, {:req, "~> 0.5", [hex: :req, repo: "hexpm", optional: false]}, {:req_llm, "~> 1.6", [hex: :req_llm, repo: "hexpm", optional: true]}], "hexpm", "b226fb60965a8e928186af3c3b96fe8f0fefd8c6cc7be679d6e169ba84105de9"},
   "plug": {:hex, :plug, "1.19.2", "e4950525b22c6789dfb38a3f95d47171ba159da3fc5a33be9643b43d5e8adb98", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "b6fce20a56af5e60fa5dfecf3f907bb98ec981be43c79a3809a499bc3d133de0"},
   "plug_crypto": {:hex, :plug_crypto, "2.1.1", "19bda8184399cb24afa10be734f84a16ea0a2bc65054e23a62bb10f06bc89491", [:mix], [], "hexpm", "6470bce6ffe41c8bd497612ffde1a7e4af67f36a15eea5f921af71cf3e11247c"},
-  "quackdb": {:hex, :quackdb, "0.5.12", "461f3997c4b8f5640a3a128e8e49875e0b7c6f74d1a26aa6f59c9fc142d5ed34", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: false]}, {:db_connection, "~> 2.7", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 2.0 or ~> 3.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:ecto_sql, "~> 3.13", [hex: :ecto_sql, repo: "hexpm", optional: true]}, {:explorer, "~> 0.11", [hex: :explorer, repo: "hexpm", optional: true]}, {:fsst, "~> 0.1.2", [hex: :fsst, repo: "hexpm", optional: true]}, {:geo, "~> 4.1", [hex: :geo, repo: "hexpm", optional: true]}, {:mint, "~> 1.8", [hex: :mint, repo: "hexpm", optional: false]}, {:muontrap, "~> 1.5", [hex: :muontrap, repo: "hexpm", optional: false]}, {:table, "~> 0.1", [hex: :table, repo: "hexpm", optional: true]}, {:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:varint, "~> 1.6", [hex: :varint, repo: "hexpm", optional: false]}], "hexpm", "a9fb12190c465bb6ec76132829e3bd4eae4d60318d097c84070c28a41115e1bf"},
+  "quackdb": {:hex, :quackdb, "0.5.13", "854294a5a85e0f2972d2229da8dfb25afd2cda500e80e477f6987bff823c2b21", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: false]}, {:db_connection, "~> 2.7", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 2.0 or ~> 3.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:ecto_sql, "~> 3.13", [hex: :ecto_sql, repo: "hexpm", optional: true]}, {:explorer, "~> 0.11", [hex: :explorer, repo: "hexpm", optional: true]}, {:fsst, "~> 0.1.2", [hex: :fsst, repo: "hexpm", optional: true]}, {:geo, "~> 4.1", [hex: :geo, repo: "hexpm", optional: true]}, {:mint, "~> 1.8", [hex: :mint, repo: "hexpm", optional: false]}, {:muontrap, "~> 1.5", [hex: :muontrap, repo: "hexpm", optional: false]}, {:table, "~> 0.1", [hex: :table, repo: "hexpm", optional: true]}, {:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:varint, "~> 1.6", [hex: :varint, repo: "hexpm", optional: false]}], "hexpm", "a5d18e54de682bde9f4ab1866126aa90c26223866bc693bf56cdf9dafa3859d3"},
   "reach": {:hex, :reach, "2.7.5", "2148096233ebf84f1b9c79d23134c3262f546303af07ee21f7e9d7ed281ff616", [:mix], [{:boxart, "~> 0.3.3", [hex: :boxart, repo: "hexpm", optional: true]}, {:ex_ast, "~> 0.12.0", [hex: :ex_ast, repo: "hexpm", optional: false]}, {:ex_dna, "~> 1.5", [hex: :ex_dna, repo: "hexpm", optional: true]}, {:libgraph, "~> 0.16.0", [hex: :libgraph, repo: "hexpm", optional: false]}, {:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: true]}, {:makeup_js, "~> 0.1", [hex: :makeup_js, repo: "hexpm", optional: true]}, {:quickbeam, "~> 0.10", [hex: :quickbeam, repo: "hexpm", optional: true]}], "hexpm", "b31fd7cf23a649a6f76f11168b2ef296845441d6498474634ec673dee2d60567"},
   "req": {:hex, :req, "0.6.1", "7b904c8b42d0e08136a5c6aba024fd12fc79a1ed8856e7a3522b0917f7e75113", [:mix], [{:brotli, "~> 0.3.1", [hex: :brotli, repo: "hexpm", optional: true]}, {:ezstd, "~> 1.0", [hex: :ezstd, repo: "hexpm", optional: true]}, {:finch, "~> 0.21.0 or ~> 0.22.0", [hex: :finch, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}, {:mime, "~> 2.0.6 or ~> 2.1", [hex: :mime, repo: "hexpm", optional: false]}, {:nimble_csv, "~> 1.0", [hex: :nimble_csv, repo: "hexpm", optional: true]}, {:plug, "~> 1.0", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "aaf11c9c80f2df2364630b3594e1857fe610d8ea7cb994e1ce3dcb55f204ff1c"},
   "sourceror": {:hex, :sourceror, "1.12.0", "da354c5f35aad3cc1132f5d5b0d8437d865e2661c263260480bab51b5eedb437", [:mix], [], "hexpm", "755703683bd014ebcd5de9acc24b68fb874a660a568d1d63f8f98cd8a6ef9cd0"},