refactor: fix reach dead-code and smell findings

- Remove unused String.slice short-sha vars in format_unified_diff
- Remove unused attachment_type case in attach_file
- Drop redundant nil default in Map.get/3 calls
- Replace Map.keys |> length with map_size/1
- Replace guard == :ok comparison with pattern-matched clauses
- Remove redundant params assignment before return
- Use iolist for WIQL string building

Author: gilbertwong96

lib/ado_cli/cli/pipelines.ex

@@ -1112,7 +1112,7 @@ defmodule AdoCli.CLI.Pipelines do
       writeln(String.duplicate("─", 100))
 
       Enum.each(groups, fn g ->
-        var_count = g["variables"] |> Map.keys() |> length()
+        var_count = map_size(g["variables"])
 
         desc = String.slice(g["description"] || "", 0, 38)
 

lib/ado_cli/cli/pull_requests.ex

@@ -1110,11 +1110,8 @@ defmodule AdoCli.CLI.PullRequests do
     end
   end
 
-  defp format_unified_diff(path, old_content, new_content, base_sha, target_sha) do
-    # Ensure path has a leading "/" for consistency
+  defp format_unified_diff(path, old_content, new_content, _base_sha, _target_sha) do
     path = if String.starts_with?(path, "/"), do: path, else: "/#{path}"
-    _short_base = String.slice(base_sha, 0, 7)
-    _short_target = String.slice(target_sha, 0, 7)
 
     header = """
     diff --git a#{path} b#{path}
@@ -1940,20 +1937,23 @@ defmodule AdoCli.CLI.PullRequests do
   defp do_delete_request(:delete, path), do: Client.delete(path)
   defp do_delete_request(:patch, path), do: Client.patch(path, %{"status" => "closed"})
 
-  defp render_delete_result(result, target_label, json?, parsed) do
-    case result do
-      r when r == :ok or (is_tuple(r) and elem(r, 0) == :ok) ->
-        if json? do
-          IO.puts(JSON.encode!(%{ok: true, closed: target_label}))
-        else
-          success("Closed #{target_label}.")
-        end
+  defp render_delete_result(:ok, target_label, json?, _parsed),
+    do: render_delete_ok(target_label, json?)
 
-        halt_success("")
+  defp render_delete_result({:ok, _}, target_label, json?, _parsed),
+    do: render_delete_ok(target_label, json?)
 
-      {:error, reason} ->
-        Helpers.bail(reason, parsed)
+  defp render_delete_result({:error, reason}, _target_label, _json?, parsed),
+    do: Helpers.bail(reason, parsed)
+
+  defp render_delete_ok(target_label, json?) do
+    if json? do
+      IO.puts(JSON.encode!(%{ok: true, closed: target_label}))
+    else
+      success("Closed #{target_label}.")
     end
+
+    halt_success("")
   end
 
   @doc """

lib/ado_cli/cli/test_results.ex

@@ -133,27 +133,24 @@ defmodule AdoCli.CLI.TestResults do
     params = %{}
 
     params =
-      if top = Map.get(parsed.options, :top, nil) do
+      if top = Map.get(parsed.options, :top) do
         Map.put(params, "$top", top)
       else
         params
       end
 
     params =
-      if build_id = Map.get(parsed.options, :"build-id", nil) do
+      if build_id = Map.get(parsed.options, :"build-id") do
         Map.put(params, "buildIds", build_id)
       else
         params
       end
 
-    params =
-      if min_date = Map.get(parsed.options, :"min-last-updated", nil) do
-        Map.put(params, "minLastUpdatedDate", min_date)
-      else
-        params
-      end
-
-    params
+    if min_date = Map.get(parsed.options, :"min-last-updated") do
+      Map.put(params, "minLastUpdatedDate", min_date)
+    else
+      params
+    end
   end
 
   defp find_stat(stats, label) do
@@ -270,7 +267,7 @@ defmodule AdoCli.CLI.TestResults do
     }
 
     body =
-      if build_id = Map.get(parsed.options, :"build-id", nil) do
+      if build_id = Map.get(parsed.options, :"build-id") do
         Map.put(body, "build", %{"id" => build_id})
       else
         body
@@ -281,20 +278,6 @@ defmodule AdoCli.CLI.TestResults do
   end
 
   defp attach_file(project, run_id, file_path, _content) do
-    # Determine attachment type from file extension
-    ext =
-      file_path
-      |> String.downcase()
-      |> Path.extname()
-
-    _attachment_type =
-      case ext do
-        ".xml" -> "CodeCoverage"
-        ".cobertura" -> "CodeCoverage"
-        ".trx" -> "TmiTestRunSummaryResult"
-        _ -> "GeneralAttachment"
-      end
-
     # Mark the run as completed
     _ = Client.patch("/#{project}/_apis/test/runs/#{run_id}", %{"state" => "Completed"})
 

lib/ado_cli/cli/work_items.ex

@@ -271,10 +271,14 @@ defmodule AdoCli.CLI.WorkItems do
       |> add_wiql_filter(Map.get(parsed.options, :state), "System.State")
 
     wiql =
-      "SELECT [System.Id], [System.Title], [System.State], [System.WorkItemType], [System.AssignedTo] " <>
-        "FROM WorkItems " <>
-        "WHERE #{Enum.join(where_clauses, " AND ")} " <>
+      IO.iodata_to_binary([
+        "SELECT [System.Id], [System.Title], [System.State], [System.WorkItemType], [System.AssignedTo] ",
+        "FROM WorkItems ",
+        "WHERE ",
+        Enum.join(where_clauses, " AND "),
+        " ",
         "ORDER BY [System.Id] DESC"
+      ])
 
     run_wiql_query(project, wiql, parsed)
   end