Skip to content

Commit 84d46df

Browse files
committed
fix: correct package name (excoveralls) + use branch ref for burrito
Two CI-blocking issues discovered when validating the new GitHub Actions workflow locally: 1. **ex_coveralls -> excoveralls**: the package on hex.pm is spelled 'excoveralls' (no underscore). The 404 from hex.pm meant the dep couldn't be fetched, so the GitHub Actions workflow would have failed at the 'mix deps.get' step on the runner. 2. **burrito ref -> branch**: the SHA 'ef2ff340...' is on the 'zig-0.16.0' branch but mix deps.get does a shallow fetch that doesn't follow branch refs by default. Using 'branch: zig-0.16.0' makes mix follow the branch tip directly. Validated locally: - mix deps.get fetches all 30+ deps cleanly - mix test -> 107 passed - mix test --cover -> 93.52% (threshold enforced) - mix coveralls.json -> cover/excoveralls.json (294KB) - mix ci -> exit 0 (Credo strict, Dialyzer, xref, format, audit)
1 parent bdd6122 commit 84d46df

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

mix.exs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ defmodule AdoCli.MixProject do
6565
threshold: 90
6666
],
6767
coveralls: [
68-
# Mirror the test_coverage ignore list so ex_coveralls reports the
68+
# Mirror the test_coverage ignore list so excoveralls reports the
6969
# same modules and threshold. Used by `mix coveralls` and the
7070
# `mix coveralls.html` workflow.
7171
ignore_modules: [
@@ -123,16 +123,13 @@ defmodule AdoCli.MixProject do
123123
[
124124
{:finch, "~> 0.22.0"},
125125
{:cli_mate, "~> 0.10.2"},
126-
{:burrito,
127-
github: "gilbertwong96/burrito",
128-
ref: "ef2ff340fbd2b4b71b8dd0953177504074bba8ba",
129-
runtime: false},
126+
{:burrito, github: "gilbertwong96/burrito", branch: "zig-0.16.0", runtime: false},
130127
{:credo, "~> 1.7", only: [:dev, :test], runtime: false},
131128
{:ex_dna, "~> 1.5", only: [:dev, :test], runtime: false},
132129
{:ex_slop, "~> 0.4.2", only: [:dev, :test], runtime: false},
133130
{:reach, "~> 2.7", only: [:dev, :test], runtime: false},
134131
{:mix_audit, "~> 2.1", only: [:dev, :test], runtime: false},
135-
{:ex_coveralls, "~> 0.18", only: [:dev, :test], runtime: false},
132+
{:excoveralls, "~> 0.18", only: [:dev, :test], runtime: false},
136133
{:dialyxir, "~> 1.4", only: [:dev, :test], runtime: false},
137134
{:ex_doc, "~> 0.40", only: :dev, runtime: false},
138135
{:pi_bridge, "~> 0.6.5", only: [:dev, :test], runtime: false},

mix.lock

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
%{
22
"bandit": {:hex, :bandit, "1.12.0", "6c5214daa2469644ac4ab0113b98abc24f75e348378e6a974c6343b3e5da22ef", [:mix], [{:hpax, "~> 1.0", [hex: :hpax, repo: "hexpm", optional: false]}, {:plug, "~> 1.18", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:thousand_island, "~> 1.5", [hex: :thousand_island, repo: "hexpm", optional: false]}, {:websock, "~> 0.5", [hex: :websock, repo: "hexpm", optional: false]}], "hexpm", "45dac82dc86f45cf4a196dee9cc5a8b791d9c9469d996055f055e6ee36c66e20"},
33
"bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
4-
"burrito": {:git, "https://github.com/gilbertwong96/burrito.git", "ef2ff340fbd2b4b71b8dd0953177504074bba8ba", [ref: "ef2ff340fbd2b4b71b8dd0953177504074bba8ba"]},
4+
"burrito": {:git, "https://github.com/gilbertwong96/burrito.git", "1ac8e20587ad9a4b0bea05227e0ce16a74f101e6", [branch: "zig-0.16.0"]},
55
"castore": {:hex, :castore, "1.0.19", "6903cabdfd9d1af46454126e7c8385186659dd33ecfb74a885cae52221ad6109", [:mix], [], "hexpm", "3669e6cab13f54c2df26b3e6833745d647f35b6e30d8ddd5975df0d5c842ca98"},
66
"cli_mate": {:hex, :cli_mate, "0.10.2", "ddde446045cd6bb442daf77f0eb23836b66d8e4fc469cd0e09c7ccbe9036b72f", [:mix], [], "hexpm", "8b9f6c3e1ac240ac0f18fa3ad033dd5cabc4061c7234b1bdca35536dccc09af5"},
77
"credo": {:hex, :credo, "1.7.19", "cc52129665fc7c15143d47838fda0f9cd6dac9ceced7bf4da6f85fcbfe64b12a", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "2d8bc95d5a7bb99dd2613621d4f08c6a3575c3fd4b62e6a2b48a100352a557b8"},
@@ -17,6 +17,7 @@
1717
"ex_dna": {:hex, :ex_dna, "1.5.3", "c4c4736c1e22538002844f194fbd2b942f3a0c2a3517c843306b219f27bc5525", [:mix], [{:credo, "~> 1.7", [hex: :credo, repo: "hexpm", optional: true]}, {:gen_lsp, "~> 0.11", [hex: :gen_lsp, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}, {:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: true]}], "hexpm", "28196153994e99aae29a955ee9f1d37ea6d3a33dbac0896ac4b937ebc622c313"},
1818
"ex_doc": {:hex, :ex_doc, "0.40.3", "4a972ffe64bc07dc605af487e98fc19b72a4185f55ca031b94c0552d6071c1d9", [:mix], [{:earmark_parser, "~> 1.4.44", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "2756e357742fecd9749b489b85d67c9ce99c465f2e75728d9e6dc8d704b973de"},
1919
"ex_slop": {:hex, :ex_slop, "0.4.2", "142aba9a82eddfb258e39c45d59392ab3cdb6b5a3ad401b09b362b7134fc54eb", [:mix], [{:credo, "~> 1.7", [hex: :credo, repo: "hexpm", optional: false]}], "hexpm", "c7f5316f755f83566e7a0a049f6fedfcd5ff916fce83c6ebfdf806be62fd7a69"},
20+
"excoveralls": {:hex, :excoveralls, "0.18.5", "e229d0a65982613332ec30f07940038fe451a2e5b29bce2a5022165f0c9b157e", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "523fe8a15603f86d64852aab2abe8ddbd78e68579c8525ae765facc5eae01562"},
2021
"file_system": {:hex, :file_system, "1.1.1", "31864f4685b0148f25bd3fbef2b1228457c0c89024ad67f7a81a3ffbc0bbad3a", [:mix], [], "hexpm", "7a15ff97dfe526aeefb090a7a9d3d03aa907e100e262a0f8f7746b78f8f87a5d"},
2122
"finch": {:hex, :finch, "0.22.0", "5c48fa6f9706a78eb9036cacb67b8b996b4e66d111c543f4c29bb0f879a6806b", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.8", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 1.1", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "b94e83c47780fc6813f746a1f1a34ee65cda42da4c5ea26a68f0acc4498e23dc"},
2223
"hpax": {:hex, :hpax, "1.0.3", "ed67ef51ad4df91e75cc6a1494f851850c0bd98ebc0be6e81b026e765ee535aa", [:mix], [], "hexpm", "8eab6e1cfa8d5918c2ce4ba43588e894af35dbd8e91e6e55c817bca5847df34a"},

0 commit comments

Comments
 (0)