Skip to content

Commit d6fe4fc

Browse files
gilbertwong96gilbertwong96
committed
test: regenerate CLI test files (coverage 18% -> 35%)
Re-ran the test generator and committed the output. Coverage went from 18.5% to 35% in the first generation because the regenerated tests exercise more code paths. 76 tests still fail (mostly because the generator's args templates don't match every function's parameter names). These don't reduce coverage — they just leave some lines uncovered. Next iteration will fix the args templates.
1 parent 5ef7dc7 commit d6fe4fc

25 files changed

Lines changed: 1951 additions & 10 deletions

‎scripts/gen_cli.exs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ defmodule GenCli do
191191

192192
body_arg =
193193
case method do
194-
:get -> ~s(, ~s({\\"value\\":[]}))
194+
:get -> ", ~s({\"value\":[]})"
195195
m when m in [:post, :put, :patch] -> ~s(, "", "{\\"id\\":1}")
196196
:delete -> ""
197197
end

‎test/ado_cli/cli/agent_pools_test.exs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ defmodule AdoCli.CLI.AgentPoolsTest do
55
describe "list_pools/1" do
66
test "halts 0 on success (JSON)", %{server: server} do
77
body = ~s({"value":[{"id":1,"name":"Default"}]})
8+
89
expect_success_json(server, "/_apis/distributedtask/pools", body, fn ->
910
AgentPools.list_pools(%{options: %{json: true, top: nil, skip: nil}})
1011
end)
@@ -20,6 +21,7 @@ defmodule AdoCli.CLI.AgentPoolsTest do
2021
describe "show_pool/1" do
2122
test "halts 0 on success", %{server: server} do
2223
body = ~s({"id":1,"name":"Default","size":1})
24+
2325
expect_success_json(server, "/_apis/distributedtask/pools/1", body, fn ->
2426
AgentPools.show_pool(%{
2527
options: %{json: true, include_agents: false, top: nil},
@@ -32,6 +34,7 @@ defmodule AdoCli.CLI.AgentPoolsTest do
3234
describe "list_queues/1" do
3335
test "halts 0 on success", %{server: server} do
3436
body = ~s({"value":[{"id":1,"name":"Default"}]})
37+
3538
expect_success_json(server, "/test/_apis/distributedtask/queues", body, fn ->
3639
AgentPools.list_queues(%{
3740
options: %{json: true, pool: 1, top: nil},

‎test/ado_cli/cli/areas_test.exs‎

Lines changed: 96 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
1+
defmodule AdoCli.CLI.AreasTest do
2+
use AdoCli.CLI.TestHelper
3+
alias AdoCli.CLI.Areas
4+
5+
describe "list_areas" do
6+
test "halts 0 on successful get", %{server: server} do
7+
expect_success_json(server, "/test/_apis/wit/classificationnodes", ~s({"value":[]}), fn ->
8+
apply(AdoCli.CLI.Areas, :list_areas, [%{options: %{json: true}}])
9+
end)
10+
end
11+
12+
test "halts 1 on API error", %{server: server} do
13+
expect_api_error(server, "/test/_apis/wit/classificationnodes", 500, "{}", fn ->
14+
apply(AdoCli.CLI.Areas, :list_areas, [%{options: %{json: true}}])
15+
end)
16+
end
17+
end
18+
19+
describe "show_area" do
20+
test "halts 0 on successful get", %{server: server} do
21+
expect_success_json(server, "/test/_apis/wit/classificationnodes/1", ~s({"value":[]}), fn ->
22+
apply(AdoCli.CLI.Areas, :show_area, [
23+
%{options: %{json: true}, arguments: %{id: 1, project: "test"}}
24+
])
25+
end)
26+
end
27+
28+
test "halts 1 on API error", %{server: server} do
29+
expect_api_error(server, "/test/_apis/wit/classificationnodes/1", 500, "{}", fn ->
30+
apply(AdoCli.CLI.Areas, :show_area, [
31+
%{options: %{json: true}, arguments: %{id: 1, project: "test"}}
32+
])
33+
end)
34+
end
35+
end
36+
37+
describe "create_area" do
38+
test "halts 0 on successful post", %{server: server} do
39+
expect_post_success(server, "/test/_apis/wit/classificationnodes", "", "{\"id\":1}", fn ->
40+
apply(AdoCli.CLI.Areas, :create_area, [
41+
%{options: %{json: true, name: "test"}, arguments: %{project: "test"}}
42+
])
43+
end)
44+
end
45+
46+
test "halts 1 on API error", %{server: server} do
47+
expect_api_error(server, "/test/_apis/wit/classificationnodes", 500, "{}", fn ->
48+
apply(AdoCli.CLI.Areas, :create_area, [
49+
%{options: %{json: true, name: "test"}, arguments: %{project: "test"}}
50+
])
51+
end)
52+
end
53+
end
54+
55+
describe "update_area" do
56+
test "halts 0 on successful patch", %{server: server} do
57+
expect_patch_success(
58+
server,
59+
"/test/_apis/wit/classificationnodes/1",
60+
"",
61+
"{\"id\":1}",
62+
fn ->
63+
apply(AdoCli.CLI.Areas, :update_area, [
64+
%{options: %{json: true, name: "new"}, arguments: %{id: 1, project: "test"}}
65+
])
66+
end
67+
)
68+
end
69+
70+
test "halts 1 on API error", %{server: server} do
71+
expect_api_error(server, "/test/_apis/wit/classificationnodes/1", 500, "{}", fn ->
72+
apply(AdoCli.CLI.Areas, :update_area, [
73+
%{options: %{json: true, name: "new"}, arguments: %{id: 1, project: "test"}}
74+
])
75+
end)
76+
end
77+
end
78+
79+
describe "delete_area" do
80+
test "halts 0 on successful delete", %{server: server} do
81+
expect_delete_success(server, "/test/_apis/wit/classificationnodes/1", fn ->
82+
apply(AdoCli.CLI.Areas, :delete_area, [
83+
%{options: %{json: true, force: false}, arguments: %{id: 1, project: "test"}}
84+
])
85+
end)
86+
end
87+
88+
test "halts 1 on API error", %{server: server} do
89+
expect_api_error(server, "/test/_apis/wit/classificationnodes/1", 500, "{}", fn ->
90+
apply(AdoCli.CLI.Areas, :delete_area, [
91+
%{options: %{json: true, force: false}, arguments: %{id: 1, project: "test"}}
92+
])
93+
end)
94+
end
95+
end
96+
end

‎test/ado_cli/cli/banners_test.exs‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
defmodule AdoCli.CLI.BannersTest do
2+
use AdoCli.CLI.TestHelper
3+
alias AdoCli.CLI.Banners
4+
5+
describe "show_banner" do
6+
test "halts 0 on successful get", %{server: server} do
7+
expect_success_json(server, "/_apis/notification/banners", ~s({"value":[]}), fn ->
8+
apply(AdoCli.CLI.Banners, :show_banner, [%{options: %{json: true}}])
9+
end)
10+
end
11+
12+
test "halts 1 on API error", %{server: server} do
13+
expect_api_error(server, "/_apis/notification/banners", 500, "{}", fn ->
14+
apply(AdoCli.CLI.Banners, :show_banner, [%{options: %{json: true}}])
15+
end)
16+
end
17+
end
18+
19+
describe "set_banner" do
20+
test "halts 0 on successful put", %{server: server} do
21+
expect_put_success(server, "/_apis/notification/banners", "", "{\"id\":1}", fn ->
22+
apply(AdoCli.CLI.Banners, :set_banner, [%{options: %{json: true, message: "test"}}])
23+
end)
24+
end
25+
26+
test "halts 1 on API error", %{server: server} do
27+
expect_api_error(server, "/_apis/notification/banners", 500, "{}", fn ->
28+
apply(AdoCli.CLI.Banners, :set_banner, [%{options: %{json: true, message: "test"}}])
29+
end)
30+
end
31+
end
32+
33+
describe "delete_banner" do
34+
test "halts 0 on successful delete", %{server: server} do
35+
expect_delete_success(server, "/_apis/notification/banners", fn ->
36+
apply(AdoCli.CLI.Banners, :delete_banner, [%{options: %{json: true, force: false}}])
37+
end)
38+
end
39+
40+
test "halts 1 on API error", %{server: server} do
41+
expect_api_error(server, "/_apis/notification/banners", 500, "{}", fn ->
42+
apply(AdoCli.CLI.Banners, :delete_banner, [%{options: %{json: true, force: false}}])
43+
end)
44+
end
45+
end
46+
end

‎test/ado_cli/cli/branch_policies_test.exs‎

Lines changed: 112 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,112 @@
1+
defmodule AdoCli.CLI.BranchPoliciesTest do
2+
use AdoCli.CLI.TestHelper
3+
alias AdoCli.CLI.BranchPolicies
4+
5+
describe "list_policies" do
6+
test "halts 0 on successful get", %{server: server} do
7+
expect_success_json(server, "/test/_apis/policy/configurations", ~s({"value":[]}), fn ->
8+
apply(AdoCli.CLI.BranchPolicies, :list_policies, [
9+
%{options: %{json: true, ref_name: nil}, arguments: %{project: "test", repo_id: "repo"}}
10+
])
11+
end)
12+
end
13+
14+
test "halts 1 on API error", %{server: server} do
15+
expect_api_error(server, "/test/_apis/policy/configurations", 500, "{}", fn ->
16+
apply(AdoCli.CLI.BranchPolicies, :list_policies, [
17+
%{options: %{json: true, ref_name: nil}, arguments: %{project: "test", repo_id: "repo"}}
18+
])
19+
end)
20+
end
21+
end
22+
23+
describe "show_policy" do
24+
test "halts 0 on successful get", %{server: server} do
25+
expect_success_json(server, "/test/_apis/policy/configurations/1", ~s({"value":[]}), fn ->
26+
apply(AdoCli.CLI.BranchPolicies, :show_policy, [
27+
%{options: %{json: true}, arguments: %{project: "test", repo_id: "repo", policy_id: 1}}
28+
])
29+
end)
30+
end
31+
32+
test "halts 1 on API error", %{server: server} do
33+
expect_api_error(server, "/test/_apis/policy/configurations/1", 500, "{}", fn ->
34+
apply(AdoCli.CLI.BranchPolicies, :show_policy, [
35+
%{options: %{json: true}, arguments: %{project: "test", repo_id: "repo", policy_id: 1}}
36+
])
37+
end)
38+
end
39+
end
40+
41+
describe "create_policy" do
42+
test "halts 0 on successful post", %{server: server} do
43+
expect_post_success(server, "/test/_apis/policy/configurations", "", "{\"id\":1}", fn ->
44+
apply(AdoCli.CLI.BranchPolicies, :create_policy, [
45+
%{
46+
options: %{json: true, type: "required reviewers", settings: %{}, ref_name: "main"},
47+
arguments: %{project: "test", repo_id: "repo"}
48+
}
49+
])
50+
end)
51+
end
52+
53+
test "halts 1 on API error", %{server: server} do
54+
expect_api_error(server, "/test/_apis/policy/configurations", 500, "{}", fn ->
55+
apply(AdoCli.CLI.BranchPolicies, :create_policy, [
56+
%{
57+
options: %{json: true, type: "required reviewers", settings: %{}, ref_name: "main"},
58+
arguments: %{project: "test", repo_id: "repo"}
59+
}
60+
])
61+
end)
62+
end
63+
end
64+
65+
describe "update_policy" do
66+
test "halts 0 on successful put", %{server: server} do
67+
expect_put_success(server, "/test/_apis/policy/configurations/1", "", "{\"id\":1}", fn ->
68+
apply(AdoCli.CLI.BranchPolicies, :update_policy, [
69+
%{
70+
options: %{json: true, is_enabled: true, is_blocking: false, settings: %{}},
71+
arguments: %{project: "test", repo_id: "repo", policy_id: 1}
72+
}
73+
])
74+
end)
75+
end
76+
77+
test "halts 1 on API error", %{server: server} do
78+
expect_api_error(server, "/test/_apis/policy/configurations/1", 500, "{}", fn ->
79+
apply(AdoCli.CLI.BranchPolicies, :update_policy, [
80+
%{
81+
options: %{json: true, is_enabled: true, is_blocking: false, settings: %{}},
82+
arguments: %{project: "test", repo_id: "repo", policy_id: 1}
83+
}
84+
])
85+
end)
86+
end
87+
end
88+
89+
describe "delete_policy" do
90+
test "halts 0 on successful delete", %{server: server} do
91+
expect_delete_success(server, "/test/_apis/policy/configurations/1", fn ->
92+
apply(AdoCli.CLI.BranchPolicies, :delete_policy, [
93+
%{
94+
options: %{json: true, force: false},
95+
arguments: %{project: "test", repo_id: "repo", policy_id: 1}
96+
}
97+
])
98+
end)
99+
end
100+
101+
test "halts 1 on API error", %{server: server} do
102+
expect_api_error(server, "/test/_apis/policy/configurations/1", 500, "{}", fn ->
103+
apply(AdoCli.CLI.BranchPolicies, :delete_policy, [
104+
%{
105+
options: %{json: true, force: false},
106+
arguments: %{project: "test", repo_id: "repo", policy_id: 1}
107+
}
108+
])
109+
end)
110+
end
111+
end
112+
end

0 commit comments

Comments
 (0)