ci: drop --keychain-password from notarytool submit too

The earlier fix removed --keychain-password from
notarytool store-credentials, but it was still on the
notarytool submit invocation. Same error:

  Error: Unknown option '--keychain-password'

In notarytool 1.1.2, --keychain-password is not a valid
flag for either command. The keychain is already
unlocked (set-keychain-settings -lut 21600 keeps it
unlocked for 6 hours after the import step's
unlock-keychain call), so the keychain is accessible
without re-supplying the password.

Fix: drop --keychain-password from the submit call.
Verified locally that xcrun notarytool 1.1.2 (41) on
this Mac accepts --keychain and --keychain-profile
but not --keychain-password for submit.

Author: gilbertwong96

.github/workflows/ci.yml

@@ -446,11 +446,14 @@ jobs:
             --team-id "$MACOS_NOTARY_TEAM_ID" \
             --password "$MACOS_NOTARY_PASSWORD" \
             --keychain "$MACOS_KEYCHAIN_PATH"
+          # The submit command in this version of notarytool doesn't
+          # accept --keychain-password either. The keychain stays
+          # unlocked for 6 hours (set by set-keychain-settings -lut 21600
+          # in the import step), so it's still accessible here.
           echo "Submitting for notarization (profile: $MACOS_KEYCHAIN_PROFILE)"
           xcrun notarytool submit "$BINARY" \
             --keychain-profile "$MACOS_KEYCHAIN_PROFILE" \
             --keychain "$MACOS_KEYCHAIN_PATH" \
-            --keychain-password "$MACOS_KEYCHAIN_PASSWORD" \
             --wait
           echo "Stapling notarization ticket"
           xcrun stapler staple "$BINARY"