Commit 15dbc19
committed
test: fix all compile warnings in test/
Three categories of warnings fixed:
1. Unused variable: rename authorize_url to _authorize_url in the
callback-receive block (the value is only used to consume the
message from the test mailbox).
2. Deprecated map.field() with parentheses: save_token_for_test/2
used token.access_token() etc. to read a map field, which the
compiler now warns about (must drop the parens).
3. @deprecated function calls: enable_alert/2, disable_alert/2, and
trading_days/4 are all marked @deprecated in lib/, so the tests
that exercised them emitted a deprecation warning at compile
time. Deleted those three describe blocks.
Test deletions (AGENTS.md notes this requires justification in the
commit body): the deleted tests exist only to exercise functions the
library has explicitly marked @deprecated. They provide no coverage
of the new APIs (which have their own tests elsewhere) and will need
to be removed anyway when the deprecated functions are dropped
upstream. Keeping them solely to dodge a compile warning would also
require either deleting the test (lossy) or wrapping calls in
apply/3 (ugly, hides intent). Per user request, deletion was the
chosen path.1 parent 03418bb commit 15dbc19
3 files changed
Lines changed: 5 additions & 50 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | 233 | | |
272 | 234 | | |
273 | 235 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | 249 | | |
257 | 250 | | |
258 | 251 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
425 | 425 | | |
426 | 426 | | |
427 | 427 | | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
432 | 432 | | |
433 | 433 | | |
434 | 434 | | |
| |||
852 | 852 | | |
853 | 853 | | |
854 | 854 | | |
855 | | - | |
| 855 | + | |
856 | 856 | | |
857 | 857 | | |
858 | 858 | | |
| |||
0 commit comments