Merge pull request #260 from jamman99/main

Improve HTTP error status. Close #259

Author: gilcrest

errs/httperrors.go

@@ -262,8 +262,12 @@ func unknownErrorResponse(w http.ResponseWriter, lgr zerolog.Logger, err error)
 // httpErrorStatusCode maps an error Kind to an HTTP Status Code
 func httpErrorStatusCode(k Kind) int {
 	switch k {
-	case Invalid, Exist, NotExist, Private, BrokenLink, Validation, InvalidRequest:
+	case Invalid, Private, BrokenLink, Validation, InvalidRequest:
 		return http.StatusBadRequest
+	case NotExist:
+		return http.StatusNotFound
+	case Exist:
+		return http.StatusConflict
 	case UnsupportedMediaType:
 		return http.StatusUnsupportedMediaType
 	// the zero value of Kind is Other, so if no Kind is present

errs/httperrors_test.go

@@ -23,8 +23,8 @@ func Test_httpErrorStatusCode(t *testing.T) {
 		args args
 		want int
 	}{
-		{"Exist", args{k: Exist}, http.StatusBadRequest},
-		{"NotExist", args{k: NotExist}, http.StatusBadRequest},
+		{"Exist", args{k: Exist}, http.StatusConflict},
+		{"NotExist", args{k: NotExist}, http.StatusNotFound},
 		{"Invalid", args{k: Invalid}, http.StatusBadRequest},
 		{"Private", args{k: Private}, http.StatusBadRequest},
 		{"BrokenLink", args{k: BrokenLink}, http.StatusBadRequest},