fix: workers start/stop on update

Author: gilmar-sales

CMakeLists.txt

@@ -27,7 +27,7 @@ if (FREYR_PROFILING)
     add_subdirectory(vendor/perfetto)
 endif (FREYR_PROFILING)
 
-project(freyr LANGUAGES C CXX VERSION 0.20.14)
+project(freyr LANGUAGES C CXX VERSION 0.20.15)
 
 if (FREYR_BUILD_EXAMPLES)
     add_subdirectory(examples)

include/Freyr/Core/TaskManager.hpp

@@ -45,11 +45,8 @@ namespace FREYR_NAMESPACE
 
         void StartWorkers();
         void StopWorkers();
-        void WaitForAllTasks()
-        {
-            mTaskCounter->waitForCompletion();
-            StopWorkers();
-        }
+
+        void WaitForAllTasks() { mTaskCounter->waitForCompletion(); }
 
         void NotifyWorker() { mCondition.notify_one(); }
 

src/Core/Scene.cpp

@@ -116,6 +116,7 @@ namespace FREYR_NAMESPACE
 
 #endif // FREYR_PROFILING
         FREYR_PROFILING_BEGIN("FREYR", "Frame", perfetto::Track(0), "TotalEntities", mEntityManager->LivingEntities());
+        mTaskManager->StartWorkers();
 
         const auto provider = mServiceProvider.lock()->CreateServiceScope()->GetServiceProvider();
 
@@ -126,21 +127,18 @@ namespace FREYR_NAMESPACE
         while (mFixedDeltaTimeAccumulator >= mOptions->FixedDeltaTime && steps < maxSteps)
         {
             FREYR_PROFILING_BEGIN("FREYR", "PreFixedUpdate", perfetto::Track(0));
-            mTaskManager->StartWorkers();
             mSystemManager->PreFixedUpdate(mOptions->FixedDeltaTime, provider);
             mTaskManager->WaitForAllTasks();
             DestroyEntities();
             FREYR_PROFILING_END("FREYR", perfetto::Track(0));
 
             FREYR_PROFILING_BEGIN("FREYR", "FixedUpdate", perfetto::Track(0));
-            mTaskManager->StartWorkers();
             mSystemManager->FixedUpdate(mOptions->FixedDeltaTime, provider);
             mTaskManager->WaitForAllTasks();
             DestroyEntities();
             FREYR_PROFILING_END("FREYR", perfetto::Track(0));
 
             FREYR_PROFILING_BEGIN("FREYR", "PostFixedUpdate", perfetto::Track(0));
-            mTaskManager->StartWorkers();
             mSystemManager->PostFixedUpdate(mOptions->FixedDeltaTime, provider);
             mTaskManager->WaitForAllTasks();
             DestroyEntities();
@@ -157,27 +155,25 @@ namespace FREYR_NAMESPACE
 
         FREYR_PROFILING_BEGIN("FREYR", "PreUpdate", perfetto::Track(0), "TotalEntities",
                               mEntityManager->LivingEntities());
-        mTaskManager->StartWorkers();
         mSystemManager->PreUpdate(deltaTime, provider);
         mTaskManager->WaitForAllTasks();
         DestroyEntities();
         FREYR_PROFILING_END("FREYR", perfetto::Track(0));
 
         FREYR_PROFILING_BEGIN("FREYR", "Update", perfetto::Track(0));
-        mTaskManager->StartWorkers();
         mSystemManager->Update(deltaTime, provider);
         mTaskManager->WaitForAllTasks();
         DestroyEntities();
         FREYR_PROFILING_END("FREYR", perfetto::Track(0));
 
         FREYR_PROFILING_BEGIN("FREYR", "PostUpdate", perfetto::Track(0));
-        mTaskManager->StartWorkers();
         mSystemManager->PostUpdate(deltaTime, provider);
         mTaskManager->WaitForAllTasks();
         DestroyEntities();
         FREYR_PROFILING_END("FREYR", perfetto::Track(0));
 
         FREYR_PROFILING_END("FREYR", perfetto::Track(0));
+        mTaskManager->StopWorkers();
     }
 
     void Scene::DestroyEntities()

src/Core/TaskManager.cpp

@@ -100,8 +100,8 @@ namespace FREYR_NAMESPACE
             if (mState.load() == State::Idle)
                 return;
 
-            auto idle = State::Running;
-            if (mState.compare_exchange_strong(idle, State::Idle))
+            auto running = State::Running;
+            if (mState.compare_exchange_strong(running, State::Idle))
                 return;
         }
     }
@@ -152,7 +152,7 @@ namespace FREYR_NAMESPACE
                     break;
             }
 
-            const State currentState = mState.load(std::memory_order_acquire);
+            const auto currentState = mState.load(std::memory_order_acquire);
 
             if (currentState == State::Resizing)
                 return;