Skip to content

Commit 132ffd2

Browse files
committed
make created factories const
1 parent 2eff163 commit 132ffd2

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

core/stop/iteration.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors
1+
// SPDX-FileCopyrightText: 2017 - 2026 The Ginkgo authors
22
//
33
// SPDX-License-Identifier: BSD-3-Clause
44

@@ -24,13 +24,13 @@ bool Iteration::check_impl(uint8 stoppingId, bool setFinalized,
2424
}
2525

2626

27-
deferred_factory_parameter<Iteration::Factory> max_iters(size_type count)
27+
deferred_factory_parameter<const Iteration::Factory> max_iters(size_type count)
2828
{
2929
return Iteration::build().with_max_iters(count);
3030
}
3131

3232

33-
deferred_factory_parameter<CriterionFactory> min_iters(
33+
deferred_factory_parameter<const CriterionFactory> min_iters(
3434
size_type count, deferred_factory_parameter<CriterionFactory> criterion)
3535
{
3636
return MinIterationWrapper::build()

include/ginkgo/core/stop/iteration.hpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class Iteration : public EnablePolymorphicObject<Iteration, Criterion> {
8080
* @return a deferred_factory_parameter that can be passed to the
8181
* `with_criteria` function when building a solver.
8282
*/
83-
deferred_factory_parameter<Iteration::Factory> max_iters(size_type count);
83+
deferred_factory_parameter<const Iteration::Factory> max_iters(size_type count);
8484

8585

8686
/**
@@ -108,23 +108,23 @@ deferred_factory_parameter<Iteration::Factory> max_iters(size_type count);
108108
* @return a deferred_factory_parameter that can be passed to the
109109
* `with_criteria` function when building a solver.
110110
*/
111-
deferred_factory_parameter<CriterionFactory> min_iters(
111+
deferred_factory_parameter<const CriterionFactory> min_iters(
112112
size_type count, deferred_factory_parameter<CriterionFactory> criterion);
113113

114114

115115
/**
116-
* @copydoc min_iters(size_type, deferred_factory_parameter<CriterionFactory>)
117-
* This version supports supplying multiple stopping criteria independently, all
118-
* of which will only be checked after the minimum iteration count has been
119-
* exceeded.
116+
* @copydoc min_iters(size_type, deferred_factory_parameter<const
117+
* CriterionFactory>) This version supports supplying multiple stopping criteria
118+
* independently, all of which will only be checked after the minimum iteration
119+
* count has been exceeded.
120120
*/
121121
template <typename... Args>
122122
std::enable_if_t<sizeof...(Args) >= 2,
123-
deferred_factory_parameter<CriterionFactory>>
123+
deferred_factory_parameter<const CriterionFactory>>
124124
min_iters(size_type count, Args&&... criteria)
125125
{
126-
std::vector<deferred_factory_parameter<CriterionFactory>> criterion_vec{
127-
std::forward<Args>(criteria)...};
126+
std::vector<deferred_factory_parameter<const CriterionFactory>>
127+
criterion_vec{std::forward<Args>(criteria)...};
128128
return min_iters(count, Combined::build().with_criteria(criterion_vec));
129129
};
130130

0 commit comments

Comments
 (0)