Skip to content

Commit 2b7c086

Browse files
yhmtsaiMarcelKoch
andcommitted
remove the unused traits and add documentation
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
1 parent 71e45e6 commit 2b7c086

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

include/ginkgo/core/base/type_traits.hpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,6 @@ template <typename Type>
3434
using factory_type = typename factory_type_impl<Type>::type;
3535

3636

37-
template <typename Type>
38-
struct get_solver_type_impl {
39-
using type = std::conditional_t<is_ginkgo_linop<Type>, Type, LinOp>;
40-
};
41-
42-
template <typename Type>
43-
using get_solver_type = typename get_solver_type_impl<Type>::type;
44-
45-
4637
// helper for handle the transposed type of concrete type and LinOp
4738
template <typename Type>
4839
struct transposed_type_impl {

include/ginkgo/core/preconditioner/ic.hpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,11 @@ class Ic : public EnableLinOp<Ic<LSolverTypeOrValueType, IndexType>>,
148148
return with_l_solver(std::move(solver));
149149
}
150150

151+
/**
152+
* When LSolverTypeOrValueType is a concrete solver type, this only
153+
* accepts the factory from the same concrete solver type. When
154+
* LSolverTypeOrValueType is a value type, it accepts any LinOpFactory.
155+
*/
151156
parameters_type& with_l_solver(
152157
deferred_factory_parameter<
153158
const gko::detail::factory_type<l_solver_type>>

0 commit comments

Comments
 (0)