bump the gtest version requirement and rearrange comments in build

Author: yhmtsai

.gitlab/build.yml

@@ -1,4 +1,3 @@
-# cuda 11.4 and friends
 build/cuda110/nompi/gcc/cuda/release/shared:
   extends:
     - .build_and_test_template
@@ -11,8 +10,6 @@ build/cuda110/nompi/gcc/cuda/release/shared:
     BUILD_MPI: "OFF"
     BUILD_TYPE: "Release"
     FAST_TESTS: "ON"
-    # fix gtest issue https://github.com/google/googletest/issues/3514
-    CXX_FLAGS: "-Wno-error=maybe-uninitialized"
     # disable spurious unused argument warning
     # this is seemingly broken with CUDA 11
     # EXTRA_CMAKE_FLAGS: "-DCMAKE_CUDA_FLAGS=-diag-suppress=177"
@@ -30,10 +27,10 @@ build/nvhpc227/cuda117/nompi/nvcpp/debug/shared:
     BUILD_MPI: "OFF"
     BUILD_TYPE: "Debug"
     FAST_TESTS: "ON"
-    # disable common gflags warnings
     CXX_FLAGS: "--diag_suppress=useless_using_declaration,declared_but_not_referenced"
-    # disable spurious unused argument warning
     EXTRA_CMAKE_FLAGS: "-DCMAKE_CUDA_FLAGS=-diag-suppress=177"
+  # `--diag_suppress=useless_using_declaration,declared_but_not_referenced` disables common gflags warning
+  # `-diag-suppress=188` disables spurious unused argument warning in CUDA
 
 build/cuda118/nompi/gcc/cuda/debug/shared:
   extends:
@@ -148,7 +145,6 @@ build/amd/openmpi/gcc/rocm620/debug/shared:
     BUILD_SHARED_LIBS: "ON"
     MODULE_LOAD: "cmake/3.24.4 rocm/6.2.0 gcc/13.3.0 openmpi/5.0.7"
 
-# rocm 6.3.x is the last version support MI50 officially
 build/amd/openmpi/gcc/rocm634_wo_omp/release/shared:
   extends:
     - .build_and_test_tum_template
@@ -161,8 +157,8 @@ build/amd/openmpi/gcc/rocm634_wo_omp/release/shared:
     BUILD_MPI: "ON"
     BUILD_TYPE: "Release"
     MODULE_LOAD: "cmake/3.29.6 rocm/6.3.4 gcc/13.3.0 openmpi/5.0.7"
+  # MI50 is officially supported by ROCm < 6.4.0
 
-# mi50 is not officially supported by ROCm >= 6.4.0
 build/amd/nompi/gcc/rocm644/debug/static:
   extends:
     - .build_and_test_tum_template
@@ -177,6 +173,7 @@ build/amd/nompi/gcc/rocm644/debug/static:
     BUILD_TYPE: "Debug"
     BUILD_SHARED_LIBS: "OFF"
     MODULE_LOAD: "cmake/3.29.6 rocm/6.4.4 gcc/14.3.0"
+  # MI50 is not officially supported by ROCm >= 6.4.0
 
 build/amd/nompi/gcc/rocm710/release/shared:
   extends:
@@ -207,7 +204,6 @@ build/amd/nompi/gcc/rocm720/release/shared:
     ENABLE_HALF: "OFF"
     MODULE_LOAD: "cmake/3.25.3 rocm/7.2.0 gcc/12.4.0"
 
-# no cuda but latest gcc and clang
 build/nocuda/nompi/gcc/core/debug/static:
   extends:
     - .build_and_test_template
@@ -271,10 +267,9 @@ build/nocuda/openmpi/clang/omp/glibcxx-debug-release/shared:
     MPI_AS_ROOT: "ON"
     BUILD_MPI: "ON"
     CXX_FLAGS: "-Wpedantic -D_GLIBCXX_DEBUG=1"
-    # The tests are prohibitively slow in Debug
     BUILD_TYPE: "Release"
+  # We use Release here bacause glibcxx tests are prohibitively slow in Debug
 
-# nocuda with old compiler
 build/nocuda/nompi/gcc/omp/release/static:
   extends:
     - .build_and_test_template
@@ -390,7 +385,6 @@ build/nogpu/mpi/gcc13/noomp/release/shared:
     BUILD_MPI: "ON"
     MODULE_LOAD: "cmake/3.18.6 gcc/13.3.0 openmpi"
 
-# spack oneapi 2023.1
 build/icpx20231/gpu/release/shared:
   extends:
     - .build_and_test_template
@@ -459,7 +453,6 @@ build/icpx202421/gpu/release/shared:
     ONEAPI_DEVICE_SELECTOR: "level_zero:gpu"
     MODULE_LOAD: "cmake/3.28.6 intel-oneapi-compilers/2024.2.1 intel-oneapi-dpl/2022.6.1 intel-oneapi-tbb/2021.13.1 intel-oneapi-mkl/2024.2.1"
 
-# It gives two available backends of GPU on tests
 build/dpcpp/gpu/release/shared:
   extends:
     - .build_and_test_template
@@ -471,8 +464,8 @@ build/dpcpp/gpu/release/shared:
     CXX_FLAGS: "-Wpedantic -ffp-model=precise"
     BUILD_SYCL: "ON"
     BUILD_TYPE: "Release"
-    # static builds take too long
     BUILD_SHARED_LIBS: "ON"
     DPCPP_SINGLE_MODE: "ON"
     ONEAPI_DEVICE_SELECTOR: "*:gpu"
     BUILD_HWLOC: "OFF"
+  # This gives two available backends of GPU on tests

CMakeLists.txt

@@ -443,7 +443,7 @@ endif()
 
 # Try to find the third party packages before using our subdirectories
 if(GINKGO_BUILD_TESTS)
-    find_package(GTest 1.10.0) # No need for QUIET as CMake ships FindGTest
+    find_package(GTest 1.12.0) # No need for QUIET as CMake ships FindGTest
 endif()
 if(GINKGO_BUILD_BENCHMARKS)
     find_package(gflags 2.2.2 QUIET)