reference also has sparselib implementation

Co-authored-by: Tobias Ribizel <mail@ribizel.de>
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>

Author: 3 people

core/factorization/ic.cpp

@@ -102,9 +102,10 @@ std::unique_ptr<Composition<ValueType>> Ic<ValueType, IndexType>::generate(
         local_system_matrix.get(), false));
 
     std::shared_ptr<const matrix_type> ic;
-    // Compute LC factorization
+    // Compute IC factorization
     if (parameters_.algorithm == incomplete_algorithm::syncfree ||
-        exec == exec->get_master()) {
+        (!std::dynamic_pointer_cast<const ReferenceExecutor>(exec) &&
+         exec == exec->get_master())) {
         std::unique_ptr<gko::factorization::elimination_forest<IndexType>>
             forest;
         const auto nnz = local_system_matrix->get_num_stored_elements();

core/factorization/ilu.cpp

@@ -98,9 +98,10 @@ std::unique_ptr<Composition<ValueType>> Ilu<ValueType, IndexType>::generate_l_u(
         local_system_matrix.get(), false));
 
     std::shared_ptr<const matrix_type> ilu;
-    // Compute LU factorization
+    // Compute ILU factorization
     if (parameters_.algorithm == incomplete_algorithm::syncfree ||
-        exec == exec->get_master()) {
+        (!std::dynamic_pointer_cast<const ReferenceExecutor>(exec) &&
+         exec == exec->get_master())) {
         const auto nnz = local_system_matrix->get_num_stored_elements();
         const auto num_rows = local_system_matrix->get_size()[0];
         auto factors = share(

include/ginkgo/core/factorization/ic.hpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors
+// SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors
 //
 // SPDX-License-Identifier: BSD-3-Clause
 
@@ -103,10 +103,10 @@ class Ic : public Composition<ValueType> {
 
         /**
          * Select the implementation which is supposed to be used for
-         * the incomplete factorization. This only matters for the CUDA and HIP
-         * executor where the choice is between the Ginkgo (syncfree) and the
-         * cuSPARSE/hipSPARSE/reference (sparselib) implementation. Default is
-         * sparselib.
+         * the incomplete factorization. This only matters for the
+         * CUDA/HIP/REFERENCE executor where the choice is between the Ginkgo
+         * (syncfree) and the cuSPARSE/hipSPARSE/reference (sparselib)
+         * implementation. Default is sparselib.
          */
         incomplete_algorithm GKO_FACTORY_PARAMETER_SCALAR(
             algorithm, incomplete_algorithm::sparselib);

include/ginkgo/core/factorization/ilu.hpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors
+// SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors
 //
 // SPDX-License-Identifier: BSD-3-Clause
 
@@ -98,10 +98,10 @@ class Ilu : public Composition<ValueType> {
 
         /**
          * Select the implementation which is supposed to be used for
-         * the incomplete factorization. This only matters for the CUDA and HIP
-         * executor where the choice is between the Ginkgo (syncfree) and the
-         * cuSPARSE/hipSPARSE/reference (sparselib) implementation. Default is
-         * sparselib.
+         * the incomplete factorization. This only matters for the
+         * CUDA/HIP/REFERENCE executor where the choice is between the Ginkgo
+         * (syncfree) and the cuSPARSE/hipSPARSE/reference (sparselib)
+         * implementation. Default is sparselib.
          */
         incomplete_algorithm GKO_FACTORY_PARAMETER_SCALAR(
             algorithm, incomplete_algorithm::sparselib);