try to fix sparse stack tests

Author: cflint

core/test/sketch/sparse_stack.cpp

@@ -38,7 +38,6 @@ TYPED_TEST_SUITE(SparseStackCore, gko::test::ValueIndexTypes,
 
 TYPED_TEST(SparseStackCore, ReturnsCorrectSketchSize)
 {
-    // Added zeta = 1
     auto sketch = TestFixture::Sketch::create(this->exec, 7, 20, 1, 42);
 
     EXPECT_EQ(sketch->get_sketch_size(), 7);
@@ -47,7 +46,6 @@ TYPED_TEST(SparseStackCore, ReturnsCorrectSketchSize)
 
 TYPED_TEST(SparseStackCore, ReturnsCorrectInputSize)
 {
-    // Added zeta = 1
     auto sketch = TestFixture::Sketch::create(this->exec, 7, 20, 1, 42);
 
     EXPECT_EQ(sketch->get_input_size(), 20);
@@ -56,7 +54,6 @@ TYPED_TEST(SparseStackCore, ReturnsCorrectInputSize)
 
 TYPED_TEST(SparseStackCore, ReturnsCorrectSeed)
 {
-    // Added zeta = 1
     auto sketch = TestFixture::Sketch::create(this->exec, 7, 20, 1, 123);
 
     EXPECT_EQ(sketch->get_seed(), 123);
@@ -65,7 +62,6 @@ TYPED_TEST(SparseStackCore, ReturnsCorrectSeed)
 
 TYPED_TEST(SparseStackCore, HashMapHasCorrectSize)
 {
-    // zeta = 4
     auto sketch = TestFixture::Sketch::create(this->exec, 7, 20, 4, 42);
 
     EXPECT_EQ(sketch->get_hash_map().get_size(), 80); 
@@ -75,7 +71,6 @@ TYPED_TEST(SparseStackCore, HashMapHasCorrectSize)
 
 TYPED_TEST(SparseStackCore, SignsHasCorrectSize)
 {
-    // Added zeta = 4
     auto sketch = TestFixture::Sketch::create(this->exec, 7, 20, 4, 42);
 
     EXPECT_EQ(sketch->get_signs().get_size(), 80);
@@ -85,7 +80,7 @@ TYPED_TEST(SparseStackCore, SignsHasCorrectSize)
 TYPED_TEST(SparseStackCore, ApplyThrowsOnDimensionMismatch)
 {
     using Dense = typename TestFixture::Dense;
-    // Added zeta = 1
+
     auto sketch = TestFixture::Sketch::create(this->exec, 3, 5, 1, 42);
     // b has wrong number of rows (4 instead of 5)
     auto b = Dense::create(this->exec, gko::dim<2>{4, 3});
@@ -98,7 +93,7 @@ TYPED_TEST(SparseStackCore, ApplyThrowsOnDimensionMismatch)
 TYPED_TEST(SparseStackCore, ApplyThrowsOnOutputDimensionMismatch)
 {
     using Dense = typename TestFixture::Dense;
-    // Added zeta = 1
+
     auto sketch = TestFixture::Sketch::create(this->exec, 3, 5, 1, 42);
     auto b = Dense::create(this->exec, gko::dim<2>{5, 3});
     // x has wrong number of rows (4 instead of 3)
@@ -111,7 +106,7 @@ TYPED_TEST(SparseStackCore, ApplyThrowsOnOutputDimensionMismatch)
 TYPED_TEST(SparseStackCore, ApplyThrowsOnColumnMismatch)
 {
     using Dense = typename TestFixture::Dense;
-    // Added zeta = 1
+
     auto sketch = TestFixture::Sketch::create(this->exec, 3, 5, 1, 42);
     auto b = Dense::create(this->exec, gko::dim<2>{5, 3});
     // x has wrong number of columns (2 instead of 3)
@@ -124,7 +119,7 @@ TYPED_TEST(SparseStackCore, ApplyThrowsOnColumnMismatch)
 TYPED_TEST(SparseStackCore, RapplyThrowsOnDimensionMismatch)
 {
     using Dense = typename TestFixture::Dense;
-    // Added zeta = 1
+
     auto sketch = TestFixture::Sketch::create(this->exec, 3, 5, 1, 42);
     // rapply: b must have cols == 5 (input_size), this has 4
     auto b = Dense::create(this->exec, gko::dim<2>{4, 4});
@@ -137,8 +132,8 @@ TYPED_TEST(SparseStackCore, RapplyThrowsOnDimensionMismatch)
 TYPED_TEST(SparseStackCore, RapplyThrowsOnOutputColumnMismatch)
 {
     using Dense = typename TestFixture::Dense;
-    // Added zeta = 1
-    auto sketch = TestFixture::Sketch::create(this->exec, 3, 5, 1, 42);
+
+    auto sketch = TestFixture::Sketch::create(this->exec, 3, 5, 4, 42);
     auto b = Dense::create(this->exec, gko::dim<2>{4, 5});
     // x must have cols == 3 (sketch_size), this has 4
     auto x = Dense::create(this->exec, gko::dim<2>{4, 4});
@@ -149,11 +144,13 @@ TYPED_TEST(SparseStackCore, RapplyThrowsOnOutputColumnMismatch)
 TYPED_TEST(SparseStackCore, RapplyThrowsOnRowMismatch)
 {
     using Dense = typename TestFixture::Dense;
-    // Added zeta = 1
-    auto sketch = TestFixture::Sketch::create(this->exec, 3, 5, 1, 42);
+
+    // S is 3x5
+    auto sketch = TestFixture::Sketch::create(this->exec, 3, 5, 4, 42);
+    // b has 4 rows
     auto b = Dense::create(this->exec, gko::dim<2>{4, 5});
-    // x must have rows == 3 (sketch_size), this has 4
-    auto x = Dense::create(this->exec, gko::dim<2>{4, 3});
+    // Error: x has 5 rows instead of 3
+    auto x = Dense::create(this->exec, gko::dim<2>{5, 3});
 
     ASSERT_THROW(sketch->rapply(b, x), gko::DimensionMismatch);
 }