feat: return b64encoded token after successful login

Align the implementation to @approvio/api v0.0.18

Author: giovannibaratta

app/controllers/src/auth/auth.controller.ts

@@ -1,4 +1,15 @@
-import {Controller, Get, Post, Res, Logger, UnauthorizedException, Query, Body, HttpCode} from "@nestjs/common"
+import {
+  Controller,
+  Get,
+  Post,
+  Res,
+  Logger,
+  UnauthorizedException,
+  Query,
+  Body,
+  HttpCode,
+  BadRequestException
+} from "@nestjs/common"
 import {Response} from "express"
 import {AuthService, GenerateChallengeRequest} from "@services"
 import {isLeft} from "fp-ts/lib/Either"
@@ -8,12 +19,12 @@ import {GetAuthenticatedEntity} from "../../../main/src/auth"
 import {
   TokenRequest,
   TokenResponse,
-  AuthMessageResponse,
+  SuccessfulAuthResponse,
+  FailedAuthResponse,
   AgentChallengeRequest,
   AgentChallengeResponse,
   AgentTokenResponse
 } from "@approvio/api"
-
 import {
   mapAgentChallengeRequestToService,
   mapChallengeToApiResponse,
@@ -25,6 +36,7 @@ import {
 } from "./agent-auth.mappers"
 import {pipe} from "fp-ts/lib/function"
 import {AuthenticatedEntity} from "@domain"
+import {generateErrorPayload} from "@controllers/error"
 
 /**
  * ┌─────────────────────────────────────────────────────────────────────────────────────────┐
@@ -155,13 +167,20 @@ export class AuthController {
 
   @PublicRoute()
   @Get("success")
-  async success(): Promise<AuthMessageResponse> {
-    return {message: "Authentication successful. Use the code and state to generate a JWT token."}
+  async success(@Query("code") code: string, @Query("state") state: string): Promise<SuccessfulAuthResponse> {
+    if (!code) throw new BadRequestException(generateErrorPayload("MISSING_CODE", "missing code"))
+    if (!state) throw new BadRequestException(generateErrorPayload("MISSING_STATE", "missing state"))
+    return {
+      message: "Authentication successful. Use the code and state to generate a JWT token.",
+      code: code,
+      state: state,
+      b64encoded: Buffer.from(`${code}:${state}`, "utf-8").toString("base64")
+    }
   }
 
   @PublicRoute()
   @Get("error")
-  async error(): Promise<AuthMessageResponse> {
+  async error(): Promise<FailedAuthResponse> {
     return {message: "Authentication failed. Please try again."}
   }
 

app/main/test/integration/auth/auth.integration.test.ts

@@ -7,6 +7,7 @@ import {cleanDatabase, prepareDatabase} from "@test/database"
 import {ConfigProvider} from "@external/config"
 import {MockConfigProvider} from "@test/mock-data"
 import {PrismaClient} from "@prisma/client"
+import "expect-more-jest"
 
 describe("Auth Integration", () => {
   let app: INestApplication
@@ -76,11 +77,14 @@ describe("Auth Integration", () => {
 
   describe("GET /auth/success", () => {
     it("should return success message for stateless flow", async () => {
-      const response = await request(app.getHttpServer()).get("/auth/success")
+      const response = await request(app.getHttpServer()).get("/auth/success?code=123&state=456")
 
       expect(response).toHaveStatusCode(200)
-      expect(response.body).toEqual({
-        message: "Authentication successful. Use the code and state to generate a JWT token."
+      expect(response.body).toMatchObject({
+        message: "Authentication successful. Use the code and state to generate a JWT token.",
+        code: expect.toBeString(),
+        state: expect.toBeString(),
+        b64encoded: expect.toBeString()
       })
     })
   })

package.json

@@ -32,7 +32,7 @@
   },
   "packageManager": "yarn@4.7.0",
   "dependencies": {
-    "@approvio/api": "0.0.17",
+    "@approvio/api": "0.0.18",
     "@nestjs/bull": "11.0.4",
     "@nestjs/common": "11.1.9",
     "@nestjs/core": "11.1.9",
@@ -80,7 +80,7 @@
     "expect-more-jest": "5.5.0",
     "ioredis": "5.8.2",
     "jest": "29.7.0",
-    "node-loader": "^2.1.0",
+    "node-loader": "2.1.0",
     "prettier": "3.7.4",
     "pretty-format": "30.2.0",
     "prisma": "7.2.0",

yarn.lock

@@ -100,18 +100,18 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@approvio/api@npm:0.0.17":
-  version: 0.0.17
-  resolution: "@approvio/api@npm:0.0.17"
-  checksum: 10/67eb3bf7f79c68437a30c88db9ecd77f9753209dfc9d86a6e7e7541ad16bda78788e2dba49fac2c8cb115690f1828fb995f2ee3bf495d187f7b3606bd21f9a41
+"@approvio/api@npm:0.0.18":
+  version: 0.0.18
+  resolution: "@approvio/api@npm:0.0.18"
+  checksum: 10/44420111f4b05893fedc2779548ca14c514ef14cb8a21ab19d462202abc9a76b6b2adf65fce3498a2aa8254f7024be68104eb364cfeb29189706f577959707d8
   languageName: node
   linkType: hard
 
 "@approvio/backend@workspace:.":
   version: 0.0.0-use.local
   resolution: "@approvio/backend@workspace:."
   dependencies:
-    "@approvio/api": "npm:0.0.17"
+    "@approvio/api": "npm:0.0.18"
     "@nestjs/bull": "npm:11.0.4"
     "@nestjs/cli": "npm:11.0.14"
     "@nestjs/common": "npm:11.1.9"
@@ -150,7 +150,7 @@ __metadata:
     fp-ts: "npm:2.16.11"
     ioredis: "npm:5.8.2"
     jest: "npm:29.7.0"
-    node-loader: "npm:^2.1.0"
+    node-loader: "npm:2.1.0"
     nodemailer: "npm:7.0.11"
     openid-client: "npm:6.8.1"
     passport: "npm:0.7.0"
@@ -9081,7 +9081,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"node-loader@npm:^2.1.0":
+"node-loader@npm:2.1.0":
   version: 2.1.0
   resolution: "node-loader@npm:2.1.0"
   dependencies: