refactor: changer le nom du champ à is_orientable_with_form

Author: dmc1985

back/dora/emplois/serializers.py

@@ -44,7 +44,7 @@ class ServiceSerializer(serializers.ModelSerializer):
         many=True, read_only=True, slug_field="name"
     )
     kinds = serializers.SlugRelatedField(many=True, read_only=True, slug_field="label")
-    is_orientable_with_dora_form = serializers.SerializerMethodField()
+    is_orientable_with_form = serializers.SerializerMethodField()
     average_orientation_response_delay_days = serializers.SerializerMethodField()
 
     class Meta:
@@ -65,7 +65,7 @@ class Meta:
             "online_form",
             "credentials",
             "kinds",
-            "is_orientable_with_dora_form",
+            "is_orientable_with_form",
             "is_contact_info_public",
             "average_orientation_response_delay_days",
         ]
@@ -158,7 +158,7 @@ def get_mobilization_modes_individuals(self, obj):
     def get_forms_info(self, obj):
         return [{"name": form, "url": default_storage.url(form)} for form in obj.forms]
 
-    def get_is_orientable_with_dora_form(self, obj):
+    def get_is_orientable_with_form(self, obj):
         return obj.is_orientable() and any(
             mode.value == "formulaire-dora"
             for mode in obj.coach_orientation_modes.all()

back/dora/emplois/tests/test_emplois_serializers.py

@@ -357,7 +357,7 @@ def test_service_serializer_kinds():
     ]
 
 
-def test_service_serializer_is_orientable_with_dora_form_when_orientable_and_mode(
+def test_service_serializer_is_orientable_with_form_when_orientable_and_mode(
     orientable_service_via_dora_form,
 ):
     service = orientable_service_via_dora_form
@@ -369,10 +369,10 @@ def test_service_serializer_is_orientable_with_dora_form_when_orientable_and_mod
     assert service.is_orientable() is True
 
     data = ServiceSerializer(service).data
-    assert data["is_orientable_with_dora_form"] is True
+    assert data["is_orientable_with_form"] is True
 
 
-def test_service_serializer_is_not_orientable_with_dora_form_when_not_orientable():
+def test_service_serializer_is_not_orientable_with_form_when_not_orientable():
     service = make_published_service()
     service.contact_email = ""
     service.structure.disable_orientation_form = True
@@ -385,10 +385,10 @@ def test_service_serializer_is_not_orientable_with_dora_form_when_not_orientable
     assert service.is_orientable() is False
 
     data = ServiceSerializer(service).data
-    assert data["is_orientable_with_dora_form"] is False
+    assert data["is_orientable_with_form"] is False
 
 
-def test_service_serializer_is_not_orientable_with_dora_form_without_dora_mode(
+def test_service_serializer_is_not_orientable_with_form_without_dora_mode(
     orientable_service_via_dora_form,
 ):
     service = orientable_service_via_dora_form
@@ -400,10 +400,10 @@ def test_service_serializer_is_not_orientable_with_dora_form_without_dora_mode(
     )
 
     data = ServiceSerializer(service).data
-    assert data["is_orientable_with_dora_form"] is False
+    assert data["is_orientable_with_form"] is False
 
 
-def test_service_serializer_is_orientable_with_dora_form_when_ft_whitelisted(
+def test_service_serializer_is_orientable_with_form_when_ft_whitelisted(
     ft_orientable_service,
 ):
     service = ft_orientable_service
@@ -421,7 +421,7 @@ def test_service_serializer_is_orientable_with_dora_form_when_ft_whitelisted(
     assert service.is_orientable() is True
 
     data = ServiceSerializer(service).data
-    assert data["is_orientable_with_dora_form"] is True
+    assert data["is_orientable_with_form"] is True
 
 
 def test_average_orientation_response_delay_days_none_when_no_orientations():