Skip to content

Commit 313d7f1

Browse files
committed
Merge branch 'develop'
2 parents fdba5cd + ff7b59d commit 313d7f1

File tree

4 files changed

+31
-13
lines changed

4 files changed

+31
-13
lines changed

RELEASE_NOTES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
Release Notes
22
=============
33

4+
## 1.4.0
5+
6+
- Added `slot` and `template` elements
7+
- Added .NET Standard 2.0 support for full framework support
8+
49
## 1.3.0
510

611
Upgraded to `net5.0` target framework.

src/Giraffe.ViewEngine/Engine.fs

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,10 @@ module HtmlElements =
232232
let menuitem = voidTag "menuitem"
233233
let summary = tag "summary"
234234

235+
// Web Components
236+
let slot = tag "slot"
237+
let template = tag "template"
238+
235239
// Others
236240
let iframe = tag "iframe"
237241

@@ -634,14 +638,23 @@ module RenderView =
634638

635639
[<RequireQualifiedAccess>]
636640
module AsBytes =
637-
open System.Buffers
638641

639642
let private outputAsBytes (sb : StringBuilder) =
640-
let chars = ArrayPool<char>.Shared.Rent sb.Length
643+
let chars =
644+
#if NETSTANDARD2_0
645+
Array.create (sb.Length) Char.MinValue
646+
#else
647+
System.Buffers.ArrayPool<char>.Shared.Rent sb.Length
648+
#endif
649+
641650
sb.CopyTo(0, chars, 0, sb.Length)
642651
let result = Encoding.UTF8.GetBytes(chars, 0, sb.Length)
643652
StringBuilderPool.Release sb
644-
ArrayPool<char>.Shared.Return chars
653+
654+
#if !NETSTANDARD2_0
655+
System.Buffers.ArrayPool<char>.Shared.Return chars
656+
#endif
657+
645658
result
646659

647660
let xmlNode (node : XmlNode) : byte[] =

src/Giraffe.ViewEngine/Giraffe.ViewEngine.fsproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<NeutralLanguage>en-GB</NeutralLanguage>
99

1010
<!-- Build settings -->
11-
<TargetFramework>net5.0</TargetFramework>
11+
<TargetFrameworks>net5.0;netstandard2.0</TargetFrameworks>
1212
<DebugType>portable</DebugType>
1313
<OutputType>Library</OutputType>
1414
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
@@ -46,5 +46,5 @@
4646
<Compile Include="StringBuilderPool.fs" />
4747
<Compile Include="Engine.fs" />
4848
</ItemGroup>
49-
49+
5050
</Project>

tests/Giraffe.ViewEngine.Tests/Giraffe.ViewEngine.Tests.fsproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
</ItemGroup>
1313

1414
<ItemGroup>
15-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.0" />
16-
<PackageReference Include="System.Runtime.Serialization.Primitives" Version="4.3.0" />
17-
<PackageReference Include="System.Net.Http" Version="4.3.4" />
18-
<PackageReference Include="xunit" Version="2.4.1" />
19-
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
20-
<PackageReference Include="NSubstitute" Version="4.2.2" />
21-
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" PrivateAssets="All" />
22-
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="5.0.0" />
15+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.*" />
16+
<PackageReference Include="System.Runtime.Serialization.Primitives" Version="4.3.*" />
17+
<PackageReference Include="System.Net.Http" Version="4.3.*" />
18+
<PackageReference Include="xunit" Version="2.4.*" />
19+
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.*" />
20+
<PackageReference Include="NSubstitute" Version="4.2.*" />
21+
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.*" PrivateAssets="All" />
22+
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="5.0.*" />
2323
</ItemGroup>
2424

2525
<ItemGroup>

0 commit comments

Comments
 (0)