You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been building on slicer_cli_web and have three small changes that seem generally useful. Each is additive and opt-in. Would you be open to PRs for any of these?
I've worked around not having these in girder_volview, but I don't know if there are better approaches that would make them unnecessary.
Record a job's outputs on the job — stamp a per-run uuid on every
output upload reference, then correlate each uploaded output back to its job
and record the produced file id on the job under slicerCLIBindings.outputs.items,
keyed by the output parameter name. A consumer reads a job's outputs straight
from the job instead of watching uploads or scanning a folder by name. This
generalizes the existing single parameter-output binding and is the plumbing
that would let Record result ids in job record #181 cover every output. Correlate CLI outputs with their job via a run uuid PaulHax/slicer_cli_web#1
I've been building on
slicer_cli_weband have three small changes that seem generally useful. Each is additive and opt-in. Would you be open to PRs for any of these?I've worked around not having these in girder_volview, but I don't know if there are better approaches that would make them unnecessary.
Record a job's outputs on the job — stamp a per-run
uuidon everyoutput upload reference, then correlate each uploaded output back to its job
and record the produced file id on the job under
slicerCLIBindings.outputs.items,keyed by the output parameter name. A consumer reads a job's outputs straight
from the job instead of watching uploads or scanning a folder by name. This
generalizes the existing single parameter-output binding and is the plumbing
that would let Record result ids in job record #181 cover every output.
Correlate CLI outputs with their job via a run uuid PaulHax/slicer_cli_web#1
Multiple files for one input — an input marked
multiple="true"acceptsa comma-separated list of Girder ids and fans out to one read-only bind mount
per file, letting a CLI consume a multi-file series without an in-container
Girder token.
Support multiple files for a single Girder-resource input PaulHax/slicer_cli_web#2
Don't record a canceled job as an error — a canceled run stops the
container before it writes outputs, so the upload hooks currently fail the
job as
ERRORinstead ofCANCELED; skip the hooks whentask.canceled.Do not record a canceled job as an error when its outputs are missing PaulHax/slicer_cli_web#3