Revert "Disable interactive git credential prompts on fetch operations (#16)" (#18)

This reverts commit 2fa5c83.

Author: bschellenberger2600

.goreleaser.stable.yaml

@@ -97,29 +97,24 @@ changelog:
     - title: Other
       order: 999
 
-homebrew_casks:
+brews:
   - name: git-rain
     repository:
       owner: git-fire
       name: homebrew-tap
       token: "{{ .Env.HOMEBREW_TAP_TOKEN }}"
       pull_request:
         enabled: false
+    directory: Formula
     commit_author:
       name: goreleaserbot
       email: bot@goreleaser.com
     commit_msg_template: "chore: update git-rain to {{ .Tag }}"
     homepage: "https://github.com/git-fire/git-rain"
     description: "Sync local git repositories from their remotes — the reverse of git-fire"
     license: MIT
-    binaries:
-      - git-rain
-    hooks:
-      post:
-        install: |
-          if OS.mac?
-            system_command "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "#{staged_path}/git-rain"]
-          end
+    install: bin.install "git-rain"
+    test: system "#{bin}/git-rain", "--version"
 
 release:
   github:

cmd/root.go

@@ -888,7 +888,6 @@ func fetchOnly(repoPath string, opts git.RainOptions) error {
 	}
 	cmd := exec.Command("git", fetchArgs...)
 	cmd.Dir = repoPath
-	git.PrepareNetworkGit(cmd)
 	if out, err := cmd.CombinedOutput(); err != nil {
 		return fmt.Errorf("%s: %w (output: %s)", strings.Join(append([]string{"git"}, fetchArgs...), " "), err, strings.TrimSpace(string(out)))
 	}

cmd/root_test.go

@@ -487,7 +487,6 @@ func TestFetchFailureMessage(t *testing.T) {
 		{"authentication", "Authentication failed for git@github.com", "could not authenticate with remote — check your credentials and try again"},
 		{"permission denied", "git@github.com: Permission denied (publickey)", "could not authenticate with remote — check your credentials and try again"},
 		{"could not read", "fatal: could not read from remote", "could not authenticate with remote — check your credentials and try again"},
-		{"terminal prompts disabled", "fatal: could not read Username for 'https://github.com': terminal prompts disabled", "could not authenticate with remote — check your credentials and try again"},
 		{"401", "fatal: HTTP 401: Unauthorized", "could not authenticate with remote — check your credentials and try again"},
 		{"403", "fatal: HTTP 403 forbidden", "could not authenticate with remote — check your credentials and try again"},
 		{"could not resolve", "fatal: unable to access ...: Could not resolve host", "could not reach remote — check your network and try again"},

go.mod

@@ -6,7 +6,6 @@ require (
 	github.com/charmbracelet/bubbles v1.0.0
 	github.com/charmbracelet/bubbletea v1.3.10
 	github.com/charmbracelet/lipgloss v1.1.0
-	github.com/git-fire/git-harness v0.3.1
 	github.com/git-fire/git-testkit v0.2.0
 	github.com/gofrs/flock v0.12.1
 	github.com/mattn/go-runewidth v0.0.19

go.sum

@@ -29,8 +29,6 @@ github.com/frankban/quicktest v1.14.6 h1:7Xjx+VpznH+oBnejlPUj8oUpdxnVs4f8XU8WnHk
 github.com/frankban/quicktest v1.14.6/go.mod h1:4ptaffx2x8+WTWXmUCuVU6aPUX1/Mz7zb5vbUoiM6w0=
 github.com/fsnotify/fsnotify v1.9.0 h1:2Ml+OJNzbYCTzsxtv8vKSFD9PbJjmhYF14k/jKC7S9k=
 github.com/fsnotify/fsnotify v1.9.0/go.mod h1:8jBTzvmWwFyi3Pb8djgCCO5IBqzKJ/Jwo8TRcHyHii0=
-github.com/git-fire/git-harness v0.3.1 h1:+fCQ9nMS3YI7r9iVGrU95oefH8N86XjxcYSqsin/1aE=
-github.com/git-fire/git-harness v0.3.1/go.mod h1:cNvjYdbowpoO/KdJwtGenhySx+EkgoQJujuANJpRpj4=
 github.com/git-fire/git-testkit v0.2.0 h1:IFzOxMdNTE5A4lnzbFz62h2R44+3qVy27Xj1KWyGi1Y=
 github.com/git-fire/git-testkit v0.2.0/go.mod h1:YlJlkY9JfGdYTe9o9W3l+gv9BPj05FGu6HK36Z5jwVA=
 github.com/go-viper/mapstructure/v2 v2.4.0 h1:EBsztssimR/CONLSZZ04E8qAkxNYq4Qp9LvH92wZUgs=

internal/git/command.go

@@ -146,7 +146,6 @@ func MainlineFetchRemotes(repoPath string, opts RainOptions) (RainResult, error)
 		}
 		cmd := exec.Command("git", args...)
 		cmd.Dir = repoPath
-		PrepareNetworkGit(cmd)
 		if output, err := cmd.CombinedOutput(); err != nil {
 			failedReason[remote] = fetchFailureReason(output)
 		}

internal/git/command_test.go

@@ -201,7 +201,6 @@ func RainRepository(repoPath string, opts RainOptions) (RainResult, error) {
 		}
 		cmd := exec.Command("git", fetchArgs...)
 		cmd.Dir = repoPath
-		PrepareNetworkGit(cmd)
 		if output, fetchErr := cmd.CombinedOutput(); fetchErr != nil {
 			// Freeze gracefully — could not reach remote (auth, network, etc.).
 			// This is not a hard failure; the repo is untouched. Try again later.