feedback

Author: bschellenberger2600

README.md

@@ -88,6 +88,8 @@ winget install git-rain.git-rain
 
 First-party install script (same idea as [`git-fire/scripts/install.sh`](https://github.com/git-fire/git-fire/blob/main/scripts/install.sh)): downloads the matching `.tar.gz` from [Releases](https://github.com/git-fire/git-rain/releases), verifies `checksums.txt`, and installs to `$INSTALL_DIR` (default `~/.local/bin`).
 
+The `main` URL below always runs the installer script from the latest commit on that branch, while the binary itself comes from the latest GitHub release (or from `VERSION` if you set it). That is convenient for copy-paste installs, but it means the script can drift ahead of any given release. For a fully pinned install, use the release tag in the URL (as in each release’s notes) and set `VERSION` to the same tag.
+
 ```bash
 curl -fsSL https://raw.githubusercontent.com/git-fire/git-rain/main/scripts/install.sh | bash
 ```
@@ -98,6 +100,12 @@ Pin a version or install directory (environment variables must apply to `bash`,
 curl -fsSL https://raw.githubusercontent.com/git-fire/git-rain/main/scripts/install.sh | VERSION=v0.9.1 INSTALL_DIR=/usr/local/bin bash
 ```
 
+If your shell does not already include `~/.local/bin` on `PATH`, add it (the installer prints a reminder). Example for bash:
+
+```bash
+echo 'export PATH="$HOME/.local/bin:$PATH"' >> ~/.bashrc && source ~/.bashrc
+```
+
 Windows is not supported by this script — use **WinGet** or download a `.zip` from Releases.
 
 ### Linux native packages (`.deb` / `.rpm`)

scripts/install.sh

@@ -68,6 +68,7 @@ normalize_arch() {
   case "$raw_arch" in
     x86_64 | amd64) echo "amd64" ;;
     aarch64 | arm64) echo "arm64" ;;
+    # linux/arm is published as armv6 only; armv7l is ABI-compatible.
     armv6l | armv7l) echo "armv6" ;;
     i386 | i686) echo "386" ;;
     *)
@@ -105,25 +106,38 @@ install_binary() {
     fail "install path exists but is not a directory: $target_dir"
   fi
 
-  if [ -w "$target_dir" ]; then
-    install -m 0755 "$src_bin" "$target_bin"
-    return
+  if [ ! -d "$target_dir" ]; then
+    if mkdir -p "$target_dir" 2>/dev/null; then
+      :
+    elif command -v sudo >/dev/null 2>&1; then
+      sudo mkdir -p "$target_dir"
+    else
+      fail "could not create install directory: $target_dir"
+    fi
   fi
 
-  if [ ! -e "$target_dir" ] && mkdir -p "$target_dir"; then
+  if [ -w "$target_dir" ]; then
     install -m 0755 "$src_bin" "$target_bin"
     return
   fi
 
   if command -v sudo >/dev/null 2>&1; then
-    sudo mkdir -p "$target_dir"
     sudo install -m 0755 "$src_bin" "$target_bin"
     return
   fi
 
   fail "install directory is not writable and sudo is unavailable: $target_dir"
 }
 
+path_has_dir() {
+  local dir="$1"
+  case ":${PATH:-}:" in
+    *":${dir}:"*) return 0 ;;
+    *) return 1 ;;
+  esac
+}
+
+# Preflight: fail fast before downloads (curl/wget checked in download_to).
 need_cmd tar
 os="$(normalize_os)"
 arch="$(normalize_arch)"
@@ -163,4 +177,7 @@ tar -xzf "$archive_path" -C "$tmp_dir"
 install_binary "$tmp_dir/$BINARY_NAME" "$INSTALL_DIR"
 
 log "installed to $INSTALL_DIR/$BINARY_NAME"
+if ! path_has_dir "$INSTALL_DIR"; then
+  log "warning: $INSTALL_DIR is not on PATH; add it to your shell profile, e.g. export PATH=\"$INSTALL_DIR:\$PATH\""
+fi
 log "verify with: $BINARY_NAME --version"