Installation fails for 2.49.0

[Dany-HBK]

I was trying to update from update message and got "unable to access 'c:\Program Files\Git\dev' (it is actually not there.
I always copy the installer while updating as it will be deleted after closing the update, even if an error occurs (and the automatic "rolling back" function does not restore the previous installation, as everything is gone in that case).
When I re-run the setup a second time I get the same error (ofc the dev folder does not exist).
I created the dev folder and voila, the setup runs.
But I have to reapply all option-selections again for each setup-run after the failure.
Kind regards,
Daniel

[dscho]

Hmm. There have not been any changes in this area of the code for quite a while. Do you remember from which version you tried to update?

[dscho]

Also, I should note that I did not encounter such an issue in my test prior to releasing.

[Dany-HBK]

I've had 2.48.1 installed before.

[dscho]

I've had 2.48.1 installed before.

That's strange. I had that installed, too, before I started testing the v2.49.0-rc* versions. And it all worked for me. You wouldn't happen to have a simple reproduction recipe, would you?

[Dany-HBK]

The strange thing is, I uninstalled and re-installed it without error.
After uninstalling there still where the cmd and etc folders left, but no dev.
I guess we can close this issue, though the rollback functionality should be removed or fixed, as it does not restore the previous installation.
Sorry for the trouble, and thanks for your support :)

[Dany-HBK]

I'm using Inno Setup as well and there I always overwrite existing installations, probably with InstallDelete entries ;)

[dscho]

the rollback functionality should be removed or fixed

I do not believe that there is such a rollback functionality in Git for Windows' installer.

[dscho]

After uninstalling there still where the cmd and etc folders left, but no dev.

For the record, after uninstalling, there should not be any of those folders left...

[Dany-HBK]

the rollback functionality should be removed or fixed

I do not believe that there is such a rollback functionality in Git for Windows' installer.

That's what the setup told me when it failed though (something like "rolling back changes").
Perhaps an internal function that just reverses its install database to the last point (nothing if first install).

[Dany-HBK]

After uninstalling there still where the cmd and etc folders left, but no dev.

For the record, after uninstalling, there should not be any of those folders left...

Actually, cmd is empty and in etc there's a file gitconfig (I assume the global configuration).
Edit: A clean installation keeps that etc/gitconfig file after uninstall.

[dscho]

A clean installation keeps that etc/gitconfig file after uninstall.

Oh... Shouldn't it be removed, too? The code when upgrading certainly expects it to be removed during uninstall.

[becm]

@dscho would not expect deletion, since system config is not even mentioned in uninstall set.
The extra copy is likely kept to replace a new (default) file shipped during an update.

[Dany-HBK]

The issue I see with etc/gitconfig is, that it is created from the chosen options during first installation. But it will not be overwritten by a new installation with different choices because of this (at least it looks like that):
procedure CleanupWhenUpgrading;

[dscho]

would not expect deletion, since system config is not even mentioned in uninstall set.

@becm Indeed. I actually assumed that it was part of the mingw-w64-git-extra package. But that's not the case, and running git -C /var/lib/pacman/local/ log -p -Ggitconfig -- \*.files ':(exclude)*vim*' in a Git for Windows SDK comes up empty, so it never was part of any package, not even the /mingw64/etc/gitconfig .

The extra copy is likely kept to replace a new (default) file shipped during an update.

This copies from {tmp}\gitconfig.system, which is specifically created as a copy of /etc/gitconfig when upgrading, and that happens just before uninstalling a previous Git for Windows version, if there is any (i.e. when upgrading) in the function called just before installing the current Git for Windows version.

The fact that I added that code in order to "retain system config across upgrades" suggests to me that I expected the /etc/gitconfig file to be deleted upon uninstallation.

And I still think that this should happen, and since it does not, that should be fixed.

The issue I see with etc/gitconfig is, that it is created from the chosen options during first installation. But it will not be overwritten by a new installation with different choices because of this (at least it looks like that):
procedure CleanupWhenUpgrading;

@Dany-HBK The way CleanupWhenUpgrading copies the system config to a temporary location and CurStepChanged then copies it back during the ssPostInstall step might look as if "will not be overwritten", but it is technically recreated during an upgrade. But it should not exist after removing ("uninstalling") Git for Windows.

This all leads us away from the original issue, though, which is that dev is not there even though it should be.