Commit 07824e3
committed
tests(gp_sphinx_vite[ci]): pre-create node_modules in fake-vite roots
why: After 013884d added _ensure_node_modules() auto-install to the
builder-inited hook, six pre-existing tests started shelling out to
real `pnpm install --frozen-lockfile` because their fake vite roots
never had node_modules/. CI (no pnpm on PATH) failed with FileNotFoundError
across all 10 qa matrix jobs.
what:
- _write_fake_vite() gains with_node_modules: bool = True; default
pre-creates node_modules/ so _ensure_node_modules short-circuits.
- test_on_builder_inited_runs_install_when_node_modules_missing now
passes with_node_modules=False to keep its install-path assertion
meaningful.
- Integration test test_sphinx_build_spawns_via_extension pre-creates
node_modules/ in its fake-vite-root.
- Auto-install behaviour itself is unchanged; the three dedicated
install-path tests (skips/runs/fails) still cover it.1 parent d2ebf1d commit 07824e3
2 files changed
Lines changed: 16 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
45 | 53 | | |
| 54 | + | |
| 55 | + | |
46 | 56 | | |
47 | 57 | | |
48 | 58 | | |
| |||
339 | 349 | | |
340 | 350 | | |
341 | 351 | | |
| 352 | + | |
342 | 353 | | |
343 | 354 | | |
344 | 355 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
80 | 83 | | |
81 | 84 | | |
82 | 85 | | |
| |||
0 commit comments