fix: moves zksync missing contribution ingestions to a celery task #10697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
thelostone-mc,
chibie,
nutrina and
tim-schultz
as code owners
gdixon
force-pushed
the
fix-ingest-as-task
branch
from
3b5b6d1 to
7bea500
Compare
chibie
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ingesting contributions from users with a lot of activity on zksync is causing a timeout. We currently pull in all contributions via the zksync api as part of the post request which is too much work to carry out in a user facing request.
This PR moves the zksync ingestion branch into a celery task to not block the request avoiding this timeout issue.
Refers/Fixes
Fixes: #10675
Testing
Tested locally