Skip to content

Commit 0f35ed7

Browse files
authored
Merge pull request #922 from nxnaxx/refactor/#866_rename-di-tokens
refactor: DI container 식별자 상수명 변경
2 parents a7b2ede + f7ba2dd commit 0f35ed7

7 files changed

Lines changed: 16 additions & 16 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
export const SERVICE_TOKENS = {
1+
export const DI_IDENTIFIERS = {
22
OctokitOptions: Symbol.for("OctokitOptions"),
33
} as const;

packages/analysis-engine/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import "reflect-metadata";
33
import { buildCommitDict } from "./commit.util";
44
import { diContainer } from "./container";
55
import { buildCSMDict } from "./csm";
6+
import { DI_IDENTIFIERS } from "./diIdentifiers";
67
import getCommitRaws from "./parser";
78
import { PluginOctokit } from "./pluginOctokit";
8-
import { SERVICE_TOKENS } from "./serviceTokens";
99
import { buildStemDict } from "./stem";
1010
import { getSummary } from "./summary";
1111

@@ -36,7 +36,7 @@ export class AnalysisEngine {
3636
this.gitLog = gitLog;
3737
this.baseBranchName = baseBranchName;
3838
this.isDebugMode = isDebugMode;
39-
diContainer.rebindSync(SERVICE_TOKENS.OctokitOptions).toConstantValue({
39+
diContainer.rebindSync(DI_IDENTIFIERS.OctokitOptions).toConstantValue({
4040
owner,
4141
repo,
4242
options: { auth },

packages/analysis-engine/src/pluginOctokit.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type { ThrottlingOptions } from "@octokit/plugin-throttling/dist-types/ty
44
import { Octokit, type RestEndpointMethodTypes } from "@octokit/rest";
55
import { inject, injectable } from "inversify";
66

7-
import { SERVICE_TOKENS } from "./serviceTokens";
7+
import { DI_IDENTIFIERS } from "./diIdentifiers";
88

99
type PullsListResponseData = RestEndpointMethodTypes["pulls"]["get"]["response"];
1010
type PullsListCommitsResponseData = RestEndpointMethodTypes["pulls"]["listCommits"]["response"];
@@ -16,7 +16,7 @@ export class PluginOctokit extends Octokit.plugin(throttling) {
1616
private repo: string;
1717

1818
constructor(
19-
@inject(SERVICE_TOKENS.OctokitOptions)
19+
@inject(DI_IDENTIFIERS.OctokitOptions)
2020
props: {
2121
owner: string;
2222
repo: string;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
export const SERVICE_TOKENS = {
1+
export const DI_IDENTIFIERS = {
22
IDEAdapter: Symbol.for("IDEAdapter"),
33
} as const;

packages/view/src/index.prod.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import "reflect-metadata";
33
import { diContainer } from "container";
44
import VSCodeIDEAdapter from "ide/VSCodeIDEAdapter";
55
import type IDEPort from "ide/IDEPort";
6-
import { SERVICE_TOKENS } from "container/tokens";
6+
import { DI_IDENTIFIERS } from "container/identifiers";
77

88
import { initRender } from "./index.common";
99

10-
diContainer.bind<IDEPort>(SERVICE_TOKENS.IDEAdapter).to(VSCodeIDEAdapter);
10+
diContainer.bind<IDEPort>(DI_IDENTIFIERS.IDEAdapter).to(VSCodeIDEAdapter);
1111

1212
initRender();

packages/view/src/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import "reflect-metadata";
33
import { diContainer } from "container";
44
import FakeIDEAdapter from "ide/FakeIDEAdapter";
55
import type IDEPort from "ide/IDEPort";
6-
import { SERVICE_TOKENS } from "container/tokens";
6+
import { DI_IDENTIFIERS } from "container/identifiers";
77

88
import { initRender } from "./index.common";
99

10-
diContainer.bind<IDEPort>(SERVICE_TOKENS.IDEAdapter).to(FakeIDEAdapter);
10+
diContainer.bind<IDEPort>(DI_IDENTIFIERS.IDEAdapter).to(FakeIDEAdapter);
1111

1212
initRender();

packages/view/src/services/index.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
11
import type IDEPort from "ide/IDEPort";
22
import { diContainer } from "container";
3-
import { SERVICE_TOKENS } from "container/tokens";
3+
import { DI_IDENTIFIERS } from "container/identifiers";
44
import type { IDESentEvents } from "types";
55

66
export const sendUpdateThemeCommand = (theme: string) => {
7-
const ideAdapter = diContainer.get<IDEPort>(SERVICE_TOKENS.IDEAdapter);
7+
const ideAdapter = diContainer.get<IDEPort>(DI_IDENTIFIERS.IDEAdapter);
88
ideAdapter.sendUpdateThemeMessage(theme);
99
};
1010

1111
export const sendFetchAnalyzedDataCommand = (selectedBranch?: string) => {
12-
const ideAdapter = diContainer.get<IDEPort>(SERVICE_TOKENS.IDEAdapter);
12+
const ideAdapter = diContainer.get<IDEPort>(DI_IDENTIFIERS.IDEAdapter);
1313
ideAdapter.sendFetchAnalyzedDataMessage(selectedBranch);
1414
};
1515

1616
export const sendRefreshDataCommand = (selectedBranch?: string) => {
17-
const ideAdapter = diContainer.get<IDEPort>(SERVICE_TOKENS.IDEAdapter);
17+
const ideAdapter = diContainer.get<IDEPort>(DI_IDENTIFIERS.IDEAdapter);
1818
ideAdapter.sendRefreshDataMessage(selectedBranch);
1919
ideAdapter.sendFetchBranchListMessage();
2020
};
2121

2222
export const sendFetchBranchListCommand = () => {
23-
const ideAdapter = diContainer.get<IDEPort>(SERVICE_TOKENS.IDEAdapter);
23+
const ideAdapter = diContainer.get<IDEPort>(DI_IDENTIFIERS.IDEAdapter);
2424
ideAdapter.sendFetchBranchListMessage();
2525
};
2626

2727
export const initializeIDEConnection = (callbacks: IDESentEvents) => {
28-
const ideAdapter = diContainer.get<IDEPort>(SERVICE_TOKENS.IDEAdapter);
28+
const ideAdapter = diContainer.get<IDEPort>(DI_IDENTIFIERS.IDEAdapter);
2929
ideAdapter.addIDESentEventListener(callbacks);
3030
ideAdapter.sendFetchAnalyzedDataMessage();
3131
ideAdapter.sendFetchBranchListMessage();

0 commit comments

Comments
 (0)