Merge pull request #972 from Kyoungwoong/fix/969-secure-token-issus

Kyoungwoong · web-flow · commit 55454b3817f2 · 2025-10-11T00:34:08.000+09:00
feat[vibe]: Config 싱글톤 패턴으로 GitHub 토큰 중앙 관리
diff --git a/packages/mcp/descriptions/githru-dev-description.md b/packages/mcp/descriptions/githru-dev-description.md
@@ -77,7 +77,8 @@ You need to modify the path inside args in ```githru-mcp/claude_desktop_config.j
           "AbsolutePath/githru-vscode-ext/packages/mcp/dist/server.js"
         ],
         "env": {
-          "NODE_NO_WARNINGS": "1"
+          "NODE_NO_WARNINGS": "1",
+          "GITHUB_TOKEN": "ghphvhvhvhvhvhvhvhvhvhvhvhvhvhvhv"
         }
       }
   }
diff --git a/packages/mcp/src/common/config.ts b/packages/mcp/src/common/config.ts
@@ -0,0 +1,23 @@
+export class Config {
+  private static instance: Config;
+
+  public readonly githubToken: string;
+
+  private constructor() {
+    this.githubToken = process.env.GITHUB_TOKEN || '';
+  }
+
+  public static getInstance(): Config {
+    if (!Config.instance) {
+      Config.instance = new Config();
+    }
+    return Config.instance;
+  }
+
+  public getGithubToken(): string {
+    if (!this.githubToken) {
+      throw new Error("github token missing");
+    }
+    return this.githubToken;
+  }
+}
diff --git a/packages/mcp/src/common/types.ts b/packages/mcp/src/common/types.ts
@@ -12,7 +12,6 @@ export interface GitHubApiInputs {
 export interface FeatureImpactAnalyzerInputs {
   repoUrl: string;
   prNumber: number;
-  githubToken: string;
   locale?: string;
 }
 export interface ContributorRecommenderInputs {
@@ -22,9 +21,8 @@ export interface ContributorRecommenderInputs {
   branch?: string;
   since?: string;
   until?: string;
-  githubToken: string;
   locale?: string;
-  chart?: boolean;
+  isChart?: boolean;
 }
 
 export interface ContributorCandidate {
@@ -47,7 +45,6 @@ export interface CSMDictGeneratorInputs {
   githubToken: string;
   baseBranchName?: string;
   locale?: string;
-  debug?: boolean;
 }
 
 export interface GitUser {
diff --git a/packages/mcp/src/tool/authorWorkPattern.ts b/packages/mcp/src/tool/authorWorkPattern.ts
@@ -4,6 +4,7 @@ import { fileURLToPath } from "url";
 import type { RestEndpointMethodTypes } from "@octokit/rest";
 import { GitHubUtils } from "../common/utils.js";
 import { I18n } from "../common/i18n.js";
+import { Config } from "../common/config.js";
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -17,7 +18,6 @@ export interface AuthorWorkPatternArgs {
   branch?: string;
   since?: string;
   until?: string;
-  githubToken: string;
   locale?: "en" | "ko";
   chart?: boolean;
 }
@@ -59,9 +59,12 @@ export class AuthorWorkPatternAnalyzer {
 
   constructor(private args: AuthorWorkPatternArgs) {
     const { owner, repo } = GitHubUtils.parseRepoUrl(args.repoPath);
+    const config = Config.getInstance();
+    const githubToken = config.getGithubToken();
+
     this.owner = owner;
     this.repo = repo;
-    this.token = args.githubToken;
+    this.token = githubToken;
     this.authorQuery = args.author;
     this.baseBranch = args.branch;
     this.since = args.since;
diff --git a/packages/mcp/src/tool/contributorRecommender.ts b/packages/mcp/src/tool/contributorRecommender.ts
@@ -10,6 +10,7 @@ import type {
   ContributorCandidate, 
   ContributorRecommendation 
 } from "../common/types.js";
+import { Config } from "../common/config.js";
 
 // ES modules에서 __dirname 대체
 const __filename = fileURLToPath(import.meta.url);
@@ -31,11 +32,14 @@ export class ContributorRecommender {
   private until: string;
 
   constructor(inputs: ContributorRecommenderInputs) {
+    const config = Config.getInstance();
+    const githubToken = config.getGithubToken();
+
     if (inputs.locale) {
       I18n.setLocale(inputs.locale);
     }
     
-    this.octokit = GitHubUtils.createGitHubAPIClient(inputs.githubToken);
+    this.octokit = GitHubUtils.createGitHubAPIClient(githubToken);
     
     const { owner, repo } = GitHubUtils.parseRepoUrl(inputs.repoPath);
     this.owner = owner;
diff --git a/packages/mcp/src/tool/featureImpactAnalyzer.ts b/packages/mcp/src/tool/featureImpactAnalyzer.ts
@@ -5,6 +5,7 @@ import * as fs from "fs";
 import * as path from "path";
 import { fileURLToPath } from "url";
 import type { FeatureImpactAnalyzerInputs } from "../common/types.js";
+import { Config } from "../common/config.js";
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -55,10 +56,13 @@ export class McpReportGenerator {
   private owner: string;
   private repo: string;
 
-  constructor({ repoUrl, prNumber, githubToken, locale }: FeatureImpactAnalyzerInputs) {
+  constructor({ repoUrl, prNumber, locale }: FeatureImpactAnalyzerInputs) {
     if (locale) {
       I18n.setLocale(locale);
     }
+    const config = Config.getInstance();
+    const githubToken = config.getGithubToken();
+
     this.repoUrl = repoUrl;
     this.prNumber = prNumber;
     this.octokit = GitHubUtils.createGitHubAPIClient(githubToken);
diff --git a/packages/mcp/src/tool/generateNewViz.ts b/packages/mcp/src/tool/generateNewViz.ts
@@ -52,18 +52,9 @@ class EngineGenerator {
     } catch (cleanupError) {
       // ignore cleanup errors
     }
-
-
-    const originalConsoleLog = console.log;
-    const originalConsoleError = console.error;
-    if (!this.inputs.debug) {
-      console.log = () => {};
-      console.error = () => {};
-    }
     
     try {
       const analysisEngine = new AnalysisEngine({
-        isDebugMode: this.inputs.debug || false,
         gitLog: this.gitLog,
         owner: this.repoInfo.owner,
         repo: this.repoInfo.repo,
@@ -73,8 +64,6 @@ class EngineGenerator {
 
       this.analysisResult = await analysisEngine.analyzeGit();
     } finally {
-      console.log = originalConsoleLog;
-      console.error = originalConsoleError;
     }
   }
 }
@@ -87,16 +76,14 @@ class NewViz {
   }
   
   async generate(): Promise<any> {
-    const { debug = false } = this.engine.inputs;
-    
     if (!this.engine.repoInfo || !this.engine.analysisResult) {
       throw new Error('Engine not initialized');
     }
 
-    return this.buildResult(debug);
+    return this.buildResult();
   }
   
-  private buildResult(debug: boolean): any {
+  private buildResult(): any {
     if (!this.engine.repoInfo || !this.engine.analysisResult) {
       throw new Error('Required data not available');
     }
diff --git a/packages/mcp/src/tool/storylineRenderer.ts b/packages/mcp/src/tool/storylineRenderer.ts
@@ -5,23 +5,23 @@ import ServerSideFolderActivityFlow from '../component/FolderActivityFlow/Server
 import { analyzeReleaseBasedFolders, extractReleaseBasedContributorActivities, generateReleaseFlowLineData, findFirstReleaseContributorNodes } from '../component/FolderActivityFlow/FolderActivityFlow.util.js';
 // @ts-ignore
 import sharp from 'sharp';
+import { Config } from "../common/config.js";
 
 interface StorylineInputs {
   repo: string;
-  githubToken: string;
   baseBranchName?: string;
   locale?: string;
-  debug?: boolean;
 }
 
 export async function renderStorylineUI(inputs: StorylineInputs): Promise<{ type: 'image'; data: string; mimeType: string; annotations?: any } | { type: 'text'; data: string }> {
   try {
+    const config = Config.getInstance();
+    const githubToken = config.getGithubToken();
 
     const totalData = await generateNewViz({
       repo: inputs.repo,
-      githubToken: inputs.githubToken,
+      githubToken: githubToken,
       baseBranchName: inputs.baseBranchName,
-      debug: inputs.debug || false
     });
 
 
diff --git a/packages/mcp/src/tools/analysis/authorWorkPatternTool.ts b/packages/mcp/src/tools/analysis/authorWorkPatternTool.ts
@@ -16,7 +16,6 @@ export function registerAuthorWorkPatternTool(server: McpServer) {
         branch: z.string().optional().describe("브랜치/커밋 SHA (기본: 기본 브랜치)"),
         since: z.string().optional().describe('시작 시점 (예: "2025-09-01" 또는 "30d")'),
         until: z.string().optional().describe("종료 시점 (미지정 시 현재)"),
-        githubToken: z.string().describe("GitHub Personal Access Token"),
         locale: z.enum(["en", "ko"]).default("en").describe("응답 언어"),
         chart: z.boolean().default(false).describe("HTML 차트 리포트 반환 여부"),
       },
@@ -28,7 +27,6 @@ export function registerAuthorWorkPatternTool(server: McpServer) {
       branch,
       since,
       until,
-      githubToken,
       locale,
       chart,
     }: AuthorWorkPatternArgs & { locale?: "en" | "ko"; chart?: boolean }) => {
@@ -41,7 +39,6 @@ export function registerAuthorWorkPatternTool(server: McpServer) {
           branch,
           since,
           until,
-          githubToken,
           locale,
           chart,
         });
diff --git a/packages/mcp/src/tools/analysis/contributorRecommenderTool.ts b/packages/mcp/src/tools/analysis/contributorRecommenderTool.ts
@@ -10,62 +10,60 @@ export function registerContributorRecommenderTool(server: McpServer) {
         title: "Code Contributor Recommender",
         description: "Recommends contributors who have contributed most to specific files/branches/PR areas by aggregating recent contribution data.",
         inputSchema: {
-        repoPath: z.string().describe("GitHub repository path (e.g: owner/repo or https://github.com/owner/repo)"),
-        pr: z.union([z.string(), z.number()]).optional().describe("PR-based recommendation (PR number)"),
-        paths: z.array(z.string()).optional().describe("File/directory path array (supports glob patterns)"),
-        branch: z.string().optional().describe("Branch-based recommendation (default: main)"),
-        since: z.string().optional().describe("Analysis period start (default 90 days, 30d/ISO date etc.)"),
-        until: z.string().optional().describe("Analysis period end (current if unspecified)"),
-        githubToken: z.string().describe("GitHub authentication token"),
-        locale: z.enum(["en", "ko"]).default("en").describe("Response language (en: English, ko: Korean)"),
-        chart: z.boolean().default(false).describe("Generate interactive chart visualization (true: HTML chart display, false: JSON data)"),
+          repoPath: z.string().describe("GitHub repository path (e.g: owner/repo or https://github.com/owner/repo)"),
+          pr: z.union([z.string(), z.number()]).optional().describe("PR-based recommendation (PR number)"),
+          paths: z.array(z.string()).optional().describe("File/directory path array (supports glob patterns)"),
+          branch: z.string().optional().describe("Branch-based recommendation (default: main)"),
+          since: z.string().optional().describe("Analysis period start (default 90 days, 30d/ISO date etc.)"),
+          until: z.string().optional().describe("Analysis period end (current if unspecified)"),
+          locale: z.enum(["en", "ko"]).default("en").describe("Response language (en: English, ko: Korean)"),
+          isChart: z.boolean().default(false).describe("Generate interactive chart visualization (true: HTML chart display, false: JSON data)"),
         },
     },
 
-    async ({ repoPath, pr, paths, branch, since, until, githubToken, locale, chart }: ContributorRecommenderInputs & { locale?: string; chart?: boolean }) => {
+    async ({ repoPath, pr, paths, branch, since, until, locale, isChart }: ContributorRecommenderInputs & { locale?: string; chart?: boolean }) => {
         try {
-        I18n.setLocale(locale || 'en');
-        
-        const { ContributorRecommender } = await import('../../tool/contributorRecommender.js');
-        const recommender = new ContributorRecommender({
-            repoPath,
-            pr,
-            paths,
-            branch,
-            since,
-            until,
-            githubToken,
-            locale,
-        });
+          I18n.setLocale(locale || 'en');
+
+          const { ContributorRecommender } = await import('../../tool/contributorRecommender.js');
+          const recommender = new ContributorRecommender({
+              repoPath,
+              pr,
+              paths,
+              branch,
+              since,
+              until,
+              locale,
+          });
         
-        const recommendation = await recommender.analyze();
+          const recommendation = await recommender.analyze();
 
-        if (chart) {
-            const chartHtml = recommender.generateChart(recommendation);
-            return {
-            content: [
-                {
-                type: "text",
-                text: chartHtml,
-                },
-            ],
-            };
-        } else {
-            return {
-            content: [
-                {
-                type: "text",
-                text: JSON.stringify(recommendation, null, 2),
-                },
-            ],
-            };
-        }
+          if (isChart) {
+              const chartHtml = recommender.generateChart(recommendation);
+              return {
+                content: [
+                    {
+                      type: "text",
+                      text: chartHtml,
+                    },
+                ],
+              };
+          } else {
+              return {
+                content: [
+                    {
+                      type: "text",
+                      text: JSON.stringify(recommendation, null, 2),
+                    },
+                ],
+              };
+          }
         } catch (err: any) {
-        return {
-            content: [
-            { type: "text", text: `Contributor recommendation error occurred: ${err?.message ?? String(err)}` },
-            ],
-        };
+          return {
+              content: [
+                { type: "text", text: `Contributor recommendation error occurred: ${err?.message ?? String(err)}` },
+              ],
+          };
         }
     }
   );
diff --git a/packages/mcp/src/tools/analysis/featureImpactTool.ts b/packages/mcp/src/tools/analysis/featureImpactTool.ts
@@ -17,18 +17,17 @@ export function registerFeatureImpactTool(server: McpServer) {
         inputSchema: {
         repoUrl: z.string().url().describe("Full URL of GitHub repository to analyze (e.g. https://github.com/owner/repo)"),
         prNumber: z.number().int().positive().describe("Pull Request number to analyze"),
-        githubToken: z.string().describe("GitHub authentication token"),
         locale: z.enum(["en", "ko"]).default("en").describe("Response language (en: English, ko: Korean)"),
         isChart: z.boolean().default(false).describe("Return HTML chart (true) or JSON (false, default)"),
         },
     },
 
-    async ({ repoUrl, prNumber, githubToken, locale, isChart }: FeatureImpactAnalyzerInputs & { locale?: string; isChart?: boolean }) => {
+    async ({ repoUrl, prNumber, locale, isChart }: FeatureImpactAnalyzerInputs & { locale?: string; isChart?: boolean }) => {
         try {
         I18n.setLocale(locale || 'en');
         
         const { McpReportGenerator } = await import("../../tool/featureImpactAnalyzer.js");
-        const analyzeFeatureImpact = new McpReportGenerator({ repoUrl, prNumber, githubToken, locale });
+        const analyzeFeatureImpact = new McpReportGenerator({ repoUrl, prNumber, locale });
 
         const payload = await analyzeFeatureImpact.generateWithOutlierRatings();
         
diff --git a/packages/mcp/src/tools/react/generateCSMDict.ts b/packages/mcp/src/tools/react/generateCSMDict.ts
diff --git a/packages/mcp/src/tools/storyLineUI/storyLineUITool.ts b/packages/mcp/src/tools/storyLineUI/storyLineUITool.ts

Original file line number	Diff line number	Diff line change
@@ -77,7 +77,8 @@ You need to modify the path inside args in ```githru-mcp/claude_desktop_config.j
`77`	`77`	`"AbsolutePath/githru-vscode-ext/packages/mcp/dist/server.js"`
`78`	`78`	`],`
`79`	`79`	`"env": {`
`80`		`- "NODE_NO_WARNINGS": "1"`
	`80`	`+ "NODE_NO_WARNINGS": "1",`
	`81`	`+ "GITHUB_TOKEN": "ghphvhvhvhvhvhvhvhvhvhvhvhvhvhvhv"`
`81`	`82`	`}`
`82`	`83`	`}`
`83`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,18 +52,9 @@ class EngineGenerator {`
`52`	`52`	`} catch (cleanupError) {`
`53`	`53`	`// ignore cleanup errors`
`54`	`54`	`}`
`55`		`-`
`56`		`-`
`57`		`- const originalConsoleLog = console.log;`
`58`		`- const originalConsoleError = console.error;`
`59`		`- if (!this.inputs.debug) {`
`60`		`- console.log = () => {};`
`61`		`- console.error = () => {};`
`62`		`- }`
`63`	`55`
`64`	`56`	`try {`
`65`	`57`	`const analysisEngine = new AnalysisEngine({`
`66`		`- isDebugMode: this.inputs.debug \|\| false,`
`67`	`58`	`gitLog: this.gitLog,`
`68`	`59`	`owner: this.repoInfo.owner,`
`69`	`60`	`repo: this.repoInfo.repo,`
`@@ -73,8 +64,6 @@ class EngineGenerator {`
`73`	`64`
`74`	`65`	`this.analysisResult = await analysisEngine.analyzeGit();`
`75`	`66`	`} finally {`
`76`		`- console.log = originalConsoleLog;`
`77`		`- console.error = originalConsoleError;`
`78`	`67`	`}`
`79`	`68`	`}`
`80`	`69`	`}`
`@@ -87,16 +76,14 @@ class NewViz {`
`87`	`76`	`}`
`88`	`77`
`89`	`78`	`async generate(): Promise<any> {`
`90`		`- const { debug = false } = this.engine.inputs;`
`91`		`-`
`92`	`79`	`if (!this.engine.repoInfo \|\| !this.engine.analysisResult) {`
`93`	`80`	`throw new Error('Engine not initialized');`
`94`	`81`	`}`
`95`	`82`
`96`		`- return this.buildResult(debug);`
	`83`	`+ return this.buildResult();`
`97`	`84`	`}`
`98`	`85`
`99`		`- private buildResult(debug: boolean): any {`
	`86`	`+ private buildResult(): any {`
`100`	`87`	`if (!this.engine.repoInfo \|\| !this.engine.analysisResult) {`
`101`	`88`	`throw new Error('Required data not available');`
`102`	`89`	`}`