refactor: perPage → commitCountPerPage

Author: “chae-dahee”

packages/analysis-engine/src/csm.spec.ts

@@ -438,13 +438,8 @@ describe("csm", () => {
 
   describe("buildPaginatedCSMDict", () => {
     it("should load first page when lastCommitId is not provided", () => {
-      const perPage = 2;
-      const result = buildPaginatedCSMDict(
-        fakeCommitNodeDict,
-        fakeStemDict,
-        "master",
-        perPage
-      );
+      const commitCountPerPage = 2;
+      const result = buildPaginatedCSMDict(fakeCommitNodeDict, fakeStemDict, "master", commitCountPerPage);
 
       expect(result).toBeDefined();
       expect(result.master).toBeDefined();
@@ -456,12 +451,12 @@ describe("csm", () => {
     });
 
     it("should load next page when lastCommitId is provided", () => {
-      const perPage = 2;
+      const commitCountPerPage = 2;
       const result = buildPaginatedCSMDict(
         fakeCommitNodeDict,
         fakeStemDict,
         "master",
-        perPage,
+        commitCountPerPage,
         "4" // Last commit of first page
       );
 
@@ -474,12 +469,12 @@ describe("csm", () => {
     });
 
     it("should return remaining nodes when perPage exceeds remaining nodes", () => {
-      const perPage = 10;
+      const commitCountPerPage = 10;
       const result = buildPaginatedCSMDict(
         fakeCommitNodeDict,
         fakeStemDict,
         "master",
-        perPage,
+        commitCountPerPage,
         "2" // Only [1, 0] remaining
       );
 
@@ -491,12 +486,12 @@ describe("csm", () => {
     });
 
     it("should return empty array when no more nodes available", () => {
-      const perPage = 2;
+      const commitCountPerPage = 2;
       const result = buildPaginatedCSMDict(
         fakeCommitNodeDict,
         fakeStemDict,
         "master",
-        perPage,
+        commitCountPerPage,
         "0" // Last node
       );
 
@@ -507,44 +502,23 @@ describe("csm", () => {
 
     it("should throw error when lastCommitId is invalid", () => {
       expect(() => {
-        buildPaginatedCSMDict(
-          fakeCommitNodeDict,
-          fakeStemDict,
-          "master",
-          2,
-          "invalid-commit-id"
-        );
+        buildPaginatedCSMDict(fakeCommitNodeDict, fakeStemDict, "master", 2, "invalid-commit-id");
       }).toThrow("Invalid lastCommitId");
     });
 
     it("should throw error when perPage is less than or equal to 0", () => {
       expect(() => {
-        buildPaginatedCSMDict(
-          fakeCommitNodeDict,
-          fakeStemDict,
-          "master",
-          0
-        );
+        buildPaginatedCSMDict(fakeCommitNodeDict, fakeStemDict, "master", 0);
       }).toThrow("perPage must be greater than 0");
 
       expect(() => {
-        buildPaginatedCSMDict(
-          fakeCommitNodeDict,
-          fakeStemDict,
-          "master",
-          -1
-        );
+        buildPaginatedCSMDict(fakeCommitNodeDict, fakeStemDict, "master", -1);
       }).toThrow("perPage must be greater than 0");
     });
 
     it("should throw error when base branch does not exist", () => {
       expect(() => {
-        buildPaginatedCSMDict(
-          fakeCommitNodeDict,
-          fakeStemDict,
-          "non-existent-branch",
-          2
-        );
+        buildPaginatedCSMDict(fakeCommitNodeDict, fakeStemDict, "non-existent-branch", 2);
       }).toThrow("no master-stem");
     });
 
@@ -566,14 +540,7 @@ describe("csm", () => {
         },
       } as unknown as PullRequest;
 
-      const result = buildPaginatedCSMDict(
-        fakeCommitNodeDict,
-        fakeStemDict,
-        "master",
-        1,
-        undefined,
-        [fakePR]
-      );
+      const result = buildPaginatedCSMDict(fakeCommitNodeDict, fakeStemDict, "master", 1, undefined, [fakePR]);
 
       expect(result.master[0].base.commit.id).toBe("5");
       // PR integration logic should be applied

packages/analysis-engine/src/csm.ts

@@ -165,13 +165,13 @@ export const buildPaginatedCSMDict = (
   commitDict: CommitDict,
   stemDict: StemDict,
   baseBranchName: string,
-  perPage: number,
+  commitCountPerPage: number,
   lastCommitId?: string,
   pullRequests: Array<PullRequest> = []
 ): CSMDictionary => {
-  // Validate perPage
-  if (perPage <= 0) {
-    throw new Error("perPage must be greater than 0");
+  // Validate commitCountPerPage
+  if (commitCountPerPage <= 0) {
+    throw new Error("commitCountPerPage must be greater than 0");
   }
 
   // Validate stemDict
@@ -196,7 +196,7 @@ export const buildPaginatedCSMDict = (
   }
 
   // Calculate end index and extract page nodes
-  const endIndex = Math.min(startIndex + perPage, baseStem.nodes.length);
+  const endIndex = Math.min(startIndex + commitCountPerPage, baseStem.nodes.length);
   const pageNodes = baseStem.nodes.slice(startIndex, endIndex);
 
   // Build CSM nodes with PR integration

packages/analysis-engine/src/index.ts

@@ -83,28 +83,25 @@ export class AnalysisEngine {
     if (this.isDebugMode) console.log("stemDict: ", this.stemDict);
   };
 
-  public analyzeGit = async (
-    perPage?: number,
-    lastCommitId?: string
-  ): Promise<AnalyzeGitResult> => {
+  public analyzeGit = async (commitCountPerPage?: number, lastCommitId?: string): Promise<AnalyzeGitResult> => {
     if (!this.commitDict || !this.stemDict || !this.pullRequests) {
       throw new Error("AnalysisEngine not initialized. Call init() first.");
     }
 
     // Paginated CSM
-    if (perPage) {
+    if (commitCountPerPage) {
       const csmDict = buildPaginatedCSMDict(
         this.commitDict,
         this.stemDict,
         this.baseBranchName,
-        perPage,
+        commitCountPerPage,
         lastCommitId,
         this.pullRequests
       );
       const list = csmDict[this.baseBranchName] ?? [];
       const lastNode = list.length > 0 ? list[list.length - 1] : undefined;
 
-      const isLastPage = list.length < perPage;
+      const isLastPage = list.length < commitCountPerPage;
       const nextCommitId = !isLastPage && lastNode ? lastNode.base.commit.id : undefined;
 
       return {

packages/view/src/App.tsx

@@ -12,7 +12,7 @@ import { RefreshButton } from "components/RefreshButton";
 import type { IDESentEvents } from "types/IDESentEvents";
 import { useBranchStore, useDataStore, useGithubInfo, useLoadingStore, useThemeStore } from "store";
 import { THEME_INFO } from "components/ThemeSelector/ThemeSelector.const";
-import { PER_PAGE } from "constants/constants";
+import { COMMIT_COUNT_PER_PAGE } from "constants/constants";
 
 const App = () => {
   const initRef = useRef<boolean>(false);
@@ -38,7 +38,7 @@ const App = () => {
       };
       setLoading(true);
       ideAdapter.addIDESentEventListener(callbacks);
-      ideAdapter.sendFetchAnalyzedDataMessage({ perPage: PER_PAGE });
+      ideAdapter.sendFetchAnalyzedDataMessage({ commitCountPerPage: COMMIT_COUNT_PER_PAGE });
       ideAdapter.sendFetchBranchListMessage();
       ideAdapter.sendFetchGithubInfo();
       initRef.current = true;
@@ -50,7 +50,7 @@ const App = () => {
 
     setLoading(true);
     ideAdapter.sendFetchAnalyzedDataMessage({
-      perPage: PER_PAGE,
+      commitCountPerPage: COMMIT_COUNT_PER_PAGE,
       lastCommitId: nextCommitId,
     });
   };

packages/view/src/components/BranchSelector/BranchSelector.tsx

@@ -8,7 +8,7 @@ import "./BranchSelector.scss";
 import { useBranchStore, useLoadingStore } from "store";
 
 import { SLICE_LENGTH } from "./BranchSelector.const";
-import { PER_PAGE } from "constants/constants";
+import { COMMIT_COUNT_PER_PAGE } from "constants/constants";
 
 const BranchSelector = () => {
   const { branchList, selectedBranch, setSelectedBranch } = useBranchStore();
@@ -17,7 +17,7 @@ const BranchSelector = () => {
   const handleChangeSelect = (event: SelectChangeEvent) => {
     setSelectedBranch(event.target.value);
     setLoading(true);
-    sendFetchAnalyzedDataCommand({ baseBranch: event.target.value, perPage: PER_PAGE });
+    sendFetchAnalyzedDataCommand({ baseBranch: event.target.value, commitCountPerPage: COMMIT_COUNT_PER_PAGE });
   };
 
   return (

packages/view/src/components/RefreshButton/RefreshButton.tsx

@@ -7,15 +7,15 @@ import { throttle } from "utils";
 import "./RefreshButton.scss";
 import { sendRefreshDataCommand } from "services";
 import { useBranchStore, useLoadingStore } from "store";
-import { PER_PAGE } from "constants/constants";
+import { COMMIT_COUNT_PER_PAGE } from "constants/constants";
 
 const RefreshButton = () => {
   const { selectedBranch } = useBranchStore();
   const { loading, setLoading } = useLoadingStore();
 
   const refreshHandler = throttle(() => {
     setLoading(true);
-    sendRefreshDataCommand({ selectedBranch, perPage: PER_PAGE });
+    sendRefreshDataCommand({ selectedBranch, commitCountPerPage: COMMIT_COUNT_PER_PAGE });
   }, 3000);
 
   return (

packages/view/src/constants/constants.tsx

@@ -2,4 +2,4 @@ export const GITHUB_URL = "https://github.com";
 export const GRAVATA_URL = "https://www.gravatar.com/avatar";
 export const PRIMARY_COLOR_VARIABLE_NAME = "--color-primary";
 export const NODE_TYPES = ["COMMIT", "CLUSTER"] as const;
-export const PER_PAGE = 10;
+export const COMMIT_COUNT_PER_PAGE = 10;

packages/view/src/types/IDEMessage.ts

@@ -17,12 +17,12 @@ export type IDEMessageCommandNames =
 
 export type RefreshDataRequestPayload = {
   selectedBranch?: string;
-  perPage?: number;
+  commitCountPerPage?: number;
   lastCommitId?: string;
 };
 
 export type FetchDataRequestPayload = {
   baseBranch?: string;
-  perPage?: number;
+  commitCountPerPage?: number;
   lastCommitId?: string;
 };

packages/vscode/src/extension.ts

@@ -79,7 +79,7 @@ export async function activate(context: vscode.ExtensionContext) {
 
       const fetchClusterNodes = async (
         baseBranchName = initialBaseBranchName,
-        perPage?: number,
+        commitCountPerPage?: number,
         lastCommitId?: string,
         command?: string
       ): Promise<ClusterNodesResult> => {
@@ -103,7 +103,7 @@ export async function activate(context: vscode.ExtensionContext) {
           throw new Error("Analysis engine is not initialized.");
         }
 
-        const analysisResult = await engine.analyzeGit(perPage, lastCommitId);
+        const analysisResult = await engine.analyzeGit(commitCountPerPage, lastCommitId);
 
         if (analysisResult.isPRSuccess) console.log("crawling PR Success");
 

packages/vscode/src/webview-loader.ts

@@ -2,7 +2,7 @@ import * as path from "path";
 import * as vscode from "vscode";
 
 import { getTheme, setTheme } from "./setting-repository";
-import type { ClusterNode, ClusterNodesResult } from "./types/Node";
+import type { ClusterNodesResult } from "./types/Node";
 
 const ANALYZE_DATA_KEY = "memento_analyzed_data";
 
@@ -36,10 +36,10 @@ export default class WebviewLoader implements vscode.Disposable {
 
         if (command === "refresh") {
           const requestPayload = payload ? JSON.parse(payload) : {};
-          const { selectedBranch, perPage, lastCommitId } = requestPayload;
+          const { selectedBranch, commitCountPerPage, lastCommitId } = requestPayload;
           const currentBranch = selectedBranch ?? (await fetchCurrentBranch());
 
-          const clusterData = await fetchClusterNodes(currentBranch, perPage, lastCommitId, "refresh");
+          const clusterData = await fetchClusterNodes(currentBranch, commitCountPerPage, lastCommitId, "refresh");
           analyzedData = {
             ...clusterData,
             isLoadMore: !!lastCommitId,
@@ -53,7 +53,7 @@ export default class WebviewLoader implements vscode.Disposable {
 
         if (command === "fetchAnalyzedData") {
           const requestPayload = payload ? JSON.parse(payload) : {};
-          const { baseBranch, perPage, lastCommitId } = requestPayload;
+          const { baseBranch, commitCountPerPage, lastCommitId } = requestPayload;
           const currentBranch = baseBranch ?? (await fetchCurrentBranch());
 
           const cacheKey = `${ANALYZE_DATA_KEY}_${currentBranch}_${lastCommitId || "firstPage"}`;
@@ -63,7 +63,7 @@ export default class WebviewLoader implements vscode.Disposable {
           if (storedAnalyzedData) {
             analyzedData = storedAnalyzedData;
           } else {
-            const clusterData = await fetchClusterNodes(currentBranch, perPage, lastCommitId);
+            const clusterData = await fetchClusterNodes(currentBranch, commitCountPerPage, lastCommitId);
             analyzedData = {
               ...clusterData,
               isLoadMore: !!lastCommitId,