Skip to content

Commit f672504

Browse files
singcoclaude
authored andcommitted
♻️ refactor(engine): rename mergedIntoStem to mergedIntoBaseStem for clarity
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 037bd8c commit f672504

4 files changed

Lines changed: 15 additions & 15 deletions

File tree

packages/analysis-engine/src/csm.spec.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,12 @@ describe("csm", () => {
6363
// Set mergedIntoStem flags based on merge structure
6464
// Node 8 (parents=[7, 13]) is merged into master at node 2
6565
// Node 11 (parents=[10, 16]) is merged into master at node 3
66-
fakeCommitNodeDict.get("8")!.mergedIntoStem = "master";
67-
fakeCommitNodeDict.get("11")!.mergedIntoStem = "master";
66+
fakeCommitNodeDict.get("8")!.mergedIntoBaseStem = "master";
67+
fakeCommitNodeDict.get("11")!.mergedIntoBaseStem = "master";
6868
// Node 13 is merged into sub1 at node 8
69-
fakeCommitNodeDict.get("13")!.mergedIntoStem = "sub1";
69+
fakeCommitNodeDict.get("13")!.mergedIntoBaseStem = "sub1";
7070
// Node 16 is merged into sub1 at node 11
71-
fakeCommitNodeDict.get("16")!.mergedIntoStem = "sub1";
71+
fakeCommitNodeDict.get("16")!.mergedIntoBaseStem = "sub1";
7272

7373
describe("buildCSM", () => {
7474
let csmDict: CSMDictionary;
@@ -150,12 +150,12 @@ describe("csm", () => {
150150
// Set mergedIntoStem flags for sub1 as base branch
151151
// Node 8 (parents=[7, 13]) is merged into sub1 at itself
152152
// Node 11 (parents=[10, 16]) is merged into sub1 at itself
153-
fakeCommitNodeDictWithSub1.get("8")!.mergedIntoStem = "sub1";
154-
fakeCommitNodeDictWithSub1.get("11")!.mergedIntoStem = "sub1";
153+
fakeCommitNodeDictWithSub1.get("8")!.mergedIntoBaseStem = "sub1";
154+
fakeCommitNodeDictWithSub1.get("11")!.mergedIntoBaseStem = "sub1";
155155
// Node 13 is merged into sub1 at node 8
156-
fakeCommitNodeDictWithSub1.get("13")!.mergedIntoStem = "sub1";
156+
fakeCommitNodeDictWithSub1.get("13")!.mergedIntoBaseStem = "sub1";
157157
// Node 16 is merged into sub1 at node 11
158-
fakeCommitNodeDictWithSub1.get("16")!.mergedIntoStem = "sub1";
158+
fakeCommitNodeDictWithSub1.get("16")!.mergedIntoBaseStem = "sub1";
159159

160160
beforeAll(() => {
161161
csmDict = buildCSMDict(fakeCommitNodeDictWithSub1, fakeStemDictWithSub1, "sub1");
@@ -253,9 +253,9 @@ describe("csm", () => {
253253
);
254254

255255
// Set mergedIntoStem flags
256-
octopusCommitNodeDict.get("3")!.mergedIntoStem = "master";
257-
octopusCommitNodeDict.get("5")!.mergedIntoStem = "master";
258-
octopusCommitNodeDict.get("7")!.mergedIntoStem = "master";
256+
octopusCommitNodeDict.get("3")!.mergedIntoBaseStem = "master";
257+
octopusCommitNodeDict.get("5")!.mergedIntoBaseStem = "master";
258+
octopusCommitNodeDict.get("7")!.mergedIntoBaseStem = "master";
259259

260260
it("should handle octopus merge with 4 parents", () => {
261261
const csmDict = buildCSMDict(octopusCommitNodeDict, octopusStemDict, "master");
@@ -379,7 +379,7 @@ describe("csm", () => {
379379
new Map<string, CommitNode>()
380380
);
381381

382-
edgeCaseCommitNodeDict.get("2")!.mergedIntoStem = "master";
382+
edgeCaseCommitNodeDict.get("2")!.mergedIntoBaseStem = "master";
383383

384384
it("should filter out non-existent parent commits", () => {
385385
const csmDict = buildCSMDict(edgeCaseCommitNodeDict, edgeCaseStemDict, "master");

packages/analysis-engine/src/csm.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const buildCSMNode = (baseCommitNode: CommitNode, commitDict: CommitDict, stemDi
5050
// First, find the end index (before next mergedIntoStem or end of stem)
5151
let endIndex = squashStem.nodes.length - 1;
5252
for (let i = squashStartNodeIndex + 1; i < squashStem.nodes.length; i++) {
53-
if (squashStem.nodes[i].mergedIntoStem) {
53+
if (squashStem.nodes[i].mergedIntoBaseStem) {
5454
endIndex = i - 1;
5555
break;
5656
}

packages/analysis-engine/src/stem.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export function getStemNodes(
1919
if (idx === 0) return;
2020
const parentNode = commitDict.get(parent);
2121
if (parentNode) {
22-
parentNode.mergedIntoStem = stemId;
22+
parentNode.mergedIntoBaseStem = stemId;
2323
q.push(parentNode);
2424
}
2525
}, q);

packages/analysis-engine/src/types/CommitNode.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export interface CommitNode {
44
// stemId does not exist before traversal.
55
stemId?: string;
66
// ID of the stem this node was merged into (for merge parents)
7-
mergedIntoStem?: string;
7+
mergedIntoBaseStem?: string;
88
commit: CommitRaw;
99
}
1010

0 commit comments

Comments
 (0)