+ "details": "## Summary\n\nWhen an SSO-authenticated user tests an automation in the Budibase builder, their OAuth2 access token and refresh token are included in the automation test results. These results are broadcast via WebSocket to all builders connected to the same dev app and stored in an in-memory cache accessible to any builder who polls the test status endpoint. This allows any co-builder of the same app to steal the testing user's OAuth2 tokens.\n\n## Details\n\nThe vulnerability exists because `getUserContextBindings()` intentionally includes OAuth2 tokens in user context bindings (so automations can call external APIs), but the automation test pipeline exposes the full result — including these tokens — to all builders of the same app without sanitization.\n\n**Step 1: Tokens included in user bindings**\n\nIn `packages/server/src/sdk/users/utils.ts:134-161`:\n```typescript\nexport function getUserContextBindings(user: ContextUser): UserBindings {\n const bindings: UserBindings = {\n _id: user._id,\n email: user.email,\n // ...\n }\n if (isSSOUser(user) && user.oauth2) {\n bindings.oauth2 = {\n accessToken: user.oauth2.accessToken, // <-- sensitive\n refreshToken: user.oauth2.refreshToken, // <-- sensitive\n }\n }\n return bindings\n}\n```\n\n**Step 2: Bindings passed to automation execution**\n\nIn `packages/server/src/api/controllers/automation.ts:311-312`:\n```typescript\nconst user = sdk.users.getUserContextBindings(ctx.user)\nreturn await triggers.externalTrigger(\n { ...automation, disabled: false },\n { ...input, appId, user }, // user with tokens passed as event param\n { getResponses: true, onProgress: emitProgress }\n)\n```\n\n**Step 3: Tokens placed in trigger outputs**\n\nIn `packages/server/src/threads/automation.ts:409-413`:\n```typescript\nconst trigger: AutomationTriggerResult = {\n id: data.automation.definition.trigger.id,\n stepId: data.automation.definition.trigger.stepId,\n inputs: null,\n outputs: data.event, // data.event includes user.oauth2 tokens\n}\n```\n\n**Step 4: Result broadcast without sanitization**\n\nThe full result (including `trigger.outputs.user.oauth2`) is exposed via two vectors:\n\n1. **WebSocket broadcast** — `builderSocket.emitToRoom()` calls `this.io.in(room).emit()` (`packages/server/src/websockets/websocket.ts:291`) which sends to ALL sockets in the app's room, not just the originator.\n\n2. **Test status endpoint** — `recordTestProgress()` stores the result in a Map keyed by `${appId}:${automationId}` with no user isolation (`packages/server/src/automations/testProgress.ts:41-74`). Any builder can call `GET /api/automations/:id/test/status` to retrieve another user's test results.\n\n## PoC\n\nRequires two builder-level users on the same Budibase app, where User A authenticates via SSO/OIDC (Google, Azure AD, etc.) which provides OAuth2 tokens.\n\n```bash\n# Step 1: User A (SSO-authenticated builder) tests an automation asynchronously\ncurl -X POST http://localhost:10000/api/automations/<automation-id>/test?async=true \\\n -H 'x-budibase-app-id: app_dev_<appid>' \\\n -H 'Cookie: budibase:auth=<userA_session>' \\\n -H 'Content-Type: application/json' \\\n -d '{\"row\": {\"tableId\": \"ta_xxx\"}}'\n# Returns: {\"message\": \"Automation test started\"}\n\n# Step 2: User B (another builder on the same app) polls the test status\ncurl -X GET http://localhost:10000/api/automations/<automation-id>/test/status \\\n -H 'x-budibase-app-id: app_dev_<appid>' \\\n -H 'Cookie: budibase:auth=<userB_session>'\n\n# Response includes the full automation result with:\n# result.trigger.outputs.user.oauth2.accessToken = \"ya29.a0AfH6SM...\"\n# result.trigger.outputs.user.oauth2.refreshToken = \"1//0eXyz...\"\n```\n\nAdditionally, User B can passively receive the tokens by simply having the Budibase builder open (connected via WebSocket), as the `BuilderSocketEvent.AutomationTestProgress` event with `status: \"complete\"` includes the full result payload.\n\n## Impact\n\n- **OAuth2 access tokens** for external services (Google Workspace, Azure AD, GitHub, etc.) are exposed to co-builders of the same app. These tokens can be used to access external APIs as the victim user.\n- **OAuth2 refresh tokens** provide persistent access — an attacker can generate new access tokens even after the original expires, maintaining long-term access to the victim's external service accounts.\n- The attack is passive via WebSocket — an attacker only needs to have the builder UI open to receive tokens when any co-builder tests an automation.\n- Test results persist in memory for 5 minutes (TTL in `testProgress.ts:15`), providing a window for polling-based attacks.\n\n## Recommended Fix\n\nStrip OAuth2 tokens from automation test results before storing/broadcasting them. The tokens are needed during automation execution but should not be included in the result sent to clients.\n\nIn `packages/server/src/api/controllers/automation.ts`, sanitize the result before passing to `emitProgress`:\n\n```typescript\nfunction sanitizeAutomationResult(result: AutomationResults): AutomationResults {\n const sanitized = cloneDeep(result)\n if (sanitized.trigger?.outputs?.user?.oauth2) {\n delete sanitized.trigger.outputs.user.oauth2\n }\n for (const step of sanitized.steps || []) {\n if (step.outputs?.user?.oauth2) {\n delete step.outputs.user.oauth2\n }\n }\n return sanitized\n}\n```\n\nApply sanitization in the `emitProgress` callback at line 290 and before returning `ctx.body` at line 342:\n\n```typescript\nemitProgress({\n status: \"complete\",\n occurredAt: Date.now(),\n result: sanitizeAutomationResult(result),\n})\n```\n\nAdditionally, the `testProgress` store should be scoped per-user (keyed by `${appId}:${automationId}:${userId}`) so that one builder's test results are not accessible to another builder via the `testStatus` endpoint.",
![advisory-database[bot]](https://avatars.githubusercontent.com/in/21409?v=4&size=40){kind=avatar}
0 commit comments