+ "details": "# Stale Admin Role in Socket.IO Session Pool Enables Post-Demotion Cross-User Note Access\n\n## Affected Component\n\nSocket.IO session state and role-check callsites:\n- `backend/open_webui/socket/main.py` (lines 330-351, `connect` handler — role snapshotted into SESSION_POOL)\n- `backend/open_webui/socket/main.py` (lines 393-398, `heartbeat` handler — does not refresh role)\n- `backend/open_webui/socket/main.py` (line 538, `ydoc:document:join` — uses cached role for admin check)\n- `backend/open_webui/socket/main.py` (line 611, `document_save_handler` — uses cached role for admin check)\n- `backend/open_webui/routers/users.py` (lines 557-633, role update — does not invalidate SESSION_POOL)\n- `backend/open_webui/routers/users.py` (line 641, user delete — does not invalidate SESSION_POOL)\n\n## Affected Versions\n\nCurrent main branch (commit `6fdd19bf1`) and likely all versions with the collaborative document (Yjs) Socket.IO handlers.\n\n## Description\n\nWhen a user connects via Socket.IO, the `connect` handler authenticates them via JWT and stores their user record (including `role`) in the in-memory `SESSION_POOL` dictionary keyed by session ID. The `heartbeat` handler keeps the session alive indefinitely but only refreshes the `last_seen_at` timestamp — never the role.\n\nRole checks in the Yjs collaborative document handlers (`ydoc:document:join`, `document_save_handler`) consult the cached `SESSION_POOL` role rather than the database. Meanwhile, administrative role changes and user deletions do not iterate `SESSION_POOL` to disconnect affected sessions. As a result, a user whose admin role has been revoked retains admin privileges within their existing Socket.IO session for as long as they keep the connection alive (via automatic heartbeats).\n\nHTTP endpoints are not affected — `get_current_user` at [utils/auth.py](backend/open_webui/utils/auth.py) refetches the user record from the database on every request. The gap is exclusive to the Socket.IO session cache.\n\n```python\n# socket/main.py:330-351 — role snapshotted at connect time\nasync def connect(sid, environ, auth):\n user = None\n if auth and 'token' in auth:\n data = decode_token(auth['token'])\n if data is not None and 'id' in data:\n user = Users.get_user_by_id(data['id'])\n if user:\n SESSION_POOL[sid] = {\n 'id': user.id,\n 'role': user.role, # ← snapshotted, never refreshed\n ...\n }\n\n# socket/main.py:393-398 — heartbeat refreshes last_seen_at only\nasync def heartbeat(sid, data):\n user = SESSION_POOL.get(sid)\n if user:\n SESSION_POOL[sid] = {**user, 'last_seen_at': int(time.time())}\n # role is carried forward unchanged\n\n# socket/main.py:538 — admin check against cached role\nif user.get('role') != 'admin' and not has_access(user_id, 'note', note_id, 'read', db=db):\n return\n```\n\n## Attack Scenario\n\n1. User B is an admin and has an active browser session with a live Socket.IO connection. `SESSION_POOL[sid]` records `role='admin'`.\n2. Admin A demotes User B to a regular user via `POST /api/v1/users/{B_id}/update`. The DB `user.role` becomes `'user'`.\n3. No Socket.IO disconnect, no SESSION_POOL update, no token revocation event is triggered by the role change.\n4. User B's client continues sending `heartbeat` events every few seconds; these are accepted and only refresh `last_seen_at`.\n5. User B emits `ydoc:document:join` with `document_id = 'note:<victim_note_id>'` for any note they do not own.\n6. The handler at line 538 evaluates `user.get('role') != 'admin'` — returns `False` because `SESSION_POOL` still holds the stale `admin` role. Access check is bypassed, User B joins the document room, receives full document state and live updates.\n7. User B emits `ydoc:document:update` for the same note. The handler at line 611 performs the same cached-admin check, bypasses authorization, and persists attacker-controlled content to the victim's note via `Notes.update_note_by_id`.\n\nThe same bypass occurs if the user is deleted entirely (`delete_user_by_id`) — the deleted user retains admin privileges on their live socket until disconnection.\n\n## Impact\n\n- Read access to any user's notes after admin privileges have been revoked\n- Write access (content injection, overwrite) to any user's notes under the same conditions\n- The stale privilege is bounded only by the attacker's willingness to keep the Socket.IO connection alive; heartbeats extend the session indefinitely\n- Official admin demotion or user deletion gives a false sense of security — HTTP access is correctly revoked, but real-time collaborative access silently continues\n\n## Preconditions\n\n- Attacker must have an active Socket.IO connection established while they held admin role\n- Attacker must retain the Socket.IO session after demotion/deletion (trivial — just don't close the browser)",
![advisory-database[bot]](https://avatars.githubusercontent.com/in/21409?v=4&size=40){kind=avatar}
0 commit comments