Merge pull request #142 from github/no-ci-check-fixes

CI Status Check Fixes

Author: GrantBirki

.github/workflows/actions-config-validation.yml

@@ -14,10 +14,10 @@ jobs:
   actions-config-validation:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3.5.0
+      - uses: actions/checkout@v3
 
       - name: actions-config-validation
-        uses: GrantBirki/json-yaml-validate@78e22e5c6549059f267f96aea1aaf97132896c04 # [email protected].0
+        uses: GrantBirki/json-yaml-validate@9a228501b1e80369c582764187fbefdc2f7fbac1 # [email protected].1
         with:
           comment: "true" # enable comment mode
           yaml_schema: "__tests__/schemas/action.schema.yml"

.github/workflows/codeql-analysis.yml

@@ -26,7 +26,7 @@ jobs:
 
     steps:
     - name: checkout
-      uses: actions/checkout@v3.5.0
+      uses: actions/checkout@v3
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL

.github/workflows/lint.yml

@@ -13,19 +13,12 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/[email protected]
-
-      # check the node version from the .node-version file
-      - name: fetch node version
-        id: node-version
-        run: |
-          version=$(cat .node-version)
-          echo "version=${version}" >> $GITHUB_OUTPUT
+      - uses: actions/checkout@v3
 
       - name: setup node
         uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # [email protected]
         with:
-          node-version: ${{ steps.node-version.outputs.version }}
+          node-version-file: .node-version
           cache: 'npm'
 
       - name: install dependencies

.github/workflows/package-check.yml

@@ -12,28 +12,21 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/[email protected]
-
-      # check the node version from the .node-version file
-      - name: fetch node version
-        id: node-version
-        run: |
-          version=$(cat .node-version)
-          echo "version=${version}" >> $GITHUB_OUTPUT
+      - uses: actions/checkout@v3
 
       - name: setup node
         uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # [email protected]
         with:
-          node-version: ${{ steps.node-version.outputs.version }}
+          node-version-file: .node-version
           cache: 'npm'
 
       - name: install dependencies
         run: npm ci
 
-      - name: Rebuild the dist/ directory
+      - name: rebuild the dist/ directory
         run: npm run bundle
 
-      - name: Compare the expected and actual dist/ directories
+      - name: compare the expected and actual dist/ directories
         run: |
           if [ "$(git diff --ignore-space-at-eol dist/ | wc -l)" -gt "0" ]; then
             echo "Detected uncommitted changes after build.  See status below:"

.github/workflows/test.yml

@@ -13,19 +13,12 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/[email protected]
-
-      # check the node version from the .node-version file
-      - name: fetch node version
-        id: node-version
-        run: |
-          version=$(cat .node-version)
-          echo "version=${version}" >> $GITHUB_OUTPUT
+      - uses: actions/checkout@v3
 
       - name: setup node
         uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # [email protected]
         with:
-          node-version: ${{ steps.node-version.outputs.version }}
+          node-version-file: .node-version
           cache: 'npm'
 
       - name: install dependencies

__tests__/functions/prechecks.test.js

@@ -215,8 +215,11 @@ test('runs prechecks and finds that the IssueOps command is valid without define
     )
   ).toStrictEqual({
     message:
-      '### ⚠️ Cannot proceed with deployment\n\n- reviewDecision: `APPROVED`\n- commitStatus: `null`\n\n> This is usually caused by missing PR approvals or CI checks failing',
-    status: false
+      '✔️ CI checks have not been defined but the PR has been approved - OK',
+    status: true,
+    noopMode: false,
+    ref: 'test-ref',
+    sha: 'abc123'
   })
   expect(infoMock).toHaveBeenCalledWith(
     "Could not retrieve PR commit status: TypeError: Cannot read properties of undefined (reading 'nodes') - Handled: OK"
@@ -934,6 +937,39 @@ test('runs prechecks and finds the PR is NOT reviewed and CI checks have NOT bee
   })
 })
 
+test('runs prechecks and finds the PR is approved and CI checks have NOT been defined and NOT a noop deploy', async () => {
+  octokit.graphql = jest.fn().mockReturnValue({
+    repository: {
+      pullRequest: {
+        reviewDecision: 'APPROVED'
+      }
+    }
+  })
+  expect(
+    await prechecks(
+      '.deploy',
+      '.deploy',
+      'noop',
+      'disabled',
+      'main',
+      '123',
+      true,
+      '',
+      '',
+      'production',
+      context,
+      octokit
+    )
+  ).toStrictEqual({
+    message:
+      '✔️ CI checks have not been defined but the PR has been approved - OK',
+    status: true,
+    noopMode: false,
+    ref: 'test-ref',
+    sha: 'abc123'
+  })
+})
+
 test('runs prechecks and finds the PR is behind the stable branch and a noop deploy and force updates the branch', async () => {
   octokit.graphql = jest.fn().mockReturnValue({
     repository: {