Skip to content

Commit a6f4541

Browse files
authored
Merge pull request #346 from github/commit-verification-text-update
Improve commit verification failure text
2 parents 1c7b2cc + 6a4ed7b commit a6f4541

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

__tests__/functions/commit-safety-checks.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ test('checks a commit and finds that it is not safe (verification time) even tho
143143
}
144144

145145
expect(await commitSafetyChecks(context, data)).toStrictEqual({
146-
message: `### ⚠️ Cannot proceed with deployment\n\nThe latest commit is not safe for deployment. The commit signature was verified after the trigger comment was created.`,
146+
message: `### ⚠️ Cannot proceed with deployment\n\nThe latest commit is not safe for deployment. The commit signature was verified after the trigger comment was created. Please try again if you recently pushed a new commit.`,
147147
status: false,
148148
isVerified: true
149149
})

dist/index.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/functions/commit-safety-checks.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export async function commitSafetyChecks(context, data) {
5959
isTimestampOlder(comment_created_at, commit?.verification?.verified_at)
6060
) {
6161
return {
62-
message: `### ⚠️ Cannot proceed with deployment\n\nThe latest commit is not safe for deployment. The commit signature was verified after the trigger comment was created.`,
62+
message: `### ⚠️ Cannot proceed with deployment\n\nThe latest commit is not safe for deployment. The commit signature was verified after the trigger comment was created. Please try again if you recently pushed a new commit.`,
6363
status: false,
6464
isVerified: isVerified
6565
}

0 commit comments

Comments
 (0)