Skip to content

Commit 8f1212f

Browse files
committed
Revert src/config-utils.ts
These hunks were related to another hunk elsewhere, that has since now been reverted in favor of a separate/distinct PR.
1 parent d4b99ad commit 8f1212f

2 files changed

Lines changed: 12 additions & 8 deletions

File tree

src/config-utils.test.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -878,7 +878,7 @@ const mockRepositoryNwo = parseRepositoryNwo("owner/repo");
878878
extractor_root: "",
879879
};
880880
const codeQL = createStubCodeQL({
881-
resolveLanguages: () =>
881+
resolveLanguages: (options) =>
882882
Promise.resolve({
883883
aliases: {
884884
"c#": BuiltInLanguage.csharp,
@@ -892,9 +892,11 @@ const mockRepositoryNwo = parseRepositoryNwo("owner/repo");
892892
java: [stubExtractorEntry],
893893
javascript: [stubExtractorEntry],
894894
python: [stubExtractorEntry],
895-
// `html` is an extractor without default queries. It should be
896-
// excluded from the supported language map.
897-
html: [stubExtractorEntry],
895+
...(options?.filterToLanguagesWithQueries
896+
? {}
897+
: {
898+
html: [stubExtractorEntry],
899+
}),
898900
},
899901
}),
900902
});

src/config-utils.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,9 @@ async function getSupportedLanguageMap(
134134
const resolveSupportedLanguagesUsingCli = await codeql.supportsFeature(
135135
ToolsFeature.BuiltinExtractorsSpecifyDefaultQueries,
136136
);
137-
const resolveResult = await codeql.resolveLanguages();
137+
const resolveResult = await codeql.resolveLanguages({
138+
filterToLanguagesWithQueries: resolveSupportedLanguagesUsingCli,
139+
});
138140
if (resolveSupportedLanguagesUsingCli) {
139141
logger.debug(
140142
`The CodeQL CLI supports the following languages: ${Object.keys(resolveResult.extractors).join(", ")}`,
@@ -143,9 +145,9 @@ async function getSupportedLanguageMap(
143145
const supportedLanguages: Record<string, string> = {};
144146
// Populate canonical language names
145147
for (const extractor of Object.keys(resolveResult.extractors)) {
146-
// TODO: Delete this `if` condition once CODEQL_MINIMUM_VERSION
147-
// is at least v2.23.0 — the first version to support the
148-
// BuiltinExtractorsSpecifyDefaultQueries feature.
148+
// If the CLI supports resolving languages with default queries, use these
149+
// as the set of supported languages. Otherwise, require the language to be
150+
// a built-in language.
149151
if (
150152
resolveSupportedLanguagesUsingCli ||
151153
BuiltInLanguage[extractor] !== undefined

0 commit comments

Comments
 (0)