Skip to content

Failure doesn't show as failure #2691

Open
@TWiStErRob

Description

@TWiStErRob

We have a step that uses upload-sarif. It ran on merge_group: but failed because the merge queue item was removed from the queue. This resulted in the following error message (which seems normal, branch is deleted by removal from queue):

Image

Notice that somehow the step is still shown as successful, and yet the step failed because the next step had a condition to run if it failed. I'm wondering if there's something missing from the upload-sarif to make the "Publish" step red cross too, or this is maybe a GHA UI glitch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions