Commit 8c89f0e
committed
actions: drop lockfile-extension generator from unpinned-tag PR
Removes the Go lockfile-extension-generator tool and its extractor autobuild
hook, keeping this PR to its intended discussion scope: the $/ self-repository
suppression plus the QL seam (pinnedByLockfileDataModel extensible predicate and
the not pinnedByLockfile(...) clause).
Parsing actions.lock and populating the predicate is extractor-team work on the
CodeQL CLI cycle, and the tool here reimplemented the canonical parser at
github.com/github/actions-lockfile rather than depending on it, so it would
drift. It also wrote a model pack into the database that CodeQL does not
auto-apply, so it never took effect without extra analysis flags. Better to
scaffold the seam and let the extractor own population.
Reverts the additions to actions/extractor/tools/autobuild.sh and deletes
actions/extractor/tools/generate-lockfile-extension.sh and
actions/extractor/tools/lockfile-extension-generator/. Query behavior and test
expected output are unchanged; the CWE-829 query tests still pass.1 parent 9a0eef7 commit 8c89f0e
16 files changed
Lines changed: 4 additions & 806 deletions
File tree
- actions
- extractor/tools
- lockfile-extension-generator
- testdata
- ql
- src/Security/CWE-829
- test/query-tests/Security/CWE-829
- .github/workflows
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | 40 | | |
46 | 41 | | |
47 | 42 | | |
| |||
60 | 55 | | |
61 | 56 | | |
62 | 57 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
This file was deleted.
Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 0 additions & 120 deletions
This file was deleted.
Lines changed: 0 additions & 130 deletions
This file was deleted.
0 commit comments