Added firebase as MaD

Author: Napalys

javascript/ql/lib/ext/firebase.model.yml

@@ -0,0 +1,20 @@
+extensions:
+  - addsTo:
+      pack: codeql/javascript-all
+      extensible: typeModel
+    data:
+      - ["FirebaseDBRef", "firebase/app", "Member[database].ReturnValue.Member[ref,refFromURL].ReturnValue"]
+      - ["FirebaseDBRef", "FirebaseDBRef", "Member[once,on].Argument[1].Parameter[0]"]
+      - ["FirebaseDBRef", "FirebaseDBRef", "Member[once,on].ReturnValue.Member[then].Argument[0].Parameter[0]"]
+      - ["FirebaseDBRef", "FirebaseDBRef", "Member[ref,root,parent,before,after]"]
+      - ["FirebaseDBRef", "FirebaseDBRef", "Member[child].ReturnValue"]
+
+      - ["FirebaseDBRef", "firebase-functions", "Member[database].Member[ref,refFromURL].ReturnValue"]
+      - ["FirebaseDBRef", "FirebaseDBRef", "Member[onCreate,onUpdate].Argument[0].Parameter[0]"]
+  - addsTo:
+      pack: codeql/javascript-all
+      extensible: sourceModel
+    data:
+      - ["FirebaseDBRef", "Member[val,exportVal].ReturnValue", 'remote']
+      - ["FirebaseDBRef", "Member[forEach].Argument[0].Parameter[0].Member[val,exportVal].ReturnValue", 'remote']
+  

javascript/ql/lib/semmle/javascript/frameworks/Firebase.qll

@@ -282,20 +282,18 @@ module Firebase {
    * `firebase.database().ref().on('value', x => {...})`.
    */
   DataFlow::SourceNode snapshot() { result = snapshot(DataFlow::TypeTracker::end()) }
-
-  /**
-   * A reference to a value obtained from a Firebase database.
-   */
-  class FirebaseVal extends RemoteFlowSource {
-    FirebaseVal() {
-      exists(string name | this = snapshot().getAMethodCall(name) |
-        name = "val" or
-        name = "exportVal"
-      )
-      or
-      this = Database::transactionCallback().(DataFlow::FunctionNode).getParameter(0)
-    }
-
-    override string getSourceType() { result = "Firebase database" }
-  }
+  // /**
+  //  * A reference to a value obtained from a Firebase database.
+  //  */
+  // deprecated class FirebaseVal extends RemoteFlowSource {
+  //   FirebaseVal() {
+  //     exists(string name | this = snapshot().getAMethodCall(name) |
+  //       name = "val" or
+  //       name = "exportVal"
+  //     )
+  //     or
+  //     this = Database::transactionCallback().(DataFlow::FunctionNode).getParameter(0)
+  //   }
+  //   override string getSourceType() { result = "Firebase database" }
+  // }
 }