Skip to content

Commit 9dc2c28

Browse files
committed
Clarify Windows teardown deadlock
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6e902b9a-5527-4a32-a5a3-e0bf5bfef3f7
1 parent 5e60dad commit 9dc2c28

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

nodejs/test/e2e/harness/sdkTestContext.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -293,8 +293,10 @@ export async function createSdkTestContext({
293293
afterAll(async () => {
294294
await copilotClient.stop();
295295
await openAiEndpoint.stop(anyTestFailed);
296-
// On Windows, the in-process runtime can keep session.db locked until this
297-
// Vitest worker exits. Retrying here prevents that exit and deadlocks teardown.
296+
// On Windows, this Vitest worker can retain the in-process runtime's session.db
297+
// lock until the worker exits. Retrying from its afterAll hook cannot succeed:
298+
// the hook waits for the lock, while the lock cannot clear until the hook returns
299+
// and lets the worker exit.
298300
await rmDir(
299301
"remove e2e test copilotHomeDir",
300302
copilotHomeDir,

0 commit comments

Comments
 (0)