Commit c34785f
Update @github/copilot to 1.0.56 (#1504)
* Update @github/copilot to 1.0.56
- Updated nodejs and test harness dependencies
- Re-ran code generators
- Formatted generated code
* test: cover pending external tool resume in both warm and cold modes
Runtime 1.0.56 changed disconnect semantics so that ForceStop of the
last RPC owner now triggers session cleanup. The previous
warm-only test for `Should_Keep_Pending_External_Tool_Handleable_On_*_Resume_When_ContinuePendingWork_Is_False`
asserted SessionWasActive == true and that `handlePendingToolCall`
fed a result into the assistant reply -- assumptions that only hold for
warm resume. On cold resume the runtime intentionally auto-completes
orphan tool calls with a synthetic interrupt result, so the SDK call
correctly returns success=false.
Split that test into two scenarios across Node, Go, .NET, and Python:
- Warm (original client stays connected): SessionWasActive=true,
handlePendingToolCall returns success=true, and the assistant echoes
the supplied result.
- Cold (original client ForceStopped before resume): SessionWasActive=false,
handlePendingToolCall returns success=false, and a follow-up turn
confirms the resumed session is still healthy.
In warm mode the resumed client must not re-register the external tool
(it would clash with the original owner); in cold mode it re-registers
with a throwing handler to assert the runtime does not re-invoke the
handler on resume.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Skip pending-resume tests broken by runtime cold-cleanup contract
Runtime PR #9040 (commit b8e1220b45) made SDKServer.handleConnectionClosed
clean up session state when the last RPC owner disconnects. As a result,
the existing Should_Continue_Pending_{Permission,External_Tool}_Request_
After_Resume tests, which ForceStop the suspended client and then expect
the resumed client to successfully complete the pending request, no longer
pass: HandlePendingPermissionRequest/HandlePendingToolCall return
success=false after the cold cleanup runs.
A runtime-side fix is being tracked separately. Skip these two tests in
all four SDKs (.NET, Go, Node, Python) with a TODO referencing the
runtime contract change so they can be re-enabled once that work lands.
Also drop the GetFinalAssistantMessageAsync continuation assertions from
the .NET and Go warm theory and from the older OLD tests, matching the
Node and Python tests which never made that assertion. The
ContinuePendingWork=false warm path provides no guarantee that the
suspended client's agentic loop will propagate a final assistant.message
to the resumed client, and waiting for one was flaking on Linux .NET CI.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Reword pending-resume skip messages to match actual runtime contract
The previous wording ('Pending runtime fix') implied a runtime change was being tracked separately. That isn't accurate: runtime 1.0.56 (copilot-agent-runtime PR #9040) intentionally cleans up the session when the last RPC client disconnects, and there is no in-flight fix planned.
The OLD tests model same-process ForceStop+resume and rely on the old behavior where the session stayed alive in the runtime process. They need to be redesigned to either keep an owner connected (warm resume) or to model true process-restart resume from persisted session state.
No code change beyond the skip-reason text; tests remain skipped while the redesign is figured out.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent d882812 commit c34785f
15 files changed
Lines changed: 583 additions & 404 deletions
File tree
- dotnet
- src/Generated
- test/E2E
- go
- internal/e2e
- rpc
- nodejs
- samples
- src/generated
- test/e2e
- python
- copilot/generated
- e2e
- rust/src/generated
- test
- harness
- snapshots/pending_work_resume
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
23 | 30 | | |
24 | 31 | | |
25 | 32 | | |
26 | 33 | | |
27 | | - | |
28 | 34 | | |
29 | 35 | | |
30 | 36 | | |
| |||
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 75 | + | |
73 | 76 | | |
74 | 77 | | |
75 | 78 | | |
| |||
79 | 82 | | |
80 | 83 | | |
81 | 84 | | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | 85 | | |
88 | 86 | | |
89 | 87 | | |
| |||
97 | 95 | | |
98 | 96 | | |
99 | 97 | | |
100 | | - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
101 | 104 | | |
102 | 105 | | |
103 | 106 | | |
| |||
140 | 143 | | |
141 | 144 | | |
142 | 145 | | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | 146 | | |
148 | 147 | | |
149 | 148 | | |
| |||
161 | 160 | | |
162 | 161 | | |
163 | 162 | | |
164 | | - | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
165 | 180 | | |
166 | 181 | | |
167 | 182 | | |
| |||
191 | 206 | | |
192 | 207 | | |
193 | 208 | | |
194 | | - | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
195 | 213 | | |
196 | 214 | | |
197 | | - | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
198 | 222 | | |
199 | 223 | | |
200 | 224 | | |
201 | | - | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
202 | 232 | | |
203 | 233 | | |
204 | 234 | | |
205 | | - | |
| 235 | + | |
206 | 236 | | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
207 | 242 | | |
208 | 243 | | |
209 | 244 | | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
| 245 | + | |
214 | 246 | | |
215 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
216 | 257 | | |
217 | 258 | | |
218 | 259 | | |
| |||
228 | 269 | | |
229 | 270 | | |
230 | 271 | | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
231 | 276 | | |
232 | 277 | | |
233 | 278 | | |
| |||
0 commit comments