fix(api-proxy): extract validateAnthropicCacheTailTtl for testability; add branch coverage tests

Author: Copilot

src/cli.test.ts

@@ -1,5 +1,5 @@
 import { Command } from 'commander';
-import { parseEnvironmentVariables, parseDomains, parseDomainsFile, escapeShellArg, joinShellArgs, parseVolumeMounts, isValidIPv4, isValidIPv6, parseDnsServers, parseDnsOverHttps, validateAgentImage, isAgentImagePreset, AGENT_IMAGE_PRESETS, processAgentImageOption, processLocalhostKeyword, validateSkipPullWithBuildLocal, validateAllowHostPorts, validateAllowHostServicePorts, applyHostServicePortsConfig, parseMemoryLimit, validateFormat, validateApiProxyConfig, buildRateLimitConfig, validateRateLimitFlags, validateEnableOpenCodeFlag, hasRateLimitOptions, collectRulesetFile, validateApiTargetInAllowedDomains, DEFAULT_OPENAI_API_TARGET, DEFAULT_ANTHROPIC_API_TARGET, DEFAULT_COPILOT_API_TARGET, DEFAULT_GEMINI_API_TARGET, emitApiProxyTargetWarnings, emitCliProxyStatusLogs, warnClassicPATWithCopilotModel, formatItem, program, parseAgentTimeout, applyAgentTimeout, handlePredownloadAction, resolveApiTargetsToAllowedDomains, extractGhesDomainsFromEngineApiTarget, extractGhecDomainsFromServerUrl, checkDockerHost } from './cli';
+import { parseEnvironmentVariables, parseDomains, parseDomainsFile, escapeShellArg, joinShellArgs, parseVolumeMounts, isValidIPv4, isValidIPv6, parseDnsServers, parseDnsOverHttps, validateAgentImage, isAgentImagePreset, AGENT_IMAGE_PRESETS, processAgentImageOption, processLocalhostKeyword, validateSkipPullWithBuildLocal, validateAllowHostPorts, validateAllowHostServicePorts, applyHostServicePortsConfig, parseMemoryLimit, validateFormat, validateApiProxyConfig, buildRateLimitConfig, validateRateLimitFlags, validateEnableOpenCodeFlag, hasRateLimitOptions, collectRulesetFile, validateApiTargetInAllowedDomains, DEFAULT_OPENAI_API_TARGET, DEFAULT_ANTHROPIC_API_TARGET, DEFAULT_COPILOT_API_TARGET, DEFAULT_GEMINI_API_TARGET, emitApiProxyTargetWarnings, emitCliProxyStatusLogs, warnClassicPATWithCopilotModel, formatItem, program, parseAgentTimeout, applyAgentTimeout, handlePredownloadAction, resolveApiTargetsToAllowedDomains, extractGhesDomainsFromEngineApiTarget, extractGhecDomainsFromServerUrl, checkDockerHost, validateAnthropicCacheTailTtl } from './cli';
 import { redactSecrets } from './redact-secrets';
 import * as fs from 'fs';
 import * as path from 'path';
@@ -2456,6 +2456,39 @@ describe('cli', () => {
     });
   });
 
+  describe('validateAnthropicCacheTailTtl', () => {
+    it('should not call process.exit when value is undefined', () => {
+      const mockExit = jest.spyOn(process, 'exit').mockImplementation((() => {}) as any);
+      validateAnthropicCacheTailTtl(undefined);
+      expect(mockExit).not.toHaveBeenCalled();
+      mockExit.mockRestore();
+    });
+
+    it('should not call process.exit for valid value "5m"', () => {
+      const mockExit = jest.spyOn(process, 'exit').mockImplementation((() => {}) as any);
+      validateAnthropicCacheTailTtl('5m');
+      expect(mockExit).not.toHaveBeenCalled();
+      mockExit.mockRestore();
+    });
+
+    it('should not call process.exit for valid value "1h"', () => {
+      const mockExit = jest.spyOn(process, 'exit').mockImplementation((() => {}) as any);
+      validateAnthropicCacheTailTtl('1h');
+      expect(mockExit).not.toHaveBeenCalled();
+      mockExit.mockRestore();
+    });
+
+    it('should call process.exit(1) for an invalid value', () => {
+      const mockExit = jest.spyOn(process, 'exit').mockImplementation((() => {}) as any);
+      const mockError = jest.spyOn(console, 'error').mockImplementation(() => {});
+      validateAnthropicCacheTailTtl('10m');
+      expect(mockError).toHaveBeenCalledWith('Invalid --anthropic-cache-tail-ttl value: "10m". Must be "5m" or "1h".');
+      expect(mockExit).toHaveBeenCalledWith(1);
+      mockError.mockRestore();
+      mockExit.mockRestore();
+    });
+  });
+
   describe('formatItem', () => {
     it('should format term with description when term fits within width', () => {
       const result = formatItem('--flag', 'Description text', 20, 2, 2, 80);

src/cli.ts

@@ -318,6 +318,18 @@ export function validateApiProxyConfig(
   return { enabled: true, warnings, debugMessages };
 }
 
+/**
+ * Validates the value of --anthropic-cache-tail-ttl.
+ * Exits the process with an error if the value is not "5m" or "1h".
+ * @param value - The value provided for --anthropic-cache-tail-ttl (may be undefined)
+ */
+export function validateAnthropicCacheTailTtl(value: string | undefined): void {
+  if (value !== undefined && value !== '5m' && value !== '1h') {
+    console.error(`Invalid --anthropic-cache-tail-ttl value: "${value}". Must be "5m" or "1h".`);
+    process.exit(1);
+  }
+}
+
 /**
  * Validates that a custom API proxy target hostname is covered by the allowed domains list.
  * Returns a warning message if the target domain is not in allowed domains, otherwise null.
@@ -1671,12 +1683,7 @@ program
     }
 
     // Validate --anthropic-cache-tail-ttl if provided
-    if (options.anthropicCacheTailTtl !== undefined &&
-        options.anthropicCacheTailTtl !== '5m' &&
-        options.anthropicCacheTailTtl !== '1h') {
-      console.error(`Invalid --anthropic-cache-tail-ttl value: "${options.anthropicCacheTailTtl}". Must be "5m" or "1h".`);
-      process.exit(1);
-    }
+    validateAnthropicCacheTailTtl(options.anthropicCacheTailTtl);
 
     // Model aliases may be injected via config file (not a Commander option),
     // so access through a Record cast with a proper type annotation.