Skip to content

Commit 3b5cc8d

Browse files
Mossakaclaude
andcommitted
fix: remove leftover SQUID_INTERCEPT_PORT references from revert
The intercept mode revert (#541) missed 3 references to SQUID_INTERCEPT_PORT in docker-manager.ts: the constant definition, the port mapping on the Squid container, and the env var passed to the agent container. Squid no longer listens on port 3129, so these are dead code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent d2236af commit 3b5cc8d

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

src/docker-manager.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { generateSquidConfig } from './squid-config';
99
import { generateSessionCa, initSslDb, CaFiles, parseUrlPatterns } from './ssl-bump';
1010

1111
const SQUID_PORT = 3128;
12-
const SQUID_INTERCEPT_PORT = 3129; // Port for transparently intercepted traffic
1312

1413
/**
1514
* Base image for the 'act' preset when building locally.
@@ -273,7 +272,7 @@ export function generateDockerCompose(
273272
retries: 5,
274273
start_period: '10s',
275274
},
276-
ports: [`${SQUID_PORT}:${SQUID_PORT}`, `${SQUID_INTERCEPT_PORT}:${SQUID_INTERCEPT_PORT}`],
275+
ports: [`${SQUID_PORT}:${SQUID_PORT}`],
277276
// Security hardening: Drop unnecessary capabilities
278277
// Squid only needs network capabilities, not system administration capabilities
279278
cap_drop: [
@@ -329,7 +328,6 @@ export function generateDockerCompose(
329328
HTTPS_PROXY: `http://${networkConfig.squidIp}:${SQUID_PORT}`,
330329
SQUID_PROXY_HOST: 'squid-proxy',
331330
SQUID_PROXY_PORT: SQUID_PORT.toString(),
332-
SQUID_INTERCEPT_PORT: SQUID_INTERCEPT_PORT.toString(),
333331
HOME: homeDir,
334332
PATH: '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',
335333
};

0 commit comments

Comments
 (0)