Skip to content

Commit 4564c0a

Browse files
lpcoxCopilot
andauthored
fix: remove unused exported interfaces from services and pid-tracker (#2715)
- Remove export from NetTcpEntry in src/pid-tracker.ts (internal only) - Remove export from AgentServiceParams, IptablesInitServiceParams in src/services/agent-service.ts - Remove export from AgentVolumesParams in src/services/agent-volumes.ts - Remove export from AgentEnvironmentParams in src/services/agent-environment.ts - Remove re-exports of *Params types from agent-service barrel These interfaces are only used within their own modules and were unnecessarily polluting the public API surface. Closes #2694, closes #2695 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent feddd88 commit 4564c0a

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/pid-tracker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export { PidTrackResult } from './types';
3131
/**
3232
* Parsed entry from /proc/net/tcp
3333
*/
34-
export interface NetTcpEntry {
34+
interface NetTcpEntry {
3535
/** Local IP address in hex format */
3636
localAddressHex: string;
3737
/** Local port number */

src/services/agent-environment.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { NetworkConfig } from './squid-service';
2121

2222
// ─── Agent Environment ────────────────────────────────────────────────────────
2323

24-
export interface AgentEnvironmentParams {
24+
interface AgentEnvironmentParams {
2525
config: WrapperConfig;
2626
networkConfig: NetworkConfig;
2727
dnsServers: string[];

src/services/agent-service.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ import { logger } from '../logger';
1212
import { WrapperConfig } from '../types';
1313
import { NetworkConfig, ImageBuildConfig } from './squid-service';
1414

15-
// Re-export for backwards compatibility
16-
export { AgentEnvironmentParams, buildAgentEnvironment } from './agent-environment';
17-
export { AgentVolumesParams, buildAgentVolumes } from './agent-volumes';
15+
// Re-export functions for backwards compatibility
16+
export { buildAgentEnvironment } from './agent-environment';
17+
export { buildAgentVolumes } from './agent-volumes';
1818

1919
// ─── Agent Service ────────────────────────────────────────────────────────────
2020

21-
export interface AgentServiceParams {
21+
interface AgentServiceParams {
2222
config: WrapperConfig;
2323
networkConfig: NetworkConfig;
2424
environment: Record<string, string>;
@@ -201,7 +201,7 @@ export function buildAgentService(params: AgentServiceParams): any {
201201

202202
// ─── iptables-init Service ────────────────────────────────────────────────────
203203

204-
export interface IptablesInitServiceParams {
204+
interface IptablesInitServiceParams {
205205
agentService: any;
206206
environment: Record<string, string>;
207207
networkConfig: NetworkConfig;

src/services/agent-volumes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { WrapperConfig } from '../types';
77

88
// ─── Agent Volumes ────────────────────────────────────────────────────────────
99

10-
export interface AgentVolumesParams {
10+
interface AgentVolumesParams {
1111
config: WrapperConfig;
1212
sslConfig?: SslConfig;
1313
effectiveHome: string;

0 commit comments

Comments
 (0)