Skip to content

Commit a791df8

Browse files
Copilotlpcox
andauthored
Remove unused export from SslBumpConfig in security-critical module (#2438)
* Initial plan * fix: remove unused export from SslBumpConfig interface in ssl-bump.ts Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/e07586e3-c8a8-4e76-8158-807e9636123d Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: inline SslBumpConfig parameter type to fix declaration emit with non-exported interface Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/d3d6437d-fcec-4fe2-b8a8-fd6939900785 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: remove unused SslBumpConfig interface to fix ESLint no-unused-vars error Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/fe39d17c-0681-4b39-8ef4-af0d69df95fd Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
1 parent 1b19027 commit a791df8

1 file changed

Lines changed: 1 addition & 13 deletions

File tree

src/ssl-bump.ts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,6 @@ export function chownRecursive(dirPath: string, uid: number, gid: number): void
3333
}
3434
}
3535

36-
/**
37-
* Configuration for SSL Bump CA generation
38-
*/
39-
export interface SslBumpConfig {
40-
/** Working directory to store CA files */
41-
workDir: string;
42-
/** Common name for the CA certificate (default: 'AWF Session CA') */
43-
commonName?: string;
44-
/** Validity period in days (default: 1) */
45-
validityDays?: number;
46-
}
47-
4836
/**
4937
* Result of CA generation containing paths to certificate files
5038
*/
@@ -178,7 +166,7 @@ export function cleanupSslKeyMaterial(workDir: string): void {
178166
* @returns Paths to generated CA files
179167
* @throws Error if OpenSSL commands fail
180168
*/
181-
export async function generateSessionCa(config: SslBumpConfig): Promise<CaFiles> {
169+
export async function generateSessionCa(config: { workDir: string; commonName?: string; validityDays?: number }): Promise<CaFiles> {
182170
const { workDir, commonName = 'AWF Session CA', validityDays = 1 } = config;
183171

184172
// Create ssl directory in workDir, backed by tmpfs when possible

0 commit comments

Comments
 (0)