Skip to content

Commit e2b6482

Browse files
Mossakaclaude
andauthored
fix: remove leftover SQUID_INTERCEPT_PORT references (#548)
* fix: ensure .copilot directory permissions before Copilot CLI install The Copilot CLI verification step tries to create /home/runner/.copilot/pkg/ which fails with EACCES if the directory was previously created with root ownership (e.g., by sudo -E awf during chroot version tests). Add a step to create .copilot with correct runner ownership before the Copilot CLI install in both the .md source and lock file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove leftover SQUID_INTERCEPT_PORT references from revert The intercept mode revert (#541) missed 3 references to SQUID_INTERCEPT_PORT in docker-manager.ts: the constant definition, the port mapping on the Squid container, and the env var passed to the agent container. Squid no longer listens on port 3129, so these are dead code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 77735c9 commit e2b6482

3 files changed

Lines changed: 13 additions & 3 deletions

File tree

.github/workflows/smoke-chroot.lock.yml

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/smoke-chroot.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,10 @@ steps:
153153
if: always()
154154
run: |
155155
./scripts/ci/cleanup.sh || true
156+
- name: Ensure .copilot directory permissions
157+
run: |
158+
mkdir -p /home/runner/.copilot
159+
sudo chown -R runner:runner /home/runner/.copilot
156160
---
157161

158162
# Analyze Chroot Test Results

src/docker-manager.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { generateSquidConfig } from './squid-config';
99
import { generateSessionCa, initSslDb, CaFiles, parseUrlPatterns } from './ssl-bump';
1010

1111
const SQUID_PORT = 3128;
12-
const SQUID_INTERCEPT_PORT = 3129; // Port for transparently intercepted traffic
1312

1413
/**
1514
* Base image for the 'act' preset when building locally.
@@ -273,7 +272,7 @@ export function generateDockerCompose(
273272
retries: 5,
274273
start_period: '10s',
275274
},
276-
ports: [`${SQUID_PORT}:${SQUID_PORT}`, `${SQUID_INTERCEPT_PORT}:${SQUID_INTERCEPT_PORT}`],
275+
ports: [`${SQUID_PORT}:${SQUID_PORT}`],
277276
// Security hardening: Drop unnecessary capabilities
278277
// Squid only needs network capabilities, not system administration capabilities
279278
cap_drop: [
@@ -329,7 +328,6 @@ export function generateDockerCompose(
329328
HTTPS_PROXY: `http://${networkConfig.squidIp}:${SQUID_PORT}`,
330329
SQUID_PROXY_HOST: 'squid-proxy',
331330
SQUID_PROXY_PORT: SQUID_PORT.toString(),
332-
SQUID_INTERCEPT_PORT: SQUID_INTERCEPT_PORT.toString(),
333331
HOME: homeDir,
334332
PATH: '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',
335333
};

0 commit comments

Comments
 (0)