Refactor: eliminate dual-logging and extract logger initialization fallback helper

- Remove duplicate log.Printf calls in http_helpers.go that echoed info
  already captured by structured logger.Log* calls (extractAndValidateSession,
  logHTTPRequestBody, setupSessionCallback, withResponseLogging)
- Add shared logFallbackWarnings helper in internal/logger/init.go
- Use logFallbackWarnings in file_logger.go, server_file_logger.go,
  and tools_logger.go to eliminate repeated WARNING log pairs

Closes #4641 #4642

Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/7967a92b-368d-4295-a167-3cae7a5dfa0b

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Author: Copilot

internal/logger/file_logger.go

@@ -37,8 +37,7 @@ func setupFileLogger(file *os.File, logDir, fileName string) (*FileLogger, error
 
 // handleFileLoggerError falls back to stdout when the log file cannot be opened.
 func handleFileLoggerError(err error, logDir, fileName string) (*FileLogger, error) {
-	log.Printf("WARNING: Failed to initialize log file: %v", err)
-	log.Printf("WARNING: Falling back to stdout for logging")
+	logFallbackWarnings(err, "Failed to initialize log file", "Falling back to stdout for logging")
 	fl := &FileLogger{
 		logDir:      logDir,
 		fileName:    fileName,

internal/logger/init.go

@@ -24,3 +24,10 @@ func initWithWarning(err error, name string) {
 		log.Printf("Warning: Failed to initialize %s: %v", name, err)
 	}
 }
+
+// logFallbackWarnings prints two WARNING lines for logger initialization failure with fallback:
+// the first includes the underlying error, the second describes the fallback behavior.
+func logFallbackWarnings(err error, errMsg, fallbackMsg string) {
+	log.Printf("WARNING: %s: %v", errMsg, err)
+	log.Printf("WARNING: %s", fallbackMsg)
+}

internal/logger/server_file_logger.go

@@ -28,8 +28,7 @@ var (
 func InitServerFileLogger(logDir string) error {
 	// Create log directory if it doesn't exist
 	if err := os.MkdirAll(logDir, 0755); err != nil {
-		log.Printf("WARNING: Failed to create log directory for server logs: %v", err)
-		log.Printf("WARNING: Falling back to unified logging only")
+		logFallbackWarnings(err, "Failed to create log directory for server logs", "Falling back to unified logging only")
 		// Create a fallback logger that won't create files
 		sfl := &ServerFileLogger{
 			logDir:      logDir,

internal/logger/tools_logger.go

@@ -60,8 +60,7 @@ func setupToolsLogger(file *os.File, logDir, fileName string) (*ToolsLogger, err
 
 // handleToolsLoggerError falls back to a no-op logger when the file cannot be opened.
 func handleToolsLoggerError(err error, logDir, fileName string) (*ToolsLogger, error) {
-	log.Printf("WARNING: Failed to initialize tools log file: %v", err)
-	log.Printf("WARNING: Tools logging disabled")
+	logFallbackWarnings(err, "Failed to initialize tools log file", "Tools logging disabled")
 	tl := &ToolsLogger{
 		logDir:      logDir,
 		fileName:    fileName,

internal/server/http_helpers.go

@@ -77,7 +77,7 @@ func withResponseLogging(handler http.Handler) http.Handler {
 		handler.ServeHTTP(lw, r)
 		if len(lw.Body()) > 0 {
 			sanitizedBody := sanitize.SanitizeString(string(lw.Body()))
-			log.Printf("[%s] %s %s - Status: %d, Response: %s", r.RemoteAddr, r.Method, r.URL.Path, lw.StatusCode(), sanitizedBody)
+			logHelpers.Printf("[%s] %s %s - Status: %d, Response: %s", r.RemoteAddr, r.Method, r.URL.Path, lw.StatusCode(), sanitizedBody)
 		}
 	})
 }
@@ -93,7 +93,6 @@ func extractAndValidateSession(r *http.Request) string {
 	if sessionID == "" {
 		logHelpers.Printf("Session extraction failed: no Authorization header, remote=%s", r.RemoteAddr)
 		logger.LogError("client", "Rejected MCP client connection: no Authorization header, remote=%s, path=%s", r.RemoteAddr, r.URL.Path)
-		log.Printf("[%s] %s %s - REJECTED: No Authorization header", r.RemoteAddr, r.Method, r.URL.Path)
 		return ""
 	}
 
@@ -155,7 +154,6 @@ func logHTTPRequestBody(r *http.Request, sessionID, backendID string) {
 	} else {
 		logger.LogDebug("client", "MCP request body, session=%s, body=%s", sessionID, sanitizedBody)
 	}
-	log.Printf("Request body: %s", sanitizedBody)
 	logHelpers.Print("Request body logged for debugging")
 }
 
@@ -189,23 +187,14 @@ func setupSessionCallback(r *http.Request, backendID string) (string, bool) {
 	if backendID != "" {
 		logger.LogInfo("client", "New MCP client connection, remote=%s, method=%s, path=%s, backend=%s, session=%s",
 			r.RemoteAddr, r.Method, r.URL.Path, backendID, sessionID)
-		log.Printf("=== NEW STREAMABLE HTTP CONNECTION (ROUTED) ===")
 	} else {
 		logger.LogInfo("client", "MCP connection established, remote=%s, method=%s, path=%s, session=%s",
 			r.RemoteAddr, r.Method, r.URL.Path, sessionID)
-		log.Printf("=== NEW STREAMABLE HTTP CONNECTION ===")
 	}
-	log.Printf("[%s] %s %s", r.RemoteAddr, r.Method, r.URL.Path)
-	if backendID != "" {
-		log.Printf("Backend: %s", backendID)
-	}
-	log.Printf("Authorization (Session ID): %s", sanitize.TruncateSecret(sessionID))
 
 	logHTTPRequestBody(r, sessionID, backendID)
 
 	*r = *injectSessionContext(r, sessionID, backendID)
-	log.Printf("✓ Injected session ID into context")
-	log.Printf("===================================\n")
 
 	return sessionID, true
 }