test: strengthen tracing helper coverage

Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/348fae3e-5b56-42bd-bd42-c82af76c53b5

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Author: Copilot

go.mod

@@ -12,6 +12,7 @@ require (
 require (
 	github.com/itchyny/gojq v0.12.19
 	github.com/santhosh-tekuri/jsonschema/v5 v5.3.1
+	github.com/spf13/pflag v1.0.9
 	github.com/stretchr/testify v1.11.1
 	github.com/tetratelabs/wazero v1.11.0
 	go.opentelemetry.io/otel v1.43.0
@@ -34,7 +35,6 @@ require (
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/segmentio/asm v1.1.3 // indirect
 	github.com/segmentio/encoding v0.5.4 // indirect
-	github.com/spf13/pflag v1.0.9 // indirect
 	github.com/yosida95/uritemplate/v3 v3.0.2 // indirect
 	go.opentelemetry.io/auto/sdk v1.2.1 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.43.0 // indirect

internal/cmd/tracing_helpers_test.go

@@ -10,7 +10,7 @@ import (
 	"github.com/github/gh-aw-mcpg/internal/config"
 )
 
-func TestRegisterTracingFlags_DefaultsFromEnvAndConfig(t *testing.T) {
+func TestRegisterTracingFlags_DefaultsFromEnv(t *testing.T) {
 	t.Setenv("OTEL_EXPORTER_OTLP_ENDPOINT", "http://collector:4318")
 	t.Setenv("OTEL_SERVICE_NAME", "test-service")
 
@@ -41,4 +41,14 @@ func TestRegisterTracingFlags_DefaultsFromEnvAndConfig(t *testing.T) {
 	actualSampleRate, err := cmd.Flags().GetFloat64("otlp-sample-rate")
 	require.NoError(t, err)
 	assert.Equal(t, config.DefaultTracingSampleRate, actualSampleRate)
+
+	err = cmd.ParseFlags([]string{
+		"--otlp-endpoint=http://override:4318",
+		"--otlp-service-name=override-service",
+		"--otlp-sample-rate=0.25",
+	})
+	require.NoError(t, err)
+	assert.Equal(t, "http://override:4318", endpoint)
+	assert.Equal(t, "override-service", service)
+	assert.Equal(t, 0.25, sampleRate)
 }