Merge branch 'main' into copilot/aw-fix-blog-auditor-tool

Author: github-actions[bot]

.github/workflows/daily-go-test-parallelizer.lock.yml

@@ -13,7 +13,7 @@ permissions:
 engine:
   id: codex
   model-provider: openai
-model: openai/gpt-5.4
+model: openai/gpt-5.3-codex
 strict: true
 timeout-minutes: 30
 network:

.github/workflows/daily-go-test-parallelizer.md

@@ -1166,7 +1166,21 @@ async function processMessages(messageHandlers, messages, onItemCreated = null)
       // Check if this output was created with unresolved temporary IDs
       // For create_issue, create_discussion, add_comment - check if body has unresolved IDs
 
-      // Handle add_comment which returns an array of comments
+      // Handle the current add_comment result shape.
+      if (messageType === "add_comment" && result?.commentId && result?.repo) {
+        const contentToCheck = getContentToCheck(messageType, message, result);
+        if (contentToCheck && hasUnresolvedTemporaryIds(contentToCheck, temporaryIdMap, artifactUrlMap)) {
+          core.info(`Comment ${result.commentId} on ${result.repo}#${result.itemNumber} was created with unresolved temporary IDs - tracking for update`);
+          outputsWithUnresolvedIds.push({
+            type: messageType,
+            message,
+            result,
+            originalTempIdMapSize: tempIdMapSizeBefore,
+          });
+        }
+      }
+
+      // Handle the legacy add_comment result shape.
       if (messageType === "add_comment" && Array.isArray(result)) {
         const contentToCheck = getContentToCheck(messageType, message, result);
         if (contentToCheck && hasUnresolvedTemporaryIds(contentToCheck, temporaryIdMap, artifactUrlMap)) {
@@ -1177,12 +1191,7 @@ async function processMessages(messageHandlers, messages, onItemCreated = null)
               outputsWithUnresolvedIds.push({
                 type: messageType,
                 message: message,
-                result: {
-                  commentId: comment._tracking.commentId,
-                  itemNumber: comment._tracking.itemNumber,
-                  repo: comment._tracking.repo,
-                  isDiscussion: comment._tracking.isDiscussion,
-                },
+                result: { ...comment._tracking, ...(comment.body ? { body: comment.body } : {}) },
                 originalTempIdMapSize: tempIdMapSizeBefore,
               });
             }
@@ -1384,7 +1393,7 @@ function getContentToCheck(messageType, message, result) {
     case "create_discussion":
       return message.body || "";
     case "add_comment":
-      return message.body || "";
+      return result?.body || message.body || "";
     case "comment_memory":
       return result?.managedBody || message.body || "";
     case "create_pull_request":
@@ -2026,4 +2035,5 @@ module.exports = {
   partitionFailureResults,
   computeSafeOutputsStatus,
   setSafeOutputsStatusOutputs,
+  processSyntheticUpdates,
 };

actions/setup/js/safe_output_handler_manager.cjs

@@ -21,6 +21,7 @@ import {
   partitionFailureResults,
   computeSafeOutputsStatus,
   setSafeOutputsStatusOutputs,
+  processSyntheticUpdates,
 } from "./safe_output_handler_manager.cjs";
 
 const require = createRequire(import.meta.url);
@@ -153,6 +154,88 @@ describe("Safe Output Handler Manager", () => {
 
         expect(sortMessageIndicesByTemporaryIdDependencies([dependent, producer, unrelated])).toEqual([1, 0, 2]);
       });
+
+      it("tracks a comment emitted before its temporary-ID producer", async () => {
+        const callOrder = [];
+        const handlers = new Map([
+          [
+            "add_comment",
+            vi.fn(async (_message, resolvedTemporaryIds) => {
+              callOrder.push("add_comment");
+              expect(resolvedTemporaryIds).toEqual({});
+              return {
+                success: true,
+                commentId: 123,
+                itemNumber: 42,
+                repo: "owner/repo",
+                isDiscussion: false,
+                body: "Tracking issue: #aw_track1\n\nHandler footer marker",
+              };
+            }),
+          ],
+          [
+            "create_issue",
+            vi.fn(async () => {
+              callOrder.push("create_issue");
+              return { success: true, temporaryId: "aw_track1", repo: "owner/tracker", number: 99 };
+            }),
+          ],
+        ]);
+        const messages = [
+          { type: "add_comment", item_number: 42, body: "Tracking issue: #aw_track1" },
+          { type: "create_issue", temporary_id: "aw_track1", title: "Tracking issue" },
+        ];
+
+        const result = await processMessages(handlers, messages);
+
+        expect(callOrder).toEqual(["add_comment", "create_issue"]);
+        expect(result.temporaryIdMap.aw_track1).toEqual({ repo: "owner/tracker", number: 99 });
+        expect(result.outputsWithUnresolvedIds).toEqual([
+          {
+            type: "add_comment",
+            message: { type: "add_comment", item_number: 42, body: "Tracking issue: #aw_track1" },
+            result: {
+              success: true,
+              commentId: 123,
+              itemNumber: 42,
+              repo: "owner/repo",
+              isDiscussion: false,
+              body: "Tracking issue: #aw_track1\n\nHandler footer marker",
+            },
+            originalTempIdMapSize: 0,
+          },
+        ]);
+      });
+
+      it("updates the posted comment body while retaining handler metadata", async () => {
+        const updateComment = vi.fn().mockResolvedValue({});
+        const github = { rest: { issues: { updateComment } } };
+        const trackedOutputs = [
+          {
+            type: "add_comment",
+            message: { type: "add_comment", body: "Tracking issue: #aw_track1" },
+            result: {
+              success: true,
+              commentId: 123,
+              itemNumber: 42,
+              repo: "owner/repo",
+              isDiscussion: false,
+              body: "Tracking issue: #aw_track1\n\nHandler footer marker",
+            },
+            originalTempIdMapSize: 0,
+          },
+        ];
+
+        const updateCount = await processSyntheticUpdates(github, {}, trackedOutputs, new Map([["aw_track1", { repo: "owner/tracker", number: 99 }]]), new Map());
+
+        expect(updateCount).toBe(1);
+        expect(updateComment).toHaveBeenCalledWith({
+          owner: "owner",
+          repo: "repo",
+          comment_id: 123,
+          body: "Tracking issue: owner/tracker#99\n\nHandler footer marker",
+        });
+      });
     });
 
     describe("logCreatedItemFromResult", () => {

actions/setup/js/safe_output_handler_manager.test.cjs

@@ -46,3 +46,20 @@ func TestCompileOptionsPropagateForceRefreshContainerPins(t *testing.T) {
 		t.Fatal("expected ForceRefreshContainerPins to be propagated to CompileConfig")
 	}
 }
+
+func TestCompileOptionsPropagateModels(t *testing.T) {
+	t.Parallel()
+
+	modelsFlag := compileCmd.Flags().Lookup("models")
+	if modelsFlag == nil {
+		t.Fatal("expected --models flag on compile command")
+	}
+	if modelsFlag.DefValue != "false" {
+		t.Fatalf("expected --models default to be false, got %s", modelsFlag.DefValue)
+	}
+
+	config := (&compileCmdOptions{models: true}).toCompileConfig(nil)
+	if !config.Models {
+		t.Fatal("expected Models to be propagated to CompileConfig")
+	}
+}

cmd/gh-aw/compile_flags_test.go

@@ -428,6 +428,7 @@ type compileCmdOptions struct {
 	showAllErrors             bool
 	fix                       bool
 	stats                     bool
+	models                    bool
 	failFast                  bool
 	noCheckUpdate             bool
 	staged                    bool
@@ -472,6 +473,7 @@ func getCompileCmdOptions(cmd *cobra.Command) compileCmdOptions {
 	showAllErrors, _ := cmd.Flags().GetBool("show-all")
 	fix, _ := cmd.Flags().GetBool("fix")
 	stats, _ := cmd.Flags().GetBool("stats")
+	models, _ := cmd.Flags().GetBool("models")
 	failFast, _ := cmd.Flags().GetBool("fail-fast")
 	noCheckUpdate, _ := cmd.Flags().GetBool("no-check-update")
 	scheduleSeed, _ := cmd.Flags().GetString("schedule-seed")
@@ -488,7 +490,7 @@ func getCompileCmdOptions(cmd *cobra.Command) compileCmdOptions {
 		validate: validate, watch: watch, noEmit: noEmit, purge: purge, strict: strict, trial: trial, dependabot: dependabot,
 		forceOverwrite: forceOverwrite, refreshStopTime: refreshStopTime, forceRefreshActionPins: forceRefreshActionPins, forceRefreshContainerPins: forceRefreshContainerPins, allowActionRefs: allowActionRefs,
 		zizmor: zizmor, poutine: poutine, actionlint: actionlint, runnerGuard: runnerGuard, syft: syft, grype: grype, grant: grant, yamllint: yamllint, shellcheck: shellcheck,
-		jsonOutput: jsonOutput, showAllErrors: showAllErrors, fix: fix, stats: stats, failFast: failFast, noCheckUpdate: noCheckUpdate,
+		jsonOutput: jsonOutput, showAllErrors: showAllErrors, fix: fix, stats: stats, models: models, failFast: failFast, noCheckUpdate: noCheckUpdate,
 		staged: staged, approve: approve, validateImages: validateImages, ghes: ghes, verbose: verbose, useSamples: useSamples,
 	}
 }
@@ -521,7 +523,7 @@ func (o *compileCmdOptions) toCompileConfig(args []string) cli.CompileConfig {
 		Dependabot: o.dependabot, ForceOverwrite: o.forceOverwrite, RefreshStopTime: o.refreshStopTime, ForceRefreshActionPins: o.forceRefreshActionPins, ForceRefreshContainerPins: o.forceRefreshContainerPins,
 		AllowActionRefs: o.allowActionRefs, Zizmor: o.zizmor, Poutine: o.poutine, Actionlint: o.actionlint, RunnerGuard: o.runnerGuard,
 		Syft: o.syft, Grype: o.grype, Grant: o.grant, Yamllint: o.yamllint, Shellcheck: o.shellcheck, JSONOutput: o.jsonOutput, ShowAllErrors: o.showAllErrors,
-		Stats: o.stats, FailFast: o.failFast, ScheduleSeed: o.scheduleSeed, Staged: o.staged, Approve: o.approve,
+		Stats: o.stats, Models: o.models, FailFast: o.failFast, ScheduleSeed: o.scheduleSeed, Staged: o.staged, Approve: o.approve,
 		ValidateImages: o.validateImages, PriorManifestFile: o.priorManifestFile, GHESCompat: o.ghes, UseSamples: o.useSamples,
 	}
 }
@@ -546,7 +548,9 @@ func runCompileCmd(cmd *cobra.Command, args []string) error {
 			return err
 		}
 	}
-	if _, err := cli.CompileWorkflows(cmd.Context(), opts.toCompileConfig(args)); err != nil {
+	config := opts.toCompileConfig(args)
+	cli.PrepareCompileModelValidation(cmd.Context(), &config)
+	if _, err := cli.CompileWorkflows(cmd.Context(), config); err != nil {
 		return err
 	}
 	return nil
@@ -793,6 +797,7 @@ func configureCompileToolFlags() {
 	compileCmd.Flags().BoolP("json", "j", false, "Output results in JSON format")
 	compileCmd.Flags().Bool("show-all", false, "Display all compilation errors instead of only the highest-priority subset (default: top 5)")
 	compileCmd.Flags().Bool("stats", false, "Display statistics table sorted by workflow file size (shows jobs, steps, scripts, and shells)")
+	compileCmd.Flags().Bool("models", false, "Warn when models configured in models or engine.models are absent from the active model inventory")
 	compileCmd.Flags().Bool("fail-fast", false, "Stop at the first validation error instead of collecting all errors")
 	compileCmd.Flags().Bool("no-check-update", false, "Skip checking for gh-aw updates")
 	compileCmd.Flags().String("schedule-seed", "", "Override the repository slug (owner/repo) used as seed for fuzzy schedule scattering (e.g., \"github/gh-aw\"). Bypasses git remote detection entirely. Use this when your git remote is not named \"origin\" and you have multiple remotes configured")