[Contribution Check Report] PR #20864 — refactor: replace hardcoded /opt/gh-aw/ paths with GhAwHome constants #20911
Description
Contribution Check Report
| Field | Value |
|---|---|
| PR | #20864 |
| Author | @Copilot |
| Verdict | 🟢 Aligned |
| Quality | lgtm |
| On-topic | ✅ yes |
| Follows process | ✅ yes |
| Focused | ✅ yes |
| New deps | ✅ no |
| Has tests | ✅ yes |
| Has description | ✅ yes |
| Lines changed | 26,118 (13,843 additions / 12,275 deletions) |
| Existing labels | smoke, smoke-claude, smoke-copilot |
Checklist Detail
On-topic — The PR is a focused internal refactor performed by the GitHub Copilot coding agent, directly in line with the project's stated agentic-development model. The change improves self-hosted runner configurability by eliminating hardcoded /opt/gh-aw paths — clearly within scope.
Follows process — The PR was created by the Copilot SWE agent, assigned to a core team member (pelikhan), and includes a changeset file (.changeset/patch-gh-aw-home-path-constants.md). This exactly matches the CONTRIBUTING.md process: "Core team uses agents to create and manage pull requests."
Focused — All 257 changed files serve one goal: propagate GhAwHome constants throughout the compiler, setup scripts, and regenerated lock files. The large file count is expected because all 173 workflow lock files were recompiled (per PR description).
New deps — No changes to go.mod, go.sum, package.json, or any other dependency manifest.
Has tests — 9 Go test files updated in pkg/workflow/: agentic_output_test.go, agentic_workflow_test.go, aw_info_tmp_test.go, cache_memory_integration_test.go, cjs_require_validation_test.go, codex_engine_test.go, compiler_custom_actions_test.go, compiler_safe_outputs_steps_test.go, and compiler_yaml_main_job_test.go — all updated to assert the new dynamic path forms.
Has description — Detailed description covering every changed subsystem: new constants/helpers, setup scripts, compiler files, tests, and golden files.
Notes
The spike in line count (26 k) is almost entirely mechanical: the PR description states "Recompiled all 173 workflow lock files", which accounts for the bulk of additions/deletions. The core logic change is small and surgical (pkg/workflow/setup_action_paths.go, pkg/constants/constants.go, a handful of compiler files, and setup shell scripts).
Generated by Contribution Check · ◷
- expires on Mar 15, 2026, 5:22 AM UTC