Replies: 1 comment
|
To add to this, even if only merging the bottom PR of a stack (1 in your example), it now appears to use the merger's email instead of the PR author like a non-stacked PR. Example for bottom PR of stack merged: home-assistant/android#7189 and home-assistant/android@9bbcd0d - merged shows user jpelgrom, patch shows |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I created a stack of three PRs (master <- 1 <- 2 <- 3) that were all created by myself. All commits in the PRs were also created by myself.
A co-worker approved PRs 1 and 2 and then merged PR 2 using the “Squash and merge Stack” functionality. As expected this resulted in two commits on master, carrying the expected commit message and committer. The author field of the resulting commits however was internally inconsistent:
The real name matches my name (PR author), but the email address matches that of my coworker (PR merger):
For regular non-stacked PRs, the author information correctly shows my real name + the email address I used for the PR’s commits (my corporate email address, rather than my GitHub default email address).
All reactions