Merge pull request #284 from github/smockle/untitled

smockle · web-flow · commit ed0833b0cddc · 2024-05-31T14:32:50.000-04:00
fix: Move `noTitle` conditional.
diff --git a/src/relative-time-element.ts b/src/relative-time-element.ts
@@ -440,9 +440,9 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor
       return
     }
     const now = Date.now()
-    if (!this.#customTitle && !this.noTitle) {
+    if (!this.#customTitle) {
       newTitle = this.#getFormattedTitle(date) || ''
-      if (newTitle) this.setAttribute('title', newTitle)
+      if (newTitle && !this.noTitle) this.setAttribute('title', newTitle)
     }
 
     const duration = elapsedTime(date, this.precision, now)

Original file line number	Diff line number	Diff line change
`@@ -440,9 +440,9 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor`
`440`	`440`	`return`
`441`	`441`	`}`
`442`	`442`	`const now = Date.now()`
`443`		`- if (!this.#customTitle && !this.noTitle) {`
	`443`	`+ if (!this.#customTitle) {`
`444`	`444`	`newTitle = this.#getFormattedTitle(date) \|\| ''`
`445`		`- if (newTitle) this.setAttribute('title', newTitle)`
	`445`	`+ if (newTitle && !this.noTitle) this.setAttribute('title', newTitle)`
`446`	`446`	`}`
`447`	`447`
`448`	`448`	`const duration = elapsedTime(date, this.precision, now)`