Skip to content

[Schema Inaccuracy] pull-request-review-comment.user should be nullable-simple-user #4266

Open
@mnahkies

Description

Schema Inaccuracy

the user property of pull-request-review-comment should be #/components/schemas/nullable-simple-user instead of #/components/schemas/simple-user - same as on pull-request-review

I suspect the same is true for pull-request, presumably this occurs when a user is deleted. It seems probable that most, if not all usages of simple-user should be replaced with nullable-simple-user

Expected

Any user properties that are nulled when the associated user is deleted should be nullable-simple-user

Reproduction Steps

(I didn't make a note of the exact resource I observed this on, but will update when I next find one)

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions